Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saved addresses in activity 13663 #14069

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Fix saved addresses in activity 13663 #14069

merged 4 commits into from
Mar 25, 2024

Conversation

stefandunca
Copy link
Contributor

@stefandunca stefandunca commented Mar 20, 2024 •
edited
Loading

Closes #13663

Refresh recipients in menu for activity filter

Also

  • fix namespace clash in wallet RootStore
  • lazy load TransactionDetailView
  • wrong properties referenced in TransactionDetailView

@stefandunca
fix(wallet) fix namespace clash in wallet RootStore.qml
be75797 
Updates: #13663
@stefandunca
chore(wallet) lazy load TransactionDetailView
caf0c78 
I was debugging a crash at login and found out that
TransactionDetailView was being loaded even when it was not being used;
my debugging code in `onComplete` was trying to access transaction data
from nim which was not set.

Updates #13663
@stefandunca
fix(wallet) wrong properties referenced in TransactionDetailView
bd8492f 
Updates: #13663
@stefandunca stefandunca mentioned this pull request Mar 20, 2024
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Mar 20, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bd8492f #1 2024-03-20 19:57:39 ~6 min tests/nim 📄log
✔️ bd8492f #1 2024-03-20 19:58:37 ~7 min macos/aarch64 🍎dmg
✔️ bd8492f #1 2024-03-20 20:02:21 ~10 min tests/ui 📄log
✔️ bd8492f #1 2024-03-20 20:04:05 ~12 min macos/x86_64 🍎dmg
✔️ bd8492f #1 2024-03-20 20:07:28 ~16 min linux/x86_64 📦tgz
✔️ bd8492f #1 2024-03-20 20:24:42 ~33 min windows/x86_64 💿exe
✔️ 326721e #2 2024-03-21 11:52:23 ~5 min macos/aarch64 🍎dmg
✔️ 326721e #2 2024-03-21 11:53:10 ~6 min tests/nim 📄log
✔️ 326721e #2 2024-03-21 11:54:59 ~8 min macos/x86_64 🍎dmg
✔️ 326721e #2 2024-03-21 11:58:03 ~11 min tests/ui 📄log
✔️ 326721e #2 2024-03-21 12:01:23 ~14 min linux/x86_64 📦tgz
✔️ 326721e #2 2024-03-21 12:20:07 ~33 min windows/x86_64 💿exe

@anastasiyaig anastasiyaig mentioned this pull request Mar 21, 2024
Closed
@anastasiyaig
Copy link
Contributor

we need that in 2.28 rc please

@stefandunca stefandunca marked this pull request as ready for review March 21, 2024 11:47
@stefandunca stefandunca mentioned this pull request Mar 21, 2024
Merged
1 task
IvanBelyakoff
IvanBelyakoff approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@IvanBelyakoff IvanBelyakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Stefan. I guess you fixed those annoying qml warning, right?

@stefandunca stefandunca merged commit 42d3c1b into master Mar 25, 2024
8 checks passed
@stefandunca stefandunca deleted the fix_saved_addresses_in_activity-13663 branch March 25, 2024 17:38
@stefandunca
Copy link
Contributor Author

Good job, Stefan. I guess you fixed those annoying qml warning, right?

No, they were unrelated. I had a quick glance but nothing stood out so I left it for later.

@stefandunca stefandunca mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanBelyakoff IvanBelyakoff IvanBelyakoff approved these changes

@saledjenic saledjenic saledjenic approved these changes

@Cuteivist Cuteivist Awaiting requested review from Cuteivist

@dlipicar dlipicar Awaiting requested review from dlipicar

@Khushboo-dev-cpp Khushboo-dev-cpp Awaiting requested review from Khushboo-dev-cpp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering TXs history issue
5 participants
@stefandunca @status-im-auto @anastasiyaig @IvanBelyakoff @saledjenic