Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a banner for Owners when the member re-evaluation is in progress #14378

Closed
jrainville opened this issue Apr 9, 2024 · 2 comments · Fixed by #14616
Closed

Add a banner for Owners when the member re-evaluation is in progress #14378

jrainville opened this issue Apr 9, 2024 · 2 comments · Fixed by #14616
Assignees
Labels
backend-team E:Desktop Comm Perms and Minting MVP Misc tasks about Community permissions that are not part of another Epic, due for the MVP feature
Milestone

Comments

@jrainville
Copy link
Member

Description

Currently, the member re-evaluation that happens periodically and when permissions are modified takes a lot of time (more than 10 minutes).

Since the process needs to fully end for it to take effect, closing the app as an owner when it runs is not ideal. It won't break anything, but it means that the process will need to be re-done.

What would be needed is a banner that shows when the re-evaluation is in progress. That way, the owner knows that something is going on (in case of higher network activity + CPU usage) and to tell them not to close the app.

Acceptance Criteria

  • When the member re-evaluation is in progress, a banner is shown that says something like "Member re-evaluation in progress in COMMUNITY_NAME. Please do not close the app."
  • The banner can be green as it's not something that is dangerous
  • The banner cannot be dismissed
@jrainville jrainville added feature backend-team E:Desktop Comm Perms and Minting MVP Misc tasks about Community permissions that are not part of another Epic, due for the MVP labels Apr 9, 2024
@jrainville jrainville added this to the 2.29.0 Beta milestone Apr 9, 2024
@igor-sirotin
Copy link
Contributor

igor-sirotin commented Apr 10, 2024

Related I suppose: #14379

@osmaczko
Copy link
Contributor

I think it is better to add busy indicator/rotator on a members list rather than banner.

@jrainville jrainville assigned mprakhov and jrainville and unassigned mprakhov Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend-team E:Desktop Comm Perms and Minting MVP Misc tasks about Community permissions that are not part of another Epic, due for the MVP feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants