Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(community): show a message when the member reevaluation is ongoing #14616

Merged
merged 1 commit into from
May 8, 2024

Conversation

jrainville
Copy link
Member

@jrainville jrainville commented May 6, 2024

Fixes #14378

This is only for the control node. We can improve the UI later

status-go PR: status-im/status-go#5120

reevaluation-message.webm

@status-im-auto
Copy link
Member

status-im-auto commented May 6, 2024

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cded036 #1 2024-05-06 21:14:59 ~6 min tests/nim 📄log
✔️ cded036 #1 2024-05-06 21:15:57 ~7 min macos/aarch64 🍎dmg
✔️ cded036 #1 2024-05-06 21:22:47 ~14 min macos/x86_64 🍎dmg
✔️ cded036 #1 2024-05-06 21:24:47 ~16 min tests/ui 📄log
✔️ cded036 #1 2024-05-06 21:25:37 ~17 min linux/x86_64 📦tgz
✔️ cded036 #1 2024-05-06 21:41:30 ~33 min windows/x86_64 💿exe
✔️ 1e84092 #2 2024-05-07 18:55:40 ~6 min macos/aarch64 🍎dmg
✔️ 1e84092 #2 2024-05-07 18:59:23 ~9 min macos/x86_64 🍎dmg
✔️ 1e84092 #2 2024-05-07 19:00:18 ~10 min tests/nim 📄log
1e84092 #2 2024-05-07 19:06:41 ~17 min tests/ui 📄log
✔️ 1e84092 #2 2024-05-07 19:13:32 ~23 min linux/x86_64 📦tgz
✔️ 1e84092 #2 2024-05-07 19:20:21 ~30 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5254095 #3 2024-05-08 18:51:51 ~6 min macos/aarch64 🍎dmg
✔️ 5254095 #3 2024-05-08 18:55:28 ~9 min macos/x86_64 🍎dmg
✔️ 5254095 #3 2024-05-08 18:55:29 ~9 min tests/nim 📄log
✔️ 5254095 #3 2024-05-08 19:01:32 ~15 min tests/ui 📄log
✔️ 5254095 #3 2024-05-08 19:05:06 ~19 min linux/x86_64 📦tgz
✔️ 5254095 #3 2024-05-08 19:18:17 ~32 min windows/x86_64 💿exe
✔️ e223f1a #4 2024-05-08 20:03:19 ~6 min macos/aarch64 🍎dmg
✔️ e223f1a #4 2024-05-08 20:05:32 ~8 min macos/x86_64 🍎dmg
✔️ e223f1a #4 2024-05-08 20:07:18 ~10 min tests/nim 📄log
✔️ e223f1a #4 2024-05-08 20:08:05 ~10 min tests/ui 📄log
✔️ e223f1a #4 2024-05-08 20:17:13 ~19 min linux/x86_64 📦tgz
✔️ e223f1a #4 2024-05-08 20:29:28 ~32 min windows/x86_64 💿exe

visible: root.communityMemberReevaluationInProgress
height: visible ? implicitHeight : 0
anchors.top: titleText.bottom
anchors.topMargin: visible ? Style.current.padding : 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be simplified a little but with margins: Style.current.padding

@jrainville jrainville force-pushed the fix/hide-permission-disables-permission branch from cded036 to 1e84092 Compare May 7, 2024 18:49
@jrainville
Copy link
Member Author

Good idea @mprakhov . Updated

@jrainville jrainville force-pushed the fix/hide-permission-disables-permission branch from 1e84092 to 5254095 Compare May 8, 2024 18:45
Copy link
Contributor

@mprakhov mprakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jrainville jrainville force-pushed the fix/hide-permission-disables-permission branch from 5254095 to e223f1a Compare May 8, 2024 19:57
@jrainville jrainville merged commit 953fff0 into master May 8, 2024
8 checks passed
@jrainville jrainville deleted the fix/hide-permission-disables-permission branch May 8, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a banner for Owners when the member re-evaluation is in progress
4 participants