Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wallet Connect connection flow #14556

Closed
8 tasks done
clauxx opened this issue Apr 30, 2024 · 1 comment
Closed
8 tasks done

Add Wallet Connect connection flow #14556

clauxx opened this issue Apr 30, 2024 · 1 comment
Assignees
@stefandunca
Labels
dapp-interactions-team E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature
Milestone
2.30.0 Beta

Comments

@clauxx
Copy link
Member

clauxx commented Apr 30, 2024 •
edited by stefandunca
Loading

Description

As a user, I want to connect to dApps so that they can send me signing requests in the future.

In order for the user to be able to receive signing requests (e.g. transactions), they should be able to connect to a dApp by pasting a URL. Design fidelity is not yet a priority, so we should aim for the simplest solution by using existing UI elements and focus on the UX.

Design link

NOTE: connecting via the "All accounts" screen is out of scope for this user story

Acceptance Criteria
@clauxx clauxx added E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature labels Apr 30, 2024
stefandunca added a commit that referenced this issue May 2, 2024
@stefandunca
feat(dapps) wallet connect pairing
bf2e4b4 
- [ ] add DAppsStore
Start Wallet Connect SDK using web engine after wallet is ready

Updates #14556
@noeliaSD noeliaSD mentioned this issue May 3, 2024
Open
8 tasks
stefandunca added a commit that referenced this issue May 3, 2024
@stefandunca
feat(dapps) implement wallet connect URI input
9fc120c 
Other changes

- start Wallet Connect SDK using web engine after wallet is ready
- source WC project ID from the constants in nim
- close list when opening the `ConnectDappModal`
- remove the old POC modal instantiation
- rename ConnectDappPopup to Modal for consistency
- move specific dapps related user settings to their place in the component
- add DAppsStore to be used for dapps abstraction

Updates #14556
stefandunca added a commit that referenced this issue May 3, 2024
@stefandunca
chore(storybook) add ConnectDappModal to story book
44d365c 
Updates: #14556
stefandunca added a commit that referenced this issue May 3, 2024
@stefandunca
chore(storybook) add ConnectDappModal to story book
a5e5c3f 
Also:

- add `stub-resources.qrc` to load WalletConnect SDK in storybook for
  easier iterating of development
- mock FeatureFlags nim to silence `Global.qml` warnings

Updates: #14556
@stefandunca stefandunca mentioned this issue May 3, 2024
Merged
stefandunca added a commit that referenced this issue May 3, 2024
@stefandunca
feat(dapps) implement wallet connect URI input
d6f0b84 
Other changes

- start Wallet Connect SDK using web engine after wallet is ready
- source WC project ID from the constants in nim
- close list when opening the `ConnectDappModal`
- remove the old POC modal instantiation
- rename ConnectDappPopup to Modal for consistency
- move specific dapps related user settings to their place in the component
- add DAppsStore to be used for dapps abstraction

Updates #14556
stefandunca added a commit that referenced this issue May 3, 2024
@stefandunca
chore(storybook) add ConnectDappModal to story book
c8509ea 
Also:

- add `stub-resources.qrc` to load WalletConnect SDK in storybook for
  easier iterating of development
- mock FeatureFlags nim to silence `Global.qml` warnings

Updates: #14556
stefandunca added a commit that referenced this issue May 4, 2024
@stefandunca
feat(dapps) implement wallet connect URI input
db57b73 
Other changes

- start Wallet Connect SDK using web engine after wallet is ready
- source WC project ID from the constants in nim
- close list when opening the `ConnectDappModal`
- remove the old POC modal instantiation
- rename ConnectDappPopup to Modal for consistency
- move specific dapps related user settings to their place in the component
- add DAppsStore to be used for dapps abstraction

Updates #14556
stefandunca added a commit that referenced this issue May 4, 2024
@stefandunca
chore(storybook) add ConnectDappModal to story book
25db59b 
Also:

- add `stub-resources.qrc` to load WalletConnect SDK in storybook for
  easier iterating of development
- mock FeatureFlags nim to silence `Global.qml` warnings

Updates: #14556
stefandunca added a commit that referenced this issue May 10, 2024
@stefandunca
feat(dapps) implement wallet connect URI input
cccb583 
Other changes

- start Wallet Connect SDK using web engine after wallet is ready
- source WC project ID from the constants in nim
- close list when opening the `ConnectDappModal`
- remove the old POC modal instantiation
- rename ConnectDappPopup to Modal for consistency
- move specific dapps related user settings to their place in the component
- add DAppsStore to be used for dapps abstraction

Updates #14556
stefandunca added a commit that referenced this issue May 10, 2024
@stefandunca
chore(storybook) add ConnectDappModal to story book
7392d0e 
Also:

- mock FeatureFlags nim to silence `Global.qml` warnings

Updates: #14556
stefandunca added a commit that referenced this issue May 13, 2024
@stefandunca
feat(dapps) implement wallet connect URI input
1f60410 
Other changes

- start Wallet Connect SDK using web engine after wallet is ready
- source WC project ID from the constants in nim
- close list when opening the `ConnectDappModal`
- remove the old POC modal instantiation
- rename ConnectDappPopup to Modal for consistency
- move specific dapps related user settings to their place in the component
- add DAppsStore to be used for dapps abstraction

Updates #14556
stefandunca added a commit that referenced this issue May 13, 2024
@stefandunca
chore(storybook) add ConnectDappModal to story book
4dfa0a1 
Also:

- mock FeatureFlags nim to silence `Global.qml` warnings

Updates: #14556
@clauxx clauxx added this to the 2.30.0 Beta milestone May 14, 2024
@stefandunca
Copy link
Contributor

I moved The user should see a notification if the connection was successful to its own issue to be tackled with a lower priority #14754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefandunca stefandunca

Labels
dapp-interactions-team E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.30.0 Beta
Development

No branches or pull requests
2 participants
@clauxx @stefandunca