-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dapps) add DAppsService component and ConnectDAppModal #14615
Conversation
Jenkins BuildsClick to see older builds (51)
|
1555892
to
8e79216
Compare
25db59b
to
7392d0e
Compare
76b4f9e
to
6841757
Compare
1a95bf9
to
9ce7926
Compare
5ee9824
to
97a50cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! 👍
- The only blocker for me is that I can't test it and IDK if it's some setup/config I'm missing or it's a bug somewhere.
Screen.Recording.2024-05-16.at.23.03.39.mov
Debug: WC WalletConnectSDK.wcCall.pair; pairLink: wc:465a7cf1a1dc8cf745c20a25e96203a49a8d0a3f32d53be41b96639a4f969000@2?expiryTimestamp=1715890121&relay-protocol=irn&symKey=5936d61cf931e0d831a749d96f7ce3ada9bbef132fa9f2009946b456db20eb6d (qrc:/app/AppLayouts/Wallet/services/dapps/WalletConnectSDK.qml:224, pair)
Debug: WC WalletConnectSDK.onPairResponse; error: Cannot read property 'pair' of null (qrc:/app/AppLayouts/Wallet/services/dapps/WalletConnectSDK.qml:450, onPairResponse)
- These colours are ok in the app? I can't reach this state
Thanks for the feedback.
The only thing I can think of is the limitation we have that only one instance of status-desktop is working loading the SDK. However, in this case you should see an earlier webengine error that storage can't be accessed. I postponed to look more into this. Please try again, closing the other instances if you have open :(
I fixed the background, thanks for the heads up. Please have another look. |
97a50cc
to
3493085
Compare
Storybook: also automate related workflows for faster iteration Also extend the inspector utils to handle Loaders and Popups Updates: #14607
Allow to show all selected icons in the network filter Hide checkboxes in the network filter dropdown Updates #14607
Implement the initial Pairing user workflow and disconnect option for the first session. Also - rename pairing modal accordingly (`PairWCModal.qml`) to make room for the proper `ConnectDAppModal.qml` - basic tests for service helpers - update storybook to reflect the new user workflows Closes #14607
3493085
to
7fabb60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Sorry for the delay
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
Closes #14607
Implement the initial Pairing user workflow and disconnect option forthe first session.
Also
PairWCModal.qml
) to make room for the properConnectDAppModal.qml
HEAD~1
: feat(wallet) customize NetworkFilter for dapps displayHEAD~2
: chore(dapps) move dApps UX into its own DAppsWorkflow componentHEAD~3
: chore(dapps) move wallet connect service code outside popupsHEAD~4
: chore(storybook) load WalletConnect SDK in storybook by QRC for nowDemo using test dApp at https://react-app.walletconnect.com/
connect_wc_flow.mov