Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for all users to pin messages in community #5662

Closed
jrainville opened this issue May 6, 2022 · 1 comment · Fixed by #5695
Closed

Add option for all users to pin messages in community #5662

jrainville opened this issue May 6, 2022 · 1 comment · Fixed by #5695
Assignees
Labels

Comments

@jrainville
Copy link
Member

jrainville commented May 6, 2022

Design https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=2636%3A359221

This needs changes in status-go

Clarification: All users will then be able to pin any message in the community when enabled.

@0x-r4bbit 0x-r4bbit self-assigned this May 10, 2022
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 10, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
`CommunitySettings` which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

1. If turned off, members cannot send a pin message
2. If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
@0x-r4bbit
Copy link
Member

Looked into this. Turns out all members are already able to pin any message within the community. We just don't allow it via the UI.

I've created status-im/status-go#2668 to account for this.

0x-r4bbit added a commit to status-im/status-go that referenced this issue May 10, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
`CommunitySettings` which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

1. If turned off, members cannot send a pin message
2. If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit that referenced this issue May 10, 2022
This adds a checkbox to configure whether or not community members are
allowed to pin any message of a community channel, based on the newly
introduced `CommunityAdminSettings` that are introduced in status-im/status-go#2668

Closes #5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 10, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
`CommunitySettings` which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

1. If turned off, members cannot send a pin message
2. If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 11, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
`CommunitySettings` which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

1. If turned off, members cannot send a pin message
2. If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 11, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
`CommunitySettings` which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

1. If turned off, members cannot send a pin message
2. If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 13, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
`CommunitySettings` which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

1. If turned off, members cannot send a pin message
2. If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit that referenced this issue May 13, 2022
This adds a checkbox to configure whether or not community members are
allowed to pin any message of a community channel, based on the newly
introduced `CommunityAdminSettings` that are introduced in status-im/status-go#2668

Closes #5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 13, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
CommunitySettings which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

If turned off, members cannot send a pin message
If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 13, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
CommunitySettings which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

If turned off, members cannot send a pin message
If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 13, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
CommunitySettings which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

If turned off, members cannot send a pin message
If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 13, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
CommunitySettings which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

If turned off, members cannot send a pin message
If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 17, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
`CommunitySettings` which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

1. If turned off, members cannot send a pin message
2. If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 18, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
`CommunitySettings` which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

1. If turned off, members cannot send a pin message
2. If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit to status-im/status-go that referenced this issue May 18, 2022
This allows to store community admin settings that are meant to be propagated
to community members (as opposed to the already existing
`CommunitySettings` which are considered local to every account).

The first setting introduced as part of this commit is one that enables
community admins to configure whether or not members of the community
are allowed to pin messages in community channels.

Prior to this commit, this was not restricted at all on the protocol
level and only enforced by clients via UI (e.g. members don't see an
option to pin messages, although they could).

This config setting now ensures that:

1. If turned off, members cannot send a pin message
2. If turned off, pin messages from members are not handled/processed

This is needed by status-im/status-desktop#5662
0x-r4bbit added a commit that referenced this issue May 19, 2022
This adds a checkbox to configure whether or not community members are
allowed to pin any message of a community channel, based on the newly
introduced `CommunityAdminSettings` that are introduced in status-im/status-go#2668

Closes #5662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants