feat(@desktop/communities): automatically encrypt closed communities #10556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprakhov
requested review from
a team,
iurimatias,
Cuteivist,
MishkaRogachev and
jrainville
and removed request for
a team
Jenkins BuildsClick to see older builds (14)
|
|
@mprakhov Could you pls add status go pr link? :) |
stefandunca
approved these changes
May 4, 2023
|
status-go PR status-im/status-go#3455 |
jrainville
reviewed
May 4, 2023
mprakhov
force-pushed
the
mp/feat/issue-9942
branch
2 times, most recently
from
cf52db0
to
4631941
Compare
|
i tested it in terms of regressions and it looks okay. Creating / leaving communtiy, adding, removing permissions to communities with different level of access (open / request to join). Sadly i can't really verify the encryption thing being On/Off because it is happening totally hidden to user and i was not able to find anything related to this in DB (status-im/status-go#3417 (comment)) |
anastasiyaig
approved these changes
May 5, 2023
jrainville
approved these changes
May 5, 2023
mprakhov
force-pushed
the
mp/feat/issue-9942
branch
from
4631941
to
ef96b10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Create/edit encrypted community option removed
The community will be encrypted automatically if the community will be closed and decrypted if it became open
Fixed bug, when edition community description changed encryption
Closes: #9942
Status-go PR: status-im/status-go#3455
Affected areas
Community encryption
Status-go PR status-im/status-go#3455