chore[UI - Wallet Stability] Rename SendModalFooter to TransactionModalFooter #15497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
commented
Jul 8, 2024
There was a problem hiding this comment.
This was a rename... No idea what's going wrong with GitHub
On branch 15212-rename-sendmodalfooter-to-transactionmodalfooter
Your branch is ahead of 'origin/15212-rename-sendmodalfooter-to-transactionmodalfooter' by 1 commit.
(use "git push" to publish your local commits)
Changes to be committed:
(use "git restore --staged <file>..." to unstage)
modified: ui/imports/shared/popups/send/SendModal.qml
renamed: ui/imports/shared/popups/send/views/SendModalFooter.qml -> ui/imports/shared/popups/send/views/TransactionModalFooter.qml
modified: ui/imports/shared/popups/send/views/qmldir
Jenkins Builds
|
…alFooter ... and remove particular code for send modal - derive the footer from the standard `StatusDialogFooter` to reduce code duplication (drop shadow, divider, margins, etc) - rename the default button text - expose the icon name and make it used the correct login/auth type icon - some minor fixes and cleanups Fixes #15212
caybro
force-pushed
the
15212-rename-sendmodalfooter-to-transactionmodalfooter
branch
from
c51ab1e
to
19157ee
Compare
noeliaSD
approved these changes
Jul 9, 2024
caybro
deleted the
15212-rename-sendmodalfooter-to-transactionmodalfooter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
... and remove particular code for send modal
StatusDialogFooterto reduce code duplication (drop shadow, divider, margins, etc)Fixes #15212
Affected areas
SendModal
Screenshot of functionality (including design for comparison)