Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI - Wallet Stability] Rename SendModalFooter to TransactionModalFooter and remove particular code for send modal #15212

Closed
Tracked by #14711
noeliaSD opened this issue Jun 17, 2024 · 2 comments · Fixed by #15497
Closed
Tracked by #14711

[UI - Wallet Stability] Rename SendModalFooter to TransactionModalFooter and remove particular code for send modal #15212

noeliaSD opened this issue Jun 17, 2024 · 2 comments · Fixed by #15497
Assignees
@caybro
Labels
E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor ui-team
Milestone
2.30.0 Beta

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented Jun 17, 2024 •
edited by caybro
Loading

Design

Screenshot 2024-06-17 at 15 49 45

  • Rename SendModalFooter to TransactionModalFooter. It will be used by SendModal but also but BridgeModal and probably by SwapModal.
  • Rename the following properties inside the component:
    • nextButton.text: qsTr("Send") --> qsTr("Next")
    • objectName: "sendModalFooterSendButton" --> "transactionModalFooterButton"
    • Expose authentication method icon : nextButton.icon.name as a property
@noeliaSD noeliaSD mentioned this issue Jun 17, 2024
Open
12 tasks
@noeliaSD noeliaSD added ui-team refactor E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality labels Jun 17, 2024
@noeliaSD noeliaSD added this to the 2.30.0 Beta milestone Jun 17, 2024
@noeliaSD noeliaSD changed the title Rename SendModalFooter to TransactionModalFooter and remove particular code for send modal [UI - Wallet Stability] Rename SendModalFooter to TransactionModalFooter and remove particular code for send modal Jun 17, 2024
This was referenced Jun 17, 2024
Closed
Open
@noeliaSD noeliaSD assigned noeliaSD and unassigned micieslak Jun 21, 2024
@noeliaSD noeliaSD assigned caybro and unassigned noeliaSD Jul 8, 2024
@caybro
Copy link
Member

caybro commented Jul 8, 2024

Codewise this is a good idea but design wise, what are we getting? They are simply not the same:

Send:
image

Bridge:
image

SwapModal:
image

SwapSign:
image

SwapApprove:
image

Each and every of the variations is different :)

@noeliaSD
Copy link
Contributor Author

noeliaSD commented Jul 8, 2024

I was just considering Send and Bridge usecases here. If you see it's possible to share something with swap, go ahead, otherwise, just Send and Bridge! Thanks for sharing your thoughts!

caybro added a commit that referenced this issue Jul 8, 2024
@caybro
chore[UI - Wallet Stability] Rename SendModalFooter to TransactionMod…
c51ab1e 
…alFooter

... and remove particular code for send modal

- derive the footer from the standard `StatusDialogFooter` to reduce
code duplication (drop shadow, divider, margins, etc)
- rename the default button text
- expose the icon name and make it used the correct login/auth type icon
- some minor fixes and cleanups

Fixes #15212
@caybro caybro mentioned this issue Jul 8, 2024
Merged
1 task
@caybro caybro linked a pull request Jul 8, 2024 that will close this issue
chore[UI - Wallet Stability] Rename SendModalFooter to TransactionModalFooter #15497
Merged
1 task
caybro added a commit that referenced this issue Jul 9, 2024
@caybro
chore[UI - Wallet Stability] Rename SendModalFooter to TransactionMod…
19157ee 
…alFooter

... and remove particular code for send modal

- derive the footer from the standard `StatusDialogFooter` to reduce
code duplication (drop shadow, divider, margins, etc)
- rename the default button text
- expose the icon name and make it used the correct login/auth type icon
- some minor fixes and cleanups

Fixes #15212
@caybro caybro closed this as completed in 8504fb5 Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor ui-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.30.0 Beta
3 participants
@caybro @micieslak @noeliaSD