-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select bloom filter level #3004
Conversation
var FullNode = false | ||
var BloomFilterMode = false | ||
case level: | ||
of "light": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could put those in constants?
switch(nodeModel.bloomLevel){ | ||
case "light": btnBloomLight.click(); break; | ||
case "normal": btnBloomNormal.click(); break; | ||
case "full": btnBloomFull.click(); break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again could be put in Constants.
BloomSelectorButton { | ||
id: btnBloomLight | ||
buttonGroup: bloomGroup | ||
checkedByDefault: nodeModel.bloomLevel == "light" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you put triple equals for all the ones below as well, please.
checkedByDefault: nodeModel.bloomLevel == "light" | |
checkedByDefault: nodeModel.bloomLevel === "light" |
|
||
Rectangle { | ||
property var buttonGroup | ||
property string btnText: qsTr("TODO") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need that TODO?
97bba2c
to
0a7c1ce
Compare
Fixes #2927