Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Community): Add ephemeral notification when request to join was sent #7262

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

borismelnik
Copy link
Contributor

@borismelnik borismelnik commented Sep 7, 2022

Part of: #7072

What does the PR do

Add ephemeral notification when request to join was sent

Affected areas

Community

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Снимок экрана 2022-09-07 в 16 33 36

@borismelnik borismelnik requested review from a team, elina2015, alexandraB99 and stefandunca and removed request for a team September 7, 2022 13:34
@status-im-auto
Copy link
Member

status-im-auto commented Sep 7, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ 0595bd3 #1 2022-09-07 13:39:42 ~5 min linux-cpp 📄log
✔️ 0595bd3 #1 2022-09-07 13:44:08 ~9 min macos 📦dmg
✔️ 0595bd3 #1 2022-09-07 13:46:08 ~11 min linux 📦tgz
✔️ 0595bd3 #1 2022-09-07 14:01:54 ~27 min windows 📦exe
✔️ 5b5365a #2 2022-10-03 10:50:17 ~6 min linux-cpp 📦pkg
✔️ 5b5365a #2 2022-10-03 10:58:04 ~14 min linux 📦tgz
✔️ 5b5365a #2 2022-10-03 11:10:41 ~27 min windows 📦exe
⁉️ 5b5365a #2 2022-10-03 11:30:42 ~13 min e2e 📄log
✔️ 5b5365a #2 2022-10-03 12:11:54 ~1 hr 28 min macos 📦dmg

src/app/modules/main/module.nim Show resolved Hide resolved
@borismelnik
Copy link
Contributor Author

@stefandunca I think the best solution is provide to qml just NotificationType and untranslatable strings and move translatable strings to qml. Then we can use a dictionary by NotificationType. :) But add notifications refactoring to small PR is not good idea cos it can raise new error with notifications.

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please create the issue to "make notifications translatable"; feel free to assign to me

@borismelnik borismelnik force-pushed the feat/issue-7072-request-to-join branch from 0595bd3 to 5b5365a Compare October 3, 2022 10:43
@iurimatias iurimatias merged commit 172cb03 into master Oct 12, 2022
@iurimatias iurimatias deleted the feat/issue-7072-request-to-join branch October 12, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants