feat(Communities): Add ephemerial notification when request to join was accepted #7264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borismelnik
requested review from
a team,
elina2015,
iurimatias and
endulab
and removed request for
a team
Jenkins BuildsClick to see older builds (11)
|
caybro
requested changes
Sep 7, 2022
| @@ -696,6 +696,7 @@ method communityJoined*[T]( | |||
| community.joined): | |||
| singletonInstance.globalEvents.myRequestToJoinCommunityAcccepted("Community Request Accepted", | |||
| fmt "Your request to join community {community.name} is accepted", community.id) | |||
| self.displayEphemeralNotification(fmt "{community.name} membership approved ", "", conf.COMMUNITIESPORTAL_SECTION_ICON, false, EphemeralNotificationType.Success.int, "") | |||
There was a problem hiding this comment.
and same here :) Need to move this to QML
endulab
approved these changes
Sep 13, 2022
caybro
approved these changes
Sep 13, 2022
borismelnik
force-pushed
the
feat/issue-7072-accept-request-notification
branch
from
10b5d1b
to
0c5dc0b
Compare
borismelnik
force-pushed
the
feat/issue-7072-accept-request-notification
branch
from
0c5dc0b
to
bf20af9
Compare
…as accepted Part of: #7072
borismelnik
force-pushed
the
feat/issue-7072-accept-request-notification
branch
from
bf20af9
to
624623c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #7072
What does the PR do
Add ephemerial notification when request to join was accepted
Affected areas
Communities
Screenshot of functionality (including design for comparison)