Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Communities): Add checking access type in Welcome modal #7281

Merged
merged 1 commit into from
Oct 27, 2022
Merged

feat(Communities): Add checking access type in Welcome modal #7281

merged 1 commit into from
Oct 27, 2022

Conversation

borismelnik
Copy link
Contributor

@borismelnik borismelnik commented Sep 8, 2022 •
edited
Loading

Part of: #7072

What does the PR do

Add checking access type in Welcome modal

Affected areas

Communities

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Снимок экрана 2022-09-08 в 21 13 01

Снимок экрана 2022-09-08 в 21 13 12

@borismelnik borismelnik requested review from a team, elina2015, iurimatias and endulab and removed request for a team September 8, 2022 18:16
@status-im-auto
Copy link
Member

status-im-auto commented Sep 8, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (9)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ a38ad3b #1 2022-09-08 18:21:56 ~5 min linux-cpp 📄log
✔️ a38ad3b #1 2022-09-08 18:27:35 ~10 min macos 📦dmg
✔️ a38ad3b #1 2022-09-08 18:27:41 ~10 min linux 📦tgz
✔️ a38ad3b #1 2022-09-08 18:42:54 ~25 min windows 📦exe
✔️ 406ebe1 #2 2022-10-03 10:01:20 ~5 min linux-cpp 📦pkg
⁉️ 406ebe1 #2 2022-10-03 10:07:07 ~10 min e2e 📄log
✔️ 406ebe1 #2 2022-10-03 10:08:46 ~12 min linux 📦tgz
✔️ 406ebe1 #2 2022-10-03 10:19:34 ~23 min windows 📦exe
✔️ 406ebe1 #2 2022-10-03 10:20:39 ~24 min macos 📦dmg
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ca80c1f #3 2022-10-21 11:36:21 ~5 min linux-cpp 📦pkg
✔️ ca80c1f #3 2022-10-21 11:43:50 ~12 min linux 📦tgz
⁉️ ca80c1f #3 2022-10-21 11:45:27 ~11 min e2e 📄log
✔️ ca80c1f #3 2022-10-21 11:45:59 ~14 min macos 📦dmg
✔️ ca80c1f #3 2022-10-21 11:54:28 ~23 min windows 📦exe
✔️ 4a92fc8 #4 2022-10-27 18:03:13 ~4 min linux-cpp 📦pkg
✔️ 4a92fc8 #4 2022-10-27 18:10:43 ~12 min linux 📦tgz
✔️ 4a92fc8 #4 2022-10-27 18:14:38 ~16 min macos 📦dmg
⁉️ 4a92fc8 #4 2022-10-27 18:20:50 ~22 min e2e 📄log
✔️ 4a92fc8 #4 2022-10-27 18:21:04 ~22 min windows 📦exe

faust4exe
faust4exe approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@faust4exe faust4exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iurimatias iurimatias added 0.7.0 and removed 0.7.0 labels Sep 28, 2022
@iurimatias
Copy link
Member

@borismelnik this PR needs a rebase

@borismelnik borismelnik merged commit 6175beb into master Oct 27, 2022
@borismelnik borismelnik deleted the feat/issue-7072-welcome-popup branch October 27, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faust4exe faust4exe faust4exe approved these changes

@osmaczko osmaczko osmaczko approved these changes

@endulab endulab endulab approved these changes

@elina2015 elina2015 Awaiting requested review from elina2015 elina2015 was automatically assigned from status-im/desktop-qa

@iurimatias iurimatias Awaiting requested review from iurimatias iurimatias was automatically assigned from status-im/desktop-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@borismelnik @status-im-auto @iurimatias @faust4exe @osmaczko @endulab