Feat(ActivityCenter): Community membership AC notifications #7771

MishkaRogachev · 2022-10-05T14:54:27Z

Close #7274
Needs status-im/status-go#2886

What does the PR do

Add Activity Center membership notifications

Affected areas

Activity Center

Screenshot of functionality (including design for comparison)

I've checked the design and this PR matches it

status-im-auto · 2022-10-05T15:12:13Z

Jenkins Builds

Click to see older builds (111)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`e0bea83`	#1	2022-10-05 15:12:13	~5 min	`linux-cpp`	📦`pkg`
✔️	`e0bea83`	#1	2022-10-05 15:16:23	~9 min	`macos`	📦`dmg`
✔️	`e0bea83`	#1	2022-10-05 15:18:21	~11 min	`linux`	📦`tgz`
⁉️	`e0bea83`	#1	2022-10-05 15:22:04	~14 min	`e2e`	📄`log`
✔️	`e0bea83`	#1	2022-10-05 15:27:44	~20 min	`windows`	📦`exe`

✔️	`b2e76ab`	#3	2022-10-06 14:11:19	~4 min	`linux-cpp`	📦`pkg`
✔️	`b2e76ab`	#3	2022-10-06 14:15:30	~9 min	`macos`	📦`dmg`
✔️	`b2e76ab`	#3	2022-10-06 14:17:05	~10 min	`linux`	📦`tgz`
⁉️	`b2e76ab`	#2	2022-10-06 14:21:10	~14 min	`e2e`	📄`log`
✔️	`b2e76ab`	#3	2022-10-06 14:27:29	~21 min	`windows`	📦`exe`

✔️	`696cbd2`	#4	2022-10-11 13:27:16	~5 min	`linux-cpp`	📦`pkg`
✔️	`696cbd2`	#4	2022-10-11 13:30:16	~8 min	`macos`	📦`dmg`
✔️	`696cbd2`	#4	2022-10-11 13:34:11	~12 min	`linux`	📦`tgz`
✔️	`696cbd2`	#4	2022-10-11 13:48:36	~26 min	`windows`	📦`exe`
❌	`696cbd2`	#3	2022-10-11 14:10:29	~9 min	`e2e`	📄`log`

✔️	`afdc034`	#5	2022-10-12 10:22:12	~4 min	`linux-cpp`	📦`pkg`
✔️	`afdc034`	#5	2022-10-12 10:30:02	~12 min	`linux`	📦`tgz`
✔️	`afdc034`	#5	2022-10-12 10:30:52	~13 min	`macos`	📦`dmg`
⁉️	`afdc034`	#4	2022-10-12 10:31:58	~14 min	`e2e`	📄`log`

✔️	`94f0840`	#6	2022-10-12 10:35:45	~4 min	`linux-cpp`	📦`pkg`
✔️	`94f0840`	#6	2022-10-12 10:39:26	~8 min	`macos`	📦`dmg`
✔️	`94f0840`	#6	2022-10-12 10:43:10	~12 min	`linux`	📦`tgz`
⁉️	`94f0840`	#5	2022-10-12 10:45:56	~13 min	`e2e`	📄`log`
✔️	`94f0840`	#6	2022-10-12 10:52:50	~21 min	`windows`	📦`exe`

✔️	`135224c`	#7	2022-10-13 15:57:48	~4 min	`linux-cpp`	📦`pkg`
✔️	`135224c`	#7	2022-10-13 16:03:45	~10 min	`macos`	📦`dmg`
✔️	`135224c`	#7	2022-10-13 16:04:55	~11 min	`linux`	📦`tgz`
✔️	`135224c`	#7	2022-10-13 16:14:12	~20 min	`windows`	📦`exe`
❌	`135224c`	#6	2022-10-13 16:19:00	~14 min	`e2e`	📄`log`

✔️	`f7a130d`	#8	2022-10-14 11:52:06	~8 min	`macos`	📦`dmg`

✔️	`fcd2072`	#8	2022-10-14 13:08:47	~4 min	`linux-cpp`	📦`pkg`
✔️	`fcd2072`	#9	2022-10-14 13:13:48	~9 min	`macos`	📦`dmg`
✔️	`fcd2072`	#8	2022-10-14 13:15:12	~11 min	`linux`	📦`tgz`
⁉️	`fcd2072`	#7	2022-10-14 13:16:46	~12 min	`e2e`	📄`log`
✔️	`fcd2072`	#8	2022-10-14 13:26:12	~22 min	`windows`	📦`exe`

✔️	`1520cb8`	#9	2022-10-17 11:22:31	~5 min	`linux-cpp`	📦`pkg`
❌	`1520cb8`	#10	2022-10-17 11:23:23	~6 min	`macos`	📄`log`
❌	`1520cb8`	#8	2022-10-17 11:23:33	~6 min	`e2e`	📄`log`
❌	`1520cb8`	#9	2022-10-17 11:24:35	~7 min	`linux`	📄`log`
❌	`1520cb8`	#9	2022-10-17 11:29:55	~12 min	`windows`	📄`log`

✔️	`fd68ffb`	#10	2022-10-18 16:21:20	~4 min	`linux-cpp`	📦`pkg`
✔️	`fd68ffb`	#10	2022-10-18 16:28:39	~11 min	`linux`	📦`tgz`
✔️	`fd68ffb`	#11	2022-10-18 16:31:31	~14 min	`macos`	📦`dmg`
⁉️	`fd68ffb`	#9	2022-10-18 16:32:17	~15 min	`e2e`	📄`log`
✔️	`fd68ffb`	#10	2022-10-18 16:38:04	~21 min	`windows`	📦`exe`

✔️	`998dc7b`	#11	2022-10-18 19:52:00	~4 min	`linux-cpp`	📦`pkg`
✔️	`998dc7b`	#12	2022-10-18 19:56:29	~9 min	`macos`	📦`dmg`
✔️	`998dc7b`	#11	2022-10-18 19:57:30	~10 min	`linux`	📦`tgz`
⁉️	`998dc7b`	#10	2022-10-18 20:01:07	~13 min	`e2e`	📄`log`
✔️	`998dc7b`	#11	2022-10-18 20:07:43	~20 min	`windows`	📦`exe`

✔️	`a389c6e`	#13	2022-10-19 08:57:55	~4 min	`linux-cpp`	📦`pkg`
✔️	`a389c6e`	#14	2022-10-19 09:03:15	~9 min	`macos`	📦`dmg`
✔️	`a389c6e`	#13	2022-10-19 09:04:37	~10 min	`linux`	📦`tgz`
⁉️	`a389c6e`	#12	2022-10-19 09:21:42	~15 min	`e2e`	📄`log`

⁉️	`bdb84cc`	#11	2022-10-19 09:06:27	~16 min	`e2e`	📄`log`

✔️	`c7498dd`	#14	2022-10-19 13:02:15	~5 min	`linux-cpp`	📦`pkg`
✔️	`c7498dd`	#15	2022-10-19 13:05:50	~9 min	`macos`	📦`dmg`
✔️	`c7498dd`	#14	2022-10-19 13:08:35	~12 min	`linux`	📦`tgz`
⁉️	`c7498dd`	#13	2022-10-19 13:14:58	~18 min	`e2e`	📄`log`

✔️	`8da44e3`	#15	2022-10-20 12:05:18	~7 min	`linux-cpp`	📦`pkg`
✔️	`8da44e3`	#16	2022-10-20 12:07:09	~8 min	`macos`	📦`dmg`
✔️	`8da44e3`	#15	2022-10-20 12:12:02	~13 min	`linux`	📦`tgz`
❌	`8da44e3`	#14	2022-10-20 12:17:33	~19 min	`e2e`	📄`log`

✔️	`3f10e4f`	#16	2022-10-20 12:33:02	~6 min	`linux-cpp`	📦`pkg`
✔️	`3f10e4f`	#17	2022-10-20 12:35:26	~8 min	`macos`	📦`dmg`
✔️	`3f10e4f`	#16	2022-10-20 12:38:38	~12 min	`linux`	📦`tgz`
⁉️	`3f10e4f`	#15	2022-10-20 12:51:04	~14 min	`e2e`	📄`log`

✔️	`f51bdba`	#17	2022-10-20 14:54:33	~5 min	`linux-cpp`	📦`pkg`
✔️	`f51bdba`	#17	2022-10-20 15:01:21	~11 min	`linux`	📦`tgz`
✔️	`f51bdba`	#18	2022-10-20 15:01:49	~12 min	`macos`	📦`dmg`
⁉️	`f51bdba`	#16	2022-10-20 15:16:00	~17 min	`e2e`	📄`log`

✔️	`71244c5`	#18	2022-10-21 12:53:32	~4 min	`linux-cpp`	📦`pkg`
✔️	`71244c5`	#19	2022-10-21 12:58:50	~9 min	`macos`	📦`dmg`
✔️	`71244c5`	#18	2022-10-21 12:59:06	~10 min	`linux`	📦`tgz`
❌	`71244c5`	#17	2022-10-21 13:03:04	~13 min	`e2e`	📄`log`

✔️	`fd29593`	#19	2022-10-21 13:52:26	~4 min	`linux-cpp`	📦`pkg`
✔️	`fd29593`	#20	2022-10-21 13:57:18	~9 min	`macos`	📦`dmg`
✔️	`fd29593`	#19	2022-10-21 13:59:40	~12 min	`linux`	📦`tgz`
⁉️	`fd29593`	#18	2022-10-21 14:01:06	~13 min	`e2e`	📄`log`

✔️	`47cd20f`	#20	2022-10-21 14:49:48	~4 min	`linux-cpp`	📦`pkg`
✔️	`47cd20f`	#20	2022-10-21 14:56:25	~11 min	`linux`	📦`tgz`
✔️	`47cd20f`	#21	2022-10-21 15:01:12	~15 min	`macos`	📦`dmg`
⁉️	`47cd20f`	#19	2022-10-21 15:34:14	~14 min	`e2e`	📄`log`

✔️	`6828392`	#21	2022-10-24 13:57:40	~6 min	`linux-cpp`	📦`pkg`
✔️	`6828392`	#22	2022-10-24 14:00:39	~9 min	`macos`	📦`dmg`
✔️	`6828392`	#21	2022-10-24 14:04:20	~13 min	`linux`	📦`tgz`
⁉️	`6828392`	#20	2022-10-24 14:08:41	~17 min	`e2e`	📄`log`

✔️	`db26abd`	#22	2022-10-25 12:29:28	~4 min	`linux-cpp`	📦`pkg`
✔️	`db26abd`	#23	2022-10-25 12:35:05	~10 min	`macos`	📦`dmg`
✔️	`db26abd`	#22	2022-10-25 12:36:34	~11 min	`linux`	📦`tgz`
❌	`db26abd`	#21	2022-10-25 12:52:02	~15 min	`e2e`	📄`log`

✔️	`26e86c4`	#23	2022-10-25 15:04:09	~6 min	`linux-cpp`	📦`pkg`
✔️	`26e86c4`	#24	2022-10-25 15:11:58	~13 min	`macos`	📦`dmg`
✔️	`26e86c4`	#23	2022-10-25 15:13:06	~15 min	`linux`	📦`tgz`
✔️	`26e86c4`	#23	2022-10-25 15:22:28	~24 min	`windows`	📦`exe`

✔️	`02dd634`	#24	2022-10-25 15:53:05	~5 min	`linux-cpp`	📦`pkg`
✔️	`02dd634`	#25	2022-10-25 15:57:12	~9 min	`macos`	📦`dmg`
✔️	`02dd634`	#24	2022-10-25 16:00:09	~12 min	`linux`	📦`tgz`
❌	`02dd634`	#22	2022-10-25 16:10:08	~15 min	`e2e`	📄`log`

✔️	`7893ca9`	#25	2022-10-25 16:09:19	~4 min	`linux-cpp`	📦`pkg`
✔️	`7893ca9`	#26	2022-10-25 16:13:33	~8 min	`macos`	📦`dmg`
✔️	`7893ca9`	#25	2022-10-25 16:16:21	~11 min	`linux`	📦`tgz`
✔️	`7893ca9`	#25	2022-10-25 16:27:44	~23 min	`windows`	📦`exe`

✔️	`625a67c`	#26	2022-10-25 16:43:08	~5 min	`linux-cpp`	📦`pkg`
✔️	`625a67c`	#27	2022-10-25 16:46:48	~8 min	`macos`	📦`dmg`
✔️	`625a67c`	#26	2022-10-25 16:49:20	~11 min	`linux`	📦`tgz`
❌	`625a67c`	#23	2022-10-25 17:25:45	~14 min	`e2e`	📄`log`

✔️	`6b87be9`	#27	2022-10-25 21:16:09	~4 min	`linux-cpp`	📦`pkg`
✔️	`6b87be9`	#28	2022-10-25 21:20:49	~9 min	`macos`	📦`dmg`
✔️	`6b87be9`	#27	2022-10-25 21:23:00	~11 min	`linux`	📦`tgz`
⁉️	`6b87be9`	#24	2022-10-25 21:31:35	~19 min	`e2e`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`3a54d38`	#28	2022-10-26 13:20:19	~6 min	`linux-cpp`	📦`pkg`
✔️	`3a54d38`	#29	2022-10-26 13:23:36	~9 min	`macos`	📦`dmg`
✔️	`3a54d38`	#28	2022-10-26 13:26:09	~12 min	`linux`	📦`tgz`
✔️	`3a54d38`	#28	2022-10-26 13:35:08	~21 min	`windows`	📦`exe`
⁉️	`3a54d38`	#25	2022-10-26 14:19:45	~19 min	`e2e`	📄`log`

✔️	`e7e6b64`	#29	2022-10-27 13:16:26	~13 min	`linux-cpp`	📦`pkg`
✔️	`e7e6b64`	#29	2022-10-27 13:25:10	~21 min	`windows`	📦`exe`
✔️	`e7e6b64`	#29	2022-10-27 13:25:20	~22 min	`linux`	📦`tgz`
✔️	`e7e6b64`	#30	2022-10-27 13:27:00	~23 min	`macos`	📦`dmg`
⁉️	`e7e6b64`	#26	2022-10-27 14:37:28	~22 min	`e2e`	📄`log`

caybro

Just some minor stuff, otherwise looks good

ui/app/mainui/activitycenter/views/ActivityNotificationCommunityKicked.qml

ui/app/mainui/activitycenter/views/ActivityNotificationCommunityRequest.qml

MishkaRogachev · 2022-10-19T12:57:13Z

@caybro @saledjenic I've re-requested review because of lot fixes were added

caybro

LGTM, just some minor details

ui/app/AppLayouts/Chat/popups/community/MembershipRequestsPopup.qml

ui/app/mainui/activitycenter/panels/MembershipCta.qml

ui/app/mainui/activitycenter/views/ActivityNotificationCommunityInvitation.qml

elina2015

@MishkaRogachev hey, I found some small issues. Could you kindly check?

There is no user name shown in the community request
There is no default picture for a user without a photo in the community request

3. After the admin accepted a community request in Activity Center, the incorrect date appeared:

4. User who has been rejected for joining a community will see a 'pending' status in AC and the wrong date:

5. The user who was accepted for joining a community, will see a 'pending' status in AC 6. If the user has a long contact request and a community request (user), then it doesn't look good:

7. User A was accepted for joining a community and kicked from this community by an admin. User A will see 'pending' in AC for the community from which he was kicked off. 8. There is no sign on the AC icon (bell icon) about new notifications (community requests, accepting, rejection, kicking off)

elina2015 · 2022-10-20T02:16:12Z

For QA: Figma: https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=1854%3A298745

osmaczko

Overall looks ok, with some minor things.

src/app/modules/main/activity_center/item.nim

src/app_service/service/activity_center/dto/notification.nim

ui/app/mainui/activitycenter/controls/Badge.qml

ui/app/mainui/activitycenter/panels/MembershipCta.qml

ui/app/mainui/activitycenter/views/ActivityNotificationBase.qml

MishkaRogachev · 2022-10-25T16:46:42Z

@elina2015

Fixed

Hmm. I've checked several times. It should work. But if you already opened this community link do nothing.
There is separated issue for that: Community request AC notification status #7980 . Temporary i can remove those type of notifications

MishkaRogachev · 2022-10-25T21:11:56Z

@elina2015

UPD: p.3 fixed:

elina2015 · 2022-10-26T05:08:23Z

@MishkaRogachev hey, the button for inviting members just doesn't work. So, I cannot test the pr. Could you kindly rebase the build?

MishkaRogachev · 2022-10-26T11:22:53Z

Waiting #8048

MishkaRogachev · 2022-10-26T13:14:56Z

@elina2015 Rebased. If there will be some UI-related issues, i think it would be better to open new ticket for that

Close #7277

Close #7952

…cations

elina2015

Tested and approved

MishkaRogachev added the needs-status-go label Oct 5, 2022

MishkaRogachev force-pushed the feat/issue-7274-community-notifications branch 5 times, most recently from afdc034 to 94f0840 Compare October 12, 2022 10:30

MishkaRogachev force-pushed the feat/issue-7274-community-notifications branch 2 times, most recently from f7a130d to fcd2072 Compare October 14, 2022 13:03

MishkaRogachev requested review from osmaczko and saledjenic October 14, 2022 14:15

MishkaRogachev marked this pull request as ready for review October 14, 2022 14:15

saledjenic approved these changes Oct 14, 2022

View reviewed changes

MishkaRogachev force-pushed the feat/issue-7274-community-notifications branch 2 times, most recently from 1520cb8 to fd68ffb Compare October 18, 2022 16:16

caybro requested changes Oct 18, 2022

View reviewed changes

MishkaRogachev force-pushed the feat/issue-7274-community-notifications branch 2 times, most recently from bdb84cc to a389c6e Compare October 19, 2022 08:53

caybro approved these changes Oct 19, 2022

View reviewed changes

MishkaRogachev requested review from caybro and saledjenic October 19, 2022 12:56

MishkaRogachev requested a review from jrainville October 19, 2022 12:57

caybro requested changes Oct 19, 2022

View reviewed changes

elina2015 self-requested a review October 19, 2022 15:11

elina2015 suggested changes Oct 20, 2022

View reviewed changes

elina2015 added the tested-issues label Oct 20, 2022

osmaczko requested changes Oct 20, 2022

View reviewed changes

MishkaRogachev force-pushed the feat/issue-7274-community-notifications branch from 8da44e3 to 3f10e4f Compare October 20, 2022 12:26

MishkaRogachev force-pushed the feat/issue-7274-community-notifications branch 3 times, most recently from 7893ca9 to 625a67c Compare October 25, 2022 16:37

MishkaRogachev force-pushed the feat/issue-7274-community-notifications branch from 625a67c to 6b87be9 Compare October 25, 2022 21:11

elina2015 self-requested a review October 26, 2022 03:07

elina2015 added testing and removed tested-issues labels Oct 26, 2022

anastasiyaig linked an issue Oct 26, 2022 that may be closed by this pull request

Community Requests should be displayed in the activity center #7365

Closed

MishkaRogachev force-pushed the feat/issue-7274-community-notifications branch from 6b87be9 to 3a54d38 Compare October 26, 2022 13:13

MishkaRogachev mentioned this pull request Oct 27, 2022

Refactor AC Store & fix AC notifications count #8055

Merged

MishkaRogachev added 6 commits October 27, 2022 17:01

feat(ActivityCenter): Community membership notifications

73db3c7

Close #7277

feat(ActivityCenter): Community membership status handling

45ef6f2

feat(ActivityCenter): Kicked from community notification

b98d644

feat(ActivityCenter): Common date-time lable

b530626

Close #7952

feat(ActivityCenter): Fix handling membership requests from AC

4e092d3

feat(ActivityCenter): Review fixed for community membership AС notifi…

e7e6b64

…cations

MishkaRogachev force-pushed the feat/issue-7274-community-notifications branch from 3a54d38 to e7e6b64 Compare October 27, 2022 13:03

elina2015 approved these changes Oct 27, 2022

View reviewed changes

elina2015 added tested and removed testing labels Oct 27, 2022

MishkaRogachev merged commit 851dd3b into master Oct 27, 2022

MishkaRogachev deleted the feat/issue-7274-community-notifications branch October 27, 2022 21:25

elina2015 mentioned this pull request Oct 28, 2022

Activity Center: the community is shown higher than the text #8079

Closed

MishkaRogachev mentioned this pull request Oct 28, 2022

Community request AC notification status #7980

Closed

MishkaRogachev mentioned this pull request Nov 18, 2022

Community Request should be present in activity center #8313

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat(ActivityCenter): Community membership AC notifications #7771

Feat(ActivityCenter): Community membership AC notifications #7771

MishkaRogachev commented Oct 5, 2022 •

edited

Loading

status-im-auto commented Oct 5, 2022 •

edited

Loading

caybro left a comment

MishkaRogachev commented Oct 19, 2022

caybro left a comment

elina2015 left a comment

elina2015 commented Oct 20, 2022

osmaczko left a comment

MishkaRogachev commented Oct 25, 2022 •

edited

Loading

MishkaRogachev commented Oct 25, 2022

elina2015 commented Oct 26, 2022

MishkaRogachev commented Oct 26, 2022

MishkaRogachev commented Oct 26, 2022

elina2015 left a comment

Feat(ActivityCenter): Community membership AC notifications #7771

Feat(ActivityCenter): Community membership AC notifications #7771

Conversation

MishkaRogachev commented Oct 5, 2022 • edited Loading

What does the PR do

Affected areas

Screenshot of functionality (including design for comparison)

status-im-auto commented Oct 5, 2022 • edited Loading

Jenkins Builds

caybro left a comment

Choose a reason for hiding this comment

MishkaRogachev commented Oct 19, 2022

caybro left a comment

Choose a reason for hiding this comment

elina2015 left a comment

Choose a reason for hiding this comment

elina2015 commented Oct 20, 2022

osmaczko left a comment

Choose a reason for hiding this comment

MishkaRogachev commented Oct 25, 2022 • edited Loading

MishkaRogachev commented Oct 25, 2022

elina2015 commented Oct 26, 2022

MishkaRogachev commented Oct 26, 2022

MishkaRogachev commented Oct 26, 2022

elina2015 left a comment

Choose a reason for hiding this comment

MishkaRogachev commented Oct 5, 2022 •

edited

Loading

status-im-auto commented Oct 5, 2022 •

edited

Loading

MishkaRogachev commented Oct 25, 2022 •

edited

Loading