feat(communities): Process declined requests #8056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borismelnik
requested review from
0x-r4bbit,
MishkaRogachev,
jrainville and
osmaczko
jrainville
reviewed
Oct 26, 2022
| self.myCommunityRequests.add(membershipRequest) | ||
| self.events.emit(SIGNAL_COMMUNITY_MY_REQUEST_REJECTED, CommunityRequestArgs(communityRequest: membershipRequest)) | ||
| singletonInstance.globalEvents.myRequestToJoinCommunityRejected("Community Request Rejected", | ||
| fmt "Your request to join community is rejected", membershipRequest.communityId) |
There was a problem hiding this comment.
nit: can you add an indent on those two lines to show they are the same as the event
| self.myCommunityRequests.add(communityRequest) | ||
| self.events.emit(SIGNAL_COMMUNITY_MY_REQUEST_ADDED, CommunityRequestArgs(communityRequest: communityRequest)) | ||
| except Exception as e: | ||
| error "Error fetching my community requests", msg = e.msg |
There was a problem hiding this comment.
Suggested change
| error "Error fetching my community requests", msg = e.msg | |
| error "Error fetching my declined community requests", msg = e.msg |
Jenkins BuildsClick to see older builds (15)
|
borismelnik
force-pushed
the
feat/process-decline-requests
branch
from
990db05
to
27cbeb1
Compare
jrainville
requested review from
a team and
glitchminer
and removed request for
a team
borismelnik
force-pushed
the
feat/process-decline-requests
branch
from
27cbeb1
to
87c5380
Compare
jrainville
approved these changes
Oct 27, 2022
borismelnik
force-pushed
the
feat/process-decline-requests
branch
from
87c5380
to
3764681
Compare
borismelnik
force-pushed
the
feat/process-decline-requests
branch
from
3764681
to
f7768c7
Compare
|
@jrainville @iurimatias do we want this feature to be landed or not? is it still in scope of 0.9.0? |
|
@jrainville please revisit this, i am not sure we still want it, also the PR is really old. I removed the 0.9.0 milestone for the ticket |
|
Closing as we do not want this in the end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #7072
fixes #8316
StatusGo PR here
What does the PR do
Process declined community requests
Affected areas
Membership requests
Screenshot of functionality (including design for comparison)
decline_request.mov