-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e/tst_communityPermissions): New tests case tst_communityPermissions
#9922
Conversation
Jenkins BuildsClick to see older builds (142)
|
223dec9
to
407115f
Compare
407115f
to
fb54113
Compare
0a824d6
to
b1b8e8b
Compare
tst_communityPermissions
tst_communityPermissions
aadaaa5
to
fc10834
Compare
fc10834
to
1f31008
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just had a question about testing strings
Testing it locally it is sometimes stuck in one pages in the background steps (create community). It seems some inestability issue depending on the machine used. Maybe @StateOf-Vlado you could take a look and help with that as you've been doing with the stability tasks! Here a video that displayes where it is blocked: Screen.Recording.2023-04-24.at.10.17.18.mov |
1f31008
to
35eb142
Compare
7f64b12
to
1016443
Compare
test/ui-test/testSuites/suite_communities/tst_communityPermissions/test.feature
Show resolved
Hide resolved
2985b39
to
2e57673
Compare
test/ui-test/testSuites/suite_communities/shared/scripts/community_names.py
Outdated
Show resolved
Hide resolved
communityPermissions_welcome_settings_subtitle = {"container": statusDesktop_mainWindow, "objectName": "welcomeSettingsSubtitle", "type": "StatusBaseText", "visible": True} | ||
communityPermissions_welcome_settings_checkList_element1 = {"container": statusDesktop_mainWindow, "objectName": "checkListText_0", "type": "StatusBaseText", "visible": True} | ||
communityPermissions_welcome_settings_checkList_element2 = {"container": statusDesktop_mainWindow, "objectName": "checkListText_1", "type": "StatusBaseText", "visible": True} | ||
communityPermissions_welcome_settings_checkList_element3 = {"container": statusDesktop_mainWindow, "objectName": "checkListText_2", "type": "StatusBaseText", "visible": True} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think, can we use more of the 3 items in the future? If yes, we will need to add:
communityPermissions_welcome_settings_checkList_element3 = {"container": statusDesktop_mainWindow, "objectName": "checkListText_2", "type": "StatusBaseText", "visible": True}
So, maybe it is better to have one template for the list item:
communityPermissions_welcome_settings_checkList_element = {"container": statusDesktop_mainWindow, "text": "", "type": "StatusBaseText", "visible": True}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this screen wont change i hope (no more options expected to be added). I will leave it as is for now, but we can improve any time
# Check if the lists have the same elements in the same order | ||
for i in range(len(checklist)): | ||
if checklist[i] != list[i]: | ||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these 13 lines can be replaced on:
for permission in list:
communityPermissions_welcome_settings_checkList_element['text'] = permission
squish.waitForObject(communityPermissions_welcome_settings_checkList_element) - or replace to any method from drivers folder that verify object
2e57673
to
2fe6bf7
Compare
Closes #9007
What does the PR do
Affected areas
e2e/tst_communityPermissions