Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending smart contracts #105

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Feb 5, 2017

Note:

  • the issue was with double encoding of contract code in jailed context
  • the issue has been fixed, contracts can be created w/o problems now
  • we need to see if bchat.org works, after this fix is applied

@farazdagi farazdagi self-assigned this Feb 5, 2017
@farazdagi farazdagi added this to the 0.9.3 milestone Feb 5, 2017
@0xc1c4da
Copy link
Contributor

0xc1c4da commented Feb 6, 2017

double encoding of contract code in jailed context

but doesn't web based dapps work outside of the jail context?

@rasom
Copy link
Collaborator

rasom commented Feb 6, 2017

@jarradh, yes it does, it works outside

@0xc1c4da
Copy link
Contributor

0xc1c4da commented Feb 6, 2017

wait, so why did bchat fail then?

@farazdagi
Copy link
Contributor Author

  • Well, I have added tests both using our node directly, and then using jailed context. The issue was in jail context only.
  • If bchat still doesn't work - then we need to find out more what causes it. It is hardly contract creation.

@0xc1c4da
Copy link
Contributor

0xc1c4da commented Feb 6, 2017

sorry, IIRC in the case of bchat i think it was a contract web3 javascript object sending a transaction, not a contract creation. I could be wrong

@farazdagi
Copy link
Contributor Author

well, don't they us jailed web3 then?

@0xc1c4da
Copy link
Contributor

0xc1c4da commented Feb 6, 2017

it sounds like my understanding is outdated, i had assumed - because the webview web3 object connected directly via httpprovider (to localhost:8545) it wouldn't be jailed, but maybe this changed when creating the StatusProvider which now goes through a webview proxy object

@rasom rasom merged commit a7e0f05 into status-im:develop Feb 6, 2017
@0xc1c4da 0xc1c4da removed the ready label Feb 6, 2017
@farazdagi farazdagi deleted the feature/smart-contracts branch February 6, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract sendTransaction & possibly contract deploys fail?
3 participants