Remove submodules #1835
Merged
Remove submodules #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (30)
|
adambabik
force-pushed
the
remove-submodules
branch
4 times, most recently
from
0718ac2
to
29f6b86
Compare
adambabik
force-pushed
the
remove-submodules
branch
from
29f6b86
to
6068ea1
Compare
adambabik
commented
Feb 10, 2020
| @@ -58,7 +58,7 @@ type Contact struct { | |||
| SystemTags []string `json:"systemTags"` | |||
|
|
|||
| DeviceInfo []ContactDeviceInfo `json:"deviceInfo"` | |||
| TributeToTalk string `json:"tributeToTalk,omitEmpty"` | |||
| TributeToTalk string `json:"tributeToTalk,omitempty"` | |||
There was a problem hiding this comment.
Potentially breaking change but tests pass. cc @cammellos
There was a problem hiding this comment.
This is ok, I believe, tributeToTalk is not used
| @@ -93,7 +93,7 @@ type Message struct { | |||
|
|
|||
| // Replace indicates that this is a replacement of a message | |||
| // that has been updated | |||
| Replace string `json:"replace,omitEmpty"` | |||
| Replace string `json:"replace,omitempty"` | |||
There was a problem hiding this comment.
Potentially breaking change cc @cammellos
| LocalChatID string `json:"localChatId"` | ||
| Clock uint64 `json:"clock"` | ||
| Replace string `json:"replace,omitEmpty"` | ||
| Replace string `json:"replace"` |
There was a problem hiding this comment.
A unit test was failing so I removed it. omitEmpty did not work, it is omitempty. cc @cammellos
There was a problem hiding this comment.
good to know, I obviously sprinkled the codebase with the wrong version :)
| Messages []*Message `json:"messages,omitEmpty"` | ||
| Contacts []*Contact `json:"contacts,omitEmpty"` | ||
| Installations []*multidevice.Installation `json:"installations,omitEmpty"` | ||
| Chats []*Chat `json:"chats,omitempty"` |
There was a problem hiding this comment.
Potentially breaking change cc @cammellos.
cammellos
approved these changes
Feb 10, 2020
| Messages []*Message `json:"messages,omitEmpty"` | ||
| Contacts []*Contact `json:"contacts,omitEmpty"` | ||
| Installations []*multidevice.Installation `json:"installations,omitEmpty"` | ||
| Chats []*Chat `json:"chats,omitempty"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the current stage, submodules, especially for
protocolandeth-nodepackages, bring more troubles than advantages.The biggest problem is that we use
replaces in the maingo.modwhich makes status-go act differently depending whether it is used as a main program vs a library in other projects.