Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/dependabot protocol #1980

Merged
merged 3 commits into from May 18, 2020
Merged

Patch/dependabot protocol #1980

merged 3 commits into from May 18, 2020

Conversation

Samyoul
Copy link
Member

@Samyoul Samyoul commented May 18, 2020

Why make the change?

There is only one vendor for this repo, the protocol vendoring was removed, but the dependabot config wasn't updated.

What's changed?

Remove the following from the @dependabot config

  - package_manager: "go:modules"
    directory: "/protocol"
    update_schedule: "weekly"
    default_assignees:
    - "cammellos"
    - "Samyoul"
    allowed_updates:
      - match:
          update_type: "security"

@status-github-bot
Copy link

status-github-bot bot commented May 18, 2020 •
edited by Samyoul

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@Samyoul Samyoul requested review from cammellos and jakubgs May 18, 2020 20:20
@status-im-auto
Copy link
Member

status-im-auto commented May 18, 2020 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 696001d #1 2020-05-18 20:21:06 ~51 sec linux 📦zip
✔️ 696001d #1 2020-05-18 20:25:39 ~5 min ios 📦zip
✔️ 696001d #1 2020-05-18 20:26:43 ~6 min android 📦aar

jakubgs
jakubgs approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn, totally missed that.

@Samyoul Samyoul merged commit 2d13ccf into develop May 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the patch/dependabot-protocol branch May 18, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

@cammellos cammellos Awaiting requested review from cammellos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Samyoul @status-im-auto @jakubgs