apply DNS override hack for iOS as well #5093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
jo-mut
approved these changes
Apr 25, 2024
|
funny enough the DNS override is needed for Android and not for iOS 😿 On Android the community does not resolve but it does on iOS. Don't know why this discrimination |
siddarthkay
force-pushed
the
select-default-dns-network
branch
2 times, most recently
from
33897ed
to
497e9f1
Compare
siddarthkay
changed the title
siddarthkay
force-pushed
the
select-default-dns-network
branch
from
497e9f1
to
1a431ea
Compare
We need to apply the DNS override hack for iOS as well. This PR -> status-im/status-mobile#19798 in status-mobile fixes the DNS resolution issue for iOS ARM Simulators and for Android x86 Emulators. But we still need this change to ensure storenodes are found on real iOS devices and on Android arm Emulators.
siddarthkay
force-pushed
the
select-default-dns-network
branch
from
1a431ea
to
9bb2be0
Compare
siddarthkay
added a commit
to status-im/status-mobile
that referenced
this pull request
Apr 26, 2024
fixes #19736 Corresponding go PR status-im/status-go#5093 This commit fixes DNS resolution inside status-go by forcing pure go resolver at build time. Reference -> https://pkg.go.dev/net#hdr-Name_Resolution Store nodes must be available on Android & iOS app. - Android - iOS status: ready
siddarthkay
added a commit
to status-im/status-mobile
that referenced
this pull request
Apr 26, 2024
status-im/status-go@90b18d4...b124e2b fixes #19736 Corresponding go PR status-im/status-go#5093 This commit fixes DNS resolution inside status-go by forcing pure go resolver at build time. Reference -> https://pkg.go.dev/net#hdr-Name_Resolution Store nodes must be available on Android & iOS app. - Android - iOS status: ready
siddarthkay
added a commit
to status-im/status-mobile
that referenced
this pull request
Apr 26, 2024
status-im/status-go@90b18d4...b124e2b fixes #19736 Corresponding go PR status-im/status-go#5093 This commit fixes DNS resolution inside status-go by forcing pure go resolver at build time. Reference -> https://pkg.go.dev/net#hdr-Name_Resolution Store nodes must be available on Android & iOS app. - Android - iOS status: ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to apply the DNS override hack for iOS as well.
This PR -> status-im/status-mobile#19798 in status-mobile fixes the DNS resolution issue for
iOS ARM Simulators and for Android x86 Emulators.
But we still need this change to ensure storenodes are found on real iOS devices and on Android arm Emulators.