fix dns resolution issue for iOS #19798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
force-pushed
the
fix-dns-resolution-issue
branch
from
ed080fe
to
b1c935f
Compare
Jenkins BuildsClick to see older builds (9)
|
jo-mut
approved these changes
Apr 25, 2024
|
Hi @siddarthkay. Thanks for the PR. Unfortunately now storenodes not found neither on IOS nor on Android. Android_store_nodes.zip Just a friendly reminder: please, smoke check your PRs before requesting manual QA. Thank you! |
90% of end-end tests have passedFailed tests (3)Click to expandClass TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (47)Click to expandClass TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
@siddarthkay BTW, I have no idea why e2e have passed. Looks like storenodes are found successfully on e2e emulators but on real devices it fails to connect. |
|
@pavloburykh : When raising the PR the solution worked on iOS Simulator and the solution wasn't platform specific hence I assumed this solution worked everywhere. 
|
siddarthkay
force-pushed
the
fix-dns-resolution-issue
branch
2 times, most recently
from
d3a331a
to
ff56660
Compare
|
@pavloburykh : pls check, I tested on real device this time.
|
90% of end-end tests have passedFailed tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (47)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
|
siddarthkay
force-pushed
the
fix-dns-resolution-issue
branch
from
ff56660
to
2c68701
Compare
|
@siddarthkay thanks for the fix! Works fine for me. During testing I have noticed some messages delivery issues in communities. But I could not verify if this is related to this PR or not. Let's merge it and in case we face any problems in future we will rise a separate issue. |
siddarthkay
added a commit
to status-im/status-go
that referenced
this pull request
Apr 26, 2024
We need to apply the DNS override hack for iOS as well. This PR -> status-im/status-mobile#19798 in status-mobile fixes the DNS resolution issue for iOS ARM Simulators and for Android x86 Emulators. But we still need this change to ensure storenodes are found on real iOS devices and on Android arm Emulators.
siddarthkay
changed the title
siddarthkay
added a commit
to status-im/status-go
that referenced
this pull request
Apr 26, 2024
We need to apply the DNS override hack for iOS as well. This PR -> status-im/status-mobile#19798 in status-mobile fixes the DNS resolution issue for iOS ARM Simulators and for Android x86 Emulators. But we still need this change to ensure storenodes are found on real iOS devices and on Android arm Emulators.
siddarthkay
force-pushed
the
fix-dns-resolution-issue
branch
from
2c68701
to
f3ba1bf
Compare
status-im/status-go@90b18d4...b124e2b fixes #19736 Corresponding go PR status-im/status-go#5093 This commit fixes DNS resolution inside status-go by forcing pure go resolver at build time. Reference -> https://pkg.go.dev/net#hdr-Name_Resolution Store nodes must be available on Android & iOS app. - Android - iOS status: ready
siddarthkay
force-pushed
the
fix-dns-resolution-issue
branch
from
f3ba1bf
to
115feb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19736
Corresponding go PR status-im/status-go#5093
Summary
This PR fixes DNS resolution inside status-go by forcing pure go resolver at build time.
Reference -> https://pkg.go.dev/net#hdr-Name_Resolution
Testing notes
Store nodes must be available on Android & iOS app.
Platforms
status: ready