Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request compressed keys #10325

Closed
hesterbruikman opened this issue Apr 14, 2020 · 5 comments
Closed

Request compressed keys #10325

hesterbruikman opened this issue Apr 14, 2020 · 5 comments

Comments

@hesterbruikman
Copy link
Contributor

hesterbruikman commented Apr 14, 2020

This issue is paired with and should follow implementation of status-im/status-go#1937

Problem

Chat key is currently shown (as used) as the public key in full. This is unnecessarily daunting. Compressing the public key used for chat can make it less daunting, more space efficient in the UI as well as reducing file size and visual complexity of the QR code.

Implementation

Status-go will include two new functions:

  • decompress public key - anywhere the full public key is required
  • request compressed key - places where the key is shown or shared in the UI

02 and 03 will be used for compressed keys, 04 will be maintained for decompressed keys

status-react should always receive the decompressed key (no changes to current implementation) unless the compressed key is requested. Instances where the compressed key should be requested include:

  • Onboarding > Choose a chat name
  • Profile > Header
  • Profile > Share icon > QR code popover
  • Invite friends url from Invite friends button and + -button > Invite friends
  • Other user Profile details
  • Profile details > Share icon > QR code popover

Future Steps

  • Add Status logo/styling to QR code (design tbd)
  • Add save to gallery action for QR code
@hesterbruikman
Copy link
Contributor Author

cc @andremedeiros @gravityblast

@Samyoul
Copy link
Member

Samyoul commented Jun 23, 2020

The status-go functionality for this is merged status-im/status-go#1990.

Awaiting on specs to be cleared for merge

@hesterbruikman
Copy link
Contributor Author

Thanks for making this happen!

@churik
Copy link
Member

churik commented May 7, 2021

@hesterbruikman is this still relevant?

@churik
Copy link
Member

churik commented Dec 5, 2022

Obsolete and will be re-considered in the redesigned app.

@churik churik closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants