Weekly Digest (12 April, 2020 - 19 April, 2020)

[weekly-digest]

Here's the Weekly Digest for status-im/status-react:

---

ISSUES

Last week 45 issues were created.
Of these, 19 issues have been closed and 26 issues are still open.

OPEN ISSUES

💚 #10363 Feature Request: Mobile Push Notifications, by JonahAragon
💚 #10362 Can't load any messages after rejoining a public group, by KyleNie
💚 #10361 Update translations, by jinhojang6
💚 #10360 feat: add i18n strings for the missing strings, by jrainville
💚 #10359 Add help text to Account settings > Type, by hesterbruikman
💚 #10357 Dont send extra contacts, by cammellos
💚 #10356 Upgrade e2e, by churik
💚 #10354 Refactor delete account algorithm to properly remove deleted account, by PascalPrecht
💚 #10353 Feature Request: Addition of Unstoppable Domains resolution into the application, by corpetty
💚 #10352 DARK MODE for status-im on iOS and andriod, by epicodertime
💚 #10349 fix: display value decimals instead of using exp notation, by richard-ramos
💚 #10348 Scroll position in chat is not maintaining (chat is auto-scrolling when new message is coming), by churik
💚 #10346 Build front-end user referral flow , by rachelhamlin
💚 #10345 Token ENS name is not resolved in EIP-681 links, by churik
💚 #10344 [WIP] Upgrade status-go, by cammellos
💚 #10342 fix: fix mailserver popup showing after canceling it, by jrainville
💚 #10340 upgrade Nix packages, and a lot of dependencies, by jakubgs
💚 #10338 WIP Add component library skeleton, by Ferossgp
💚 #10336 Add sticker submissions to market place, by rachelhamlin
💚 #10335 Please update Bouncy Castle, by Neustradamus
💚 #10334 Send Anonymous Messages in public chats, by errorists
💚 #10333 Show redeem text for Keycard redeem txs, by siphiuel
💚 #10330 Use a single in-progress? flag for signing, by siphiuel
💚 #10327 fix: added navigationBarColor to style, by richard-ramos
💚 #10326 Can't add same account in wallet as the removed 'Watched only account', by Serhy
💚 #10325 Request compressed keys, by hesterbruikman

CLOSED ISSUES

❤️ #10358 [#10277] [keycard] Fix tx signing for derived accounts, by rasom
❤️ #10355 [WIP] Tests/upgrade, by churik
❤️ #10351 fix: show message when loading new transactions instead of no tx msg, by jrainville
❤️ #10350 upgrade Xcode to 11.4.1, by jakubgs
❤️ #10347 [#10203] Endless spinner when sending two TX in a batch in Dapp, by flexsurfer
❤️ #10343 fix #8717 change ens welcome screen, by yenda
❤️ #10341 upgrade to Xcode 11.4, by jakubgs
❤️ #10339 fix Gradle permission errors during build, by jakubgs
❤️ #10337 Scanning EIP links e2e, by churik
❤️ #10332 fix: strip leading and trailing whitespace from QR Code data, by michaelsbradleyjr
❤️ #10331 fix autoCapitalize warning, by yenda
❤️ #10329 fix android build on MacOS, by jakubgs
❤️ #10328 Show correct error message when signing typed data, by PascalPrecht
❤️ #10324 update help messages in Makefile targets, by jakubgs
❤️ #10323 Logging in networks, by Serhy
❤️ #10322 Update Russian, Korean, and Chinese translation, by jinhojang6
❤️ #10321 [#10272] Hide key-uid from keycard login screen, by rasom
❤️ #10320 Update en.json, by hesterbruikman
❤️ #10319 Copy change 'Hide previews' > 'Block screenshots', by hesterbruikman

LIKED ISSUE

👍 #10363 Feature Request: Mobile Push Notifications, by JonahAragon
It received 👍 x2, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

🔈 #10343 fix #8717 change ens welcome screen, by yenda
It received 10 comments.

---

PULL REQUESTS

Last week, 45 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 15 pull requests were updated.
💛 #10360 feat: add i18n strings for the missing strings, by jrainville
💛 #10357 Dont send extra contacts, by cammellos
💛 #10356 Upgrade e2e, by churik
💛 #10354 Refactor delete account algorithm to properly remove deleted account, by PascalPrecht
💛 #10349 fix: display value decimals instead of using exp notation, by richard-ramos
💛 #10344 [WIP] Upgrade status-go, by cammellos
💛 #10342 fix: fix mailserver popup showing after canceling it, by jrainville
💛 #10340 upgrade Nix packages, and a lot of dependencies, by jakubgs
💛 #10338 WIP Add component library skeleton, by Ferossgp
💛 #10333 Show redeem text for Keycard redeem txs, by siphiuel
💛 #10330 Use a single in-progress? flag for signing, by siphiuel
💛 #10327 fix: added navigationBarColor to style, by richard-ramos
💛 #10294 Notifications, by yenda
💛 #10217 Shadow cljs, by yenda
💛 #10169 WIP Starter pack, by Ferossgp

MERGED PULL REQUEST

Last week, 30 pull requests were merged.
💜 #10358 [#10277] [keycard] Fix tx signing for derived accounts, by rasom
💜 #10351 fix: show message when loading new transactions instead of no tx msg, by jrainville
💜 #10350 upgrade Xcode to 11.4.1, by jakubgs
💜 #10347 [#10203] Endless spinner when sending two TX in a batch in Dapp, by flexsurfer
💜 #10343 fix #8717 change ens welcome screen, by yenda
💜 #10341 upgrade to Xcode 11.4, by jakubgs
💜 #10339 fix Gradle permission errors during build, by jakubgs
💜 #10337 Scanning EIP links e2e, by churik
💜 #10332 fix: strip leading and trailing whitespace from QR Code data, by michaelsbradleyjr
💜 #10331 fix autoCapitalize warning, by yenda
💜 #10329 fix android build on MacOS, by jakubgs
💜 #10328 Show correct error message when signing typed data, by PascalPrecht
💜 #10324 update help messages in Makefile targets, by jakubgs
💜 #10323 Logging in networks, by Serhy
💜 #10322 Update Russian, Korean, and Chinese translation, by jinhojang6
💜 #10321 [#10272] Hide key-uid from keycard login screen, by rasom
💜 #10320 Update en.json, by hesterbruikman
💜 #10317 signals processing performance improvements [#10287], by flexsurfer
💜 #10313 Increment retry count when ENS fails to verify, by cammellos
💜 #10311 Add wallet header animation, by Ferossgp
💜 #10310 Use ms instead of seconds, by cammellos
💜 #10308 fix #10058 wrong domain name shown when connecting .eth, by yenda
💜 #10307 fix #10039, by yenda
💜 #10304 Get replies directly from status-go, by cammellos
💜 #10300 Minor copy changes wallet, by hesterbruikman
💜 #10298 Add profile screen in profile stack, by Ferossgp
💜 #10280 qr testing mode, fixed qr pure address and EIP681 issues, by flexsurfer
💜 #10251 [keycard] Faster multiacc creation and login, by rasom
💜 #10207 fix #10052 make finding the public key easier in profile, by yenda
💜 #9390 Add web3.keycard.signTypedData, by siphiuel

---

COMMITS

Last week there were 31 commits.
🛠️ signals processing performance improvements [#10287] Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by flexsurfer
🛠️ [#10277] [keycard] Fix tx signing for derived accounts by rasom
🛠️ fix: show message when loading new transactions instead of no tx msg Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by jrainville
🛠️ [#10203] Endless spinner when sending two TX in a batch in Dapp Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by flexsurfer
🛠️ fix #8717 change ens welcome screen english only needs work for translations Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by yenda
🛠️ upgrade Xcode to 11.4.1 Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ Get replies directly from status-go Fixes: #10297 Fixes: #10274 Before if a reply was missing (for example if it the message replied to arrived after the reply) status-react would subscribe to it dynamically and use that. This caused some flickering issues when offloading the messages from the database, as the message being replied to would be offloaded and later loaded back again, triggering scroll and ending up in a loop. This commit changes the behavior so that status-go always adds the reply to the message. In case the message being replied to arrives after the reply, this will be included in the message update, and status-react will replace it in the local storage. Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by cammellos
🛠️ fix #10052 make finding the public key easier in profile Signed-off-by: yenda eric@status.im by yenda
🛠️ upgrade to Xcode 11.4 Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ fix: strip leading and trailing whitespace from QR Code data All leading and trailing whitespace is now removed from strings derived from QR codes, both in the case of get-qr-code-data (real camera) and qr-test-view (mock camera). Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by michaelsbradleyjr
🛠️ [keycard] Faster multiacc creation and login by rasom
🛠️ fix Gradle permission errors during build Specifically: org.gradle.internal.service.ServiceCreationException: Could not create service of type ScriptPluginFactory using BuildScopeServices.createScriptPluginFactory(). Caused by: org.gradle.api.UncheckedIOException: Failed to create parent directory '/build/project/android/.gradle/5.6.4' when creating directory '/build/project/android/.gradle/5.6.4/fileHashes' Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ fix #10039 - wasn't able to reproduce the issue as it seems that all inputs are already properly turned to lower case - added :auto-capitalize :none property to the input field though to ensure the keyboard doesn't force the user to start with an uppercase later Signed-off-by: yenda eric@status.im by yenda
🛠️ fix autoCapitalize warning Signed-off-by: yenda eric@status.im by yenda
🛠️ Add animation to wallet header transition Add reanimated lib Wallet header animation Animate android elevation Move constants into styles Ensure line width Signed-off-by: Gheorghe Pinzaru feross95@gmail.com by Ferossgp
🛠️ fix nightly e2e + new scan EIP qr e2e Signed-off-by: Churikova Tetiana churikova.tm@gmail.com by churik
🛠️ fix #10058 wrong domain name shown when connecting .eth add a check on the function that adds the stateofus domain to usernames. if the username already contains a domain, don't concat stateofus domain to it Signed-off-by: yenda eric@status.im by yenda
🛠️ Add web3.keycard.signTypedData Signed-off-by: Vitaliy Vlasov siphiuel@gmail.com by siphiuel
🛠️ fix Android build on MacOS due to lack of OS var changes: - Drop use of /dev/stderr, doesn't work on MacOS - Use uname -s instead of $OS which was removed - Remove leading whitespace that fucks with Nix - Check if /etc/os-release exists before reading it Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ show proper error if nkd-build is missing Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ Show correct error message when signing typed data Prior to this commit sign-message-completed effect would always use the wrong-password label for error handling. We now ensure that wrong-password is only used in case the error in question has a code 5, which is associated to unmatching passwords. In any other case we'll use the message attached to the error. Fixes #8275 Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by PascalPrecht
🛠️ update help messages in Makefile targets Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ Update en.json Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by hesterbruikman
🛠️ Minor copy changes wallet Set default currency > Set currency These three words prove that a transaction is safe. > You should see these 3 words before signing each transaction You should see these words before signing each transaction. If you don’t, cancel and sign out. > If you see a different combination, cancel the transaction and sign out Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by hesterbruikman
🛠️ Update Russian, Korean, and Chinese translation Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by jinhojang6
🛠️ Increment retry count when ENS fails to verify When an ENS name fails to verify, we should increment the retry count so that it back offs. All the changes are in status-go. Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by cammellos
🛠️ Logging in networks Signed-off-by: Serhy sergii@status.im by Serhy
🛠️ Add profile screen in profile stack Fixes #7437 Signed-off-by: Gheorghe Pinzaru feross95@gmail.com by Ferossgp
🛠️ qr testing mode, fixed qr pure address and EIP681 issues Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by flexsurfer
🛠️ Use ms instead of seconds Fixes: #10249 We were using seconds instead of seconds, therefore the gap would always end up as last. Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by cammellos
🛠️ [#10272] Hide key-uid from keycard login screen by rasom

---

CONTRIBUTORS

Last week there were 14 contributors.
👤 flexsurfer
👤 rasom
👤 jrainville
👤 yenda
👤 jakubgs
👤 cammellos
👤 michaelsbradleyjr
👤 Ferossgp
👤 churik
👤 siphiuel
👤 PascalPrecht
👤 hesterbruikman
👤 jinhojang6
👤 Serhy

---

STARGAZERS

Last week there were 7 stagazers.
⭐ 2k13yr
⭐ fgladisch
⭐ seenureddy
⭐ vijayantkatyal
⭐ sunlight2728
⭐ kdedev
⭐ haldoh
You all are the stars! 🌟

---

RELEASES

Last week there were no releases.

---

That's all for last week, please 👀 Watch and ⭐ Star the repository status-im/status-react to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆