Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perfromance][chat] Remove all subscriptions from list items #10380

Closed
flexsurfer opened this issue Apr 21, 2020 · 1 comment
Closed

[perfromance][chat] Remove all subscriptions from list items #10380

flexsurfer opened this issue Apr 21, 2020 · 1 comment
Assignees
@flexsurfer
Labels
E:Mobile Performance MVP feature feature requests

Comments

@flexsurfer
Copy link
Member

flexsurfer commented Apr 21, 2020 •
edited
Loading

We shouldn't use subscriptions inside list items because when we scrolling subscriptions are being created , run and disposed , also when app-db is updated it's expensive to update all subscriptions and views

image
@flexsurfer flexsurfer mentioned this issue Apr 21, 2020
Closed
8 tasks
@weekly-digest weekly-digest bot mentioned this issue Apr 26, 2020
Closed
@flexsurfer flexsurfer self-assigned this May 1, 2020
@flexsurfer flexsurfer mentioned this issue May 28, 2020
Merged
@flexsurfer
Copy link
Member Author

actually its not an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flexsurfer flexsurfer

Labels
E:Mobile Performance MVP feature feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flexsurfer