Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Digest (19 April, 2020 - 26 April, 2020) #10435

Closed
weekly-digest bot opened this issue Apr 26, 2020 · 0 comments
Closed

Weekly Digest (19 April, 2020 - 26 April, 2020) #10435

weekly-digest bot opened this issue Apr 26, 2020 · 0 comments

Comments

@weekly-digest
Copy link

weekly-digest bot commented Apr 26, 2020

Here's the Weekly Digest for status-im/status-react:


ISSUES

Last week 69 issues were created.
Of these, 28 issues have been closed and 41 issues are still open.

OPEN ISSUES

💚 #10434 Account is freezing with endless spinner if tap on account from list during sign in when autologin is enabled, by churik
💚 #10432 Can't open watch-only account inside keycard multiaccount due to missing address field, by churik
💚 #10431 Pending transactions are not shown in wallet (keycard accounts only), by churik
💚 #10430 [keycard] [e2e test menu] Use regular multiacc for kk simulation , by rasom
💚 #10429 Margin issue in public chat input field, by Serhy
💚 #10428 After 1 launch of application when error is appeared during creating flow (i.e. wrong card) "Okay" button is unaccessible, by churik
💚 #10427 First carrousel image onboarding is cut off, by hesterbruikman
💚 #10426 Truncate Chat key display in Profile in middle, by hesterbruikman
💚 #10425 Blank Chats view if quickly tap twice "<" back button from any chat view , by Serhy
💚 #10424 "Offline, waiting for WiFi" chat status when Mobile network connected is misleading, by Serhy
💚 #10423 "cannot locate account for address: [wallet address]" error when sending TX, by Serhy
💚 #10422 Show ENS name only when confirmed, by jrainville
💚 #10421 [#10385] [perfromance][chat] Optimize input field in chat, by flexsurfer
💚 #10419 WIP Add animated headers to profiles, by Ferossgp
💚 #10418 Can login to account just via tap upon it from Your keys view, by Serhy
💚 #10417 Redefine technical specs for image sending, by rachelhamlin
💚 #10416 Research desktop build process, by jakubgs
💚 #10414 Implement support for latest version of eip-1193, by flexsurfer
💚 #10413 fix: display the value to sign as a bytes32 hex string if the data is 66 chars long, by richard-ramos
💚 #10411 Try to make desktop work by commenting out packages etc., by siphiuel
💚 #10404 Message marked as sent but it's not (when bad network connection), by Serhy
💚 #10398 User is navigated to "Your keys have been successfully recovered" screen instead of accounts list if tap on "Back" after unlock existing account, by churik
💚 #10395 Research and spec personal nodes, by StatusSceptre
💚 #10394 fix: add debounce to "Done" button in the recipient selection dialog, by richard-ramos
💚 #10393 fix: change amount-input field keyboard type and autocapitalization to display decimal separator, by richard-ramos
💚 #10392 "Sync using mobile data?" bottom sheet is overlapped with keyboard if app is in foreground, by churik
💚 #10391 fix: prevent multiple taps on Register button from opening several tx during ENS registration, by michaelsbradleyjr
💚 #10388 fix(signing/views): allow discarding signing popup when tx in progress, by PascalPrecht
💚 #10386 [perfromance][chat] Optimize chat view, by flexsurfer
💚 #10385 [perfromance][chat] Optimize input field in chat, by flexsurfer
💚 #10384 Protocol specs, by rachelhamlin
💚 #10383 [perfromance] Performance EPIC, by flexsurfer
💚 #10382 [perfromance][contact] Optimize navigation, by flexsurfer
💚 #10381 [perfromance][contact] Optimize contacts subscriptions, by flexsurfer
💚 #10380 [perfromance][chat] Remove all subscriptions from list items, by flexsurfer
💚 #10379 [perfromance][chat] Optimize chat subscriptions, by flexsurfer
💚 #10377 [perfromance] Improve sign in flow, by flexsurfer
💚 #10375 Can't install Status on real android device using make command, by PascalPrecht
💚 #10373 Add collectibles support to Status wallet 🦋, by hesterbruikman
💚 #10372 feat: persistent send/receive action at bottom of asset list, by michaelsbradleyjr
💚 #10365 fix: connectivity banner height, by emizzle

CLOSED ISSUES

❤️ #10433 Android build crashes after launch with Java.lang.UnsatisfiedLinkError, by Serhy
❤️ #10420 Nix refactor of Android SDK derivation, by jakubgs
❤️ #10415 [#10409] Invalid mnemonic on keycard acc creation, by rasom
❤️ #10412 Bootnodes e2e, by churik
❤️ #10410 fix Gradle plugin by downgrading to 3.5.3, by jakubgs
❤️ #10409 Invalid passphrase for keycard multiacc, by rasom
❤️ #10408 fix(wallet/accounts): don't store derived account when it exists in app db, by PascalPrecht
❤️ #10407 [Fixes: #10390] Re-enable group chat on re-invite, by cammellos
❤️ #10406 [#10396] Quoted text (using markdown) in dark mode is hardly visible, by flexsurfer
❤️ #10405 Handle when message confirmations arrive out of order., by cammellos
❤️ #10403 bump re-frame and remove 16ms delay for reagent tick, by flexsurfer
❤️ #10402 Revert "gradle: upgrade plugin to 3.6.0", by rasom
❤️ #10401 nix: upgrade nodejs to 12.16.2, by jakubgs
❤️ #10400 start loading messages earlier, by flexsurfer
❤️ #10397 upgrade fastlane and plugins, by jakubgs
❤️ #10396 Quoted text (using markdown) in dark mode is hardly visible, by churik
❤️ #10390 New invite to group chat will be not sent if user left chat and then will be readded, by churik
❤️ #10389 Sometimes messages-replies don't change state to "Sent" (endless spinner), by churik
❤️ #10387 gradle: upgrade plugin to 3.6.0, by jakubgs
❤️ #10378 [perfromance] Investigate reagent tick, by flexsurfer
❤️ #10376 makefile: add missing TARGET for android-clean, by jakubgs
❤️ #10374 Fix replies messages, by cammellos
❤️ #10371 Message that contains only emoji are shown as replies to "Unknown" in all chats, by churik
❤️ #10370 [#10369] App freezes on transaction signing after entering wrong pass…, by flexsurfer
❤️ #10369 App freezes on transaction signing after entering wrong password, by churik
❤️ #10368 [#10366] App Dark mode: signing phrase+message not visible when Signi…, by flexsurfer
❤️ #10367 re-frisk 1.0, by flexsurfer
❤️ #10366 App Dark mode: signing phrase+message not visible when Signing message in Dapps, by Serhy

LIKED ISSUE

👍 #10365 fix: connectivity banner height, by emizzle
It received 👍 x2, 😄 x0, 🎉 x0 and ❤️ x1.

NOISY ISSUE

🔈 #10373 Add collectibles support to Status wallet 🦋, by hesterbruikman
It received 19 comments.


PULL REQUESTS

Last week, 49 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 27 pull requests were updated.
💛 #10430 [keycard] [e2e test menu] Use regular multiacc for kk simulation , by rasom
💛 #10422 Show ENS name only when confirmed, by jrainville
💛 #10421 [#10385] [perfromance][chat] Optimize input field in chat, by flexsurfer
💛 #10419 WIP Add animated headers to profiles, by Ferossgp
💛 #10413 fix: display the value to sign as a bytes32 hex string if the data is 66 chars long, by richard-ramos
💛 #10411 Try to make desktop work by commenting out packages etc., by siphiuel
💛 #10394 fix: add debounce to "Done" button in the recipient selection dialog, by richard-ramos
💛 #10393 fix: change amount-input field keyboard type and autocapitalization to display decimal separator, by richard-ramos
💛 #10391 fix: prevent multiple taps on Register button from opening several tx during ENS registration, by michaelsbradleyjr
💛 #10388 fix(signing/views): allow discarding signing popup when tx in progress, by PascalPrecht
💛 #10372 feat: persistent send/receive action at bottom of asset list, by michaelsbradleyjr
💛 #10365 fix: connectivity banner height, by emizzle
💛 #10360 feat: add i18n strings for the missing strings, by jrainville
💛 #10354 Refactor delete account algorithm to properly remove deleted account, by PascalPrecht
💛 #10349 fix: display value decimals instead of using exp notation, by richard-ramos
💛 #10344 [WIP] Upgrade status-go, by cammellos
💛 #10342 fix: fix mailserver popup showing after canceling it, by jrainville
💛 #10338 Add component library skeleton, by Ferossgp
💛 #10333 Show redeem text for Keycard redeem txs, by siphiuel
💛 #10330 Use a single in-progress? flag for signing, by siphiuel
💛 #10327 fix: added navigationBarColor to style, by richard-ramos
💛 #10294 Notifications, by yenda
💛 #10217 Shadow cljs, by yenda
💛 #10169 WIP Starter pack, by Ferossgp
💛 #10139 [wip] install referrer, by flexsurfer
💛 #10134 Remove ens name from local database, by vkjr
💛 #10131 WIP Add animation to numpad and button component, by Ferossgp

MERGED PULL REQUEST

Last week, 22 pull requests were merged.
💜 #10420 Nix refactor of Android SDK derivation, by jakubgs
💜 #10415 [#10409] Invalid mnemonic on keycard acc creation, by rasom
💜 #10412 Bootnodes e2e, by churik
💜 #10408 fix(wallet/accounts): don't store derived account when it exists in app db, by PascalPrecht
💜 #10407 [Fixes: #10390] Re-enable group chat on re-invite, by cammellos
💜 #10406 [#10396] Quoted text (using markdown) in dark mode is hardly visible, by flexsurfer
💜 #10405 Handle when message confirmations arrive out of order., by cammellos
💜 #10403 bump re-frame and remove 16ms delay for reagent tick, by flexsurfer
💜 #10402 Revert "gradle: upgrade plugin to 3.6.0", by rasom
💜 #10401 nix: upgrade nodejs to 12.16.2, by jakubgs
💜 #10400 start loading messages earlier, by flexsurfer
💜 #10397 upgrade fastlane and plugins, by jakubgs
💜 #10387 gradle: upgrade plugin to 3.6.0, by jakubgs
💜 #10376 makefile: add missing TARGET for android-clean, by jakubgs
💜 #10374 Fix replies messages, by cammellos
💜 #10370 [#10369] App freezes on transaction signing after entering wrong pass…, by flexsurfer
💜 #10368 [#10366] App Dark mode: signing phrase+message not visible when Signi…, by flexsurfer
💜 #10367 re-frisk 1.0, by flexsurfer
💜 #10361 Update translations, by jinhojang6
💜 #10357 Dont send extra contacts, by cammellos
💜 #10356 Upgrade e2e, by churik
💜 #10340 upgrade Nix packages, and a lot of dependencies, by jakubgs


COMMITS

Last week there were 29 commits.
🛠️ undo removing of preBuild gradle stop This partially reverts commit 548fe04f54fe6d6b572dd8ecbbf6de88227f68d1. Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ fix(wallet/accounts): don't store derived account when it exists in app db As discussed in #10326 and later in https://github.com/status-im/status-go/issues/1939, it turns out that, when a user tries to add an account (from a seed phrase), while an account with the same address (that the seed phrase would result in) exists in the application state, the application would still go ahead and store the derived account in status-go. After that it still reports to the user that the 'Account already exits'. This commit ensures that Status doesn't try to store the derived account when the account already exists in the application database. Fixes #10326 Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by PascalPrecht
🛠️ nix: upgrade 2.3.2 > 2.3.4 Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ nix: refactor android sdk package Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ gradle: remove unused buck configuration Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ bootnode e2e + translations + new checks in e2e Signed-off-by: Churikova Tetiana churikova.tm@gmail.com by churik
🛠️ fix Gradle plugin by upgrading to 3.5.3 We tried upgrading to 3.6.0 but it made app fail to start: https://github.com/status-im/status-react/pull/10402 Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ [#10409] Invalid mnemonic on keycard acc creation Usage of Keycard.generateMnemonic is removed from the code as we always generate new multiaccounts on status-go side. Previously it was misused and was called with intention of generation of mnemonic for an existing keycard multiacc. by rasom
🛠️ [Fixes: #10390] Re-enable group chat on re-invite If we get re-invited to a chat that we left, the chat will be shown again. Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by cammellos
🛠️ re-frisk 1.0 Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by flexsurfer
🛠️ bump re-frame and remove 16ms delay for reagent tick Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by flexsurfer
🛠️ Handle when message confirmations arrive out of order. In some cases message confirmations might arrive out of order, before status-go calls the callback for a sent message. This commit changes the behavior so that confirmations out of order are not ignored and they are checked when the callback for sending message is called. Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by cammellos
🛠️ [#10396] Quoted text (using markdown) in dark mode is hardly visible Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by flexsurfer
🛠️ start loading messages earlier Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by flexsurfer
🛠️ nix: upgrade nodejs to 12.16.2 Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ Revert "gradle: upgrade plugin to 3.6.0" This reverts commit 938f3df8431bd3d16f9954ecdb84bea8a68b4532. Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by rasom
🛠️ upgrade e2e Signed-off-by: Churikova Tetiana churikova.tm@gmail.com by churik
🛠️ upgrade fastlane and plugins Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ Update translations Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by jinhojang6
🛠️ react-native: avoid Haste module naming collision warnings Warnings like this: jest-haste-map: Haste module naming collision: StatusIm-Mobile The following files share their name; please adjust your hasteImpl: * /mobile/js_files/package.json * /package.json Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ nix: completely remove legacy TARGET_OS variable Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ nix: move nix-purge code to nix/scripts/purge.sh Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ makefile: add missing TARGET for android-clean Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ gradle: upgrade plugin to 3.6.0 This is to fix incompatibility with new Gradle 5.6.4: https://developer.android.com/studio/releases/gradle-plugin#updating-gradle Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ Fix replies emoji messages Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by cammellos
🛠️ Don't send extra contacts from status-go Previous we sent all contacts from status-go, also those that we only create to memoize name/image. This commit changes the behavior so that only contacts that have custom fields are received by status-react (added by us, added by them, blocked, with a verified ENS name) Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by cammellos
🛠️ [#10369] App freezes on transaction signing after entering wrong password Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by flexsurfer
🛠️ [#10366] App Dark mode: signing phrase+message not visible when Signing message in Dapps Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by flexsurfer
🛠️ upgrade Nix packages, and a lot of dependencies Notable version upgrades: - Go: 1.13.4 > 1.14.0 - GoMobile: 20190806 > 20200329 - NodeJS: 10.17.0 > 12.0.0 - Yarn: 1.19.1 > 1.22.4 - Gradle: 5.1.1 > 5.6.4 - OpenJDK: 1.8.0-222 > 8u242-b08 - Clojure: 1.10.0.411 > 1.10.1.507 OpenSSL is still stuck on 1.0.2u due to Android SDK. Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs


CONTRIBUTORS

Last week there were 7 contributors.
👤 jakubgs
👤 PascalPrecht
👤 churik
👤 rasom
👤 cammellos
👤 flexsurfer
👤 jinhojang6


STARGAZERS

Last week there were 7 stagazers.
islamcms
0xcccc
bartolomej
KyleNie
meabed
Warlock1994
cyhpku
You all are the stars! 🌟


RELEASES

Last week there were no releases.


That's all for last week, please 👀 Watch and Star the repository status-im/status-react to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant