Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After 1 launch of application buttons ob android native dialogs are unaccessible #10428

Closed
churik opened this issue Apr 24, 2020 · 10 comments
Closed
Labels

Comments

@churik
Copy link
Member

churik commented Apr 24, 2020

Bug Report

Problem

Monosnap 2020-04-24 12-35-20

Not sure that this issue is only about keycard errors but tried with the error-report dialog for creating account flow and I couldn't.

Expected behavior

Can tap OK button

Actual behavior

OK button is not accessible; only way to continue use app is to relaunch the app.

Reproduction

  • Open Status (reproducible only on 1 launch of app, is not reproducible if that build already was installed, removed and reinstalled)
  • Go to get Started > Generate Keys > Next > select keycard > Begin setup
  • Tap any card (not keycard) or keycard without applet

Additional Information

  • Status version: nightly 24/04/2020
  • Operating System: Android 10 (phone Xiaomi Mi Note 9)
@churik
Copy link
Member Author

churik commented Apr 27, 2020

cc @guylouis

@guylouis guylouis added this to LOW in Keycard Apr 27, 2020
@guylouis
Copy link
Contributor

cc @bitgamma
do you know which is the test we apply to the card when displaying this message ? meaning are we discrimintaing between the case where the card is a keycard (e.g with the global platform key of the card ?) and the card is another card than keycard (e.g. your VISA card in your wallet) ?
If not, how could we discriminate (which criteria is best) so that wer can have two different error messages?

@guylouis guylouis removed this from LOW in Keycard Apr 27, 2020
@guylouis guylouis added this to LOW in Keycard Apr 27, 2020
@bitgamma
Copy link
Member

I don't know exactly what test we make, but I guess we only try to SELECT the applet's AID. We could check the keys by issuing an INITIALIZE UPDATE, but we risk to block the card's ISD if it happens about 5 times (depends on card) so that'd be a bad idea. We could use the ATR + the output of the GET DATA command to see if it is a card with the same configuration as the JCOP4 platform we use.

Since this would be a bit hit-and-miss and since it should be easy for the user to realize what they have in their hands, I wouldn't put too much logic to discriminate between a Keycard with deleted applet and a non-Keycard.

@guylouis
Copy link
Contributor

Ok so the message is ok
We just need an OK button to close the issue

@churik
Copy link
Member Author

churik commented Apr 27, 2020

It's not only on this error. After error all system-dialogs with OK, Cancel, Continue etc buttons are shown without these buttons.
They are cut until restrt of the application.

@guylouis guylouis moved this from LOW to MEDIUM in Keycard Apr 28, 2020
@rasom
Copy link
Member

rasom commented Apr 29, 2020

I can't reproduce this in dev env

@guylouis guylouis moved this from MEDIUM to LOW in Keycard May 11, 2020
@rasom
Copy link
Member

rasom commented Jun 3, 2020

@churik tried on latest nightly, the issue is not reproducible on redmi note 8 pro, android 9

@rasom rasom removed their assignment Jun 17, 2020
@churik churik changed the title After 1 launch of application when error is appeared during creating flow (i.e. wrong card) "Okay" button is unaccessible After 1 launch of application buttons ob android native dialogs are unaccessible Jun 25, 2020
@churik churik added android and removed keycard labels Jun 25, 2020
@churik churik removed this from LOW in Keycard Jun 25, 2020
@hesterbruikman
Copy link
Contributor

Same issue occurred when attempting to longpress > delete chat #10872

Issue remains until app is closed or reinstalled. Issue disappeared when closing and reopening the app, while notifications kept running.

@cammellos
Copy link
Member

@churik is this still an issue? Otherwise feel free to close. Thanks!

@churik
Copy link
Member Author

churik commented Sep 28, 2020

Haven't seen it for a long time.
closing for now

@churik churik closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants