Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement interface ERC721TokenReceiver and interogation of metadata JSON schema #10454

Closed
hesterbruikman opened this issue Apr 28, 2020 · 2 comments

Comments

@hesterbruikman
Copy link
Contributor

hesterbruikman commented Apr 28, 2020

Problem

See also #10373 to add collectibles in wallet. This issue is more generic and is to provide NFT support regardless of potentially hardcoding any NFTs for Devcon

Few collectibles are currently supported and they are hardcoded as all NFTs follow different formatting and many have their content stored on OpenSea.

We want to set clear requirements for NFT's to be supported by Status wallet so that we can support more NFT's without interfacing with OpenSea. Two of these requirements are:

  • Use ERC-721 compliant contracts, this includes ERC721 and ERC165 interfaces
  • Follow the metadata extension as specified in EIP 721
  • Provide complete metadata JSON schema
  • "image" should contain ipfs://hash
  • Images should have a minimum width of 1080 pixels (the standard recommends images at a width between 320 and 1080 pixels and aspect ratio between 1.91:1 and 4:5 inclusive. We deem this to small for good image quality display in the app

This issue is to make sure that NFT's conform the above requirements are handled appropriately by Status Wallet.

Implementation

  1. Implement ERC721TokenReceiver and functions to interrogate metadata JSON schema. This should provide all required information to display NFT in wallet.
  • Name
  • Description
  • URI to download image
  1. Ensure that all URI that tokenURI returns are supported
  2. Inform users when tokenURI is not IPFS hash and only show images on opt-in (design TBD)

Acceptance Criteria

Notes

Future Steps

Steps which should be taken after this issue has been resolved.

@hesterbruikman
Copy link
Contributor Author

cc @andremedeiros for planning @guylouis for requirements to communicate to NFT developers (image size still TBD)

@errorists
Copy link
Contributor

(the standard recommends images at a width between 320 and 1080 pixels and aspect ratio between 1.91:1 and 4:5 inclusive. Any more detailed requirements on image size?

just want to chime in that's painfully low :( imo anything less than 1080 is too small

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants