-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collectibles support to Status wallet 🦋 #10373
Comments
@guylouis @andremedeiros please check if this accurately captures the Devcon proposal and work required by Core to support the proposal |
the big issue with NFTs they don't follow same standard, implementation of every token is different
other wallets use third party APIs https://docs.opensea.io/reference#api-overview
yes, it can be sent, and in chat as well but every token must be implemented separately
about 4h
this might be tricky to implement |
the complete new designs are here, please let me know if I'm missing something. Collectible display, info, sending flows, and yes I went ahead and added OpenSea integration |
100% One precision though, on devcon has not accepted our proposal yet, but the idea is that It's in the context of ii that, yes, Status wallet should be able to show erc721s. Since the NFTbuckets will be implemented prior to the show (and some totally new NFTs might be created) we can consider that we can add support for the NFTs that will be created for the show beforehand. But it's not ideal if some dapps/nftbuckets are created last minute. If a user redeems his NFT on his wallet and still wants to prove he owns this NFT, I am pretty curious about any ideas how this could work (this is user scenario 2) ? any ideas ? |
@flexsurfer help me understand, why is every token separate? |
@andremedeiros because not all of NFTs uses ERC721, they have their own contracts |
There will be a process around this as tokens need to be authenticated and addresses for NFT buckets provided, so following ERC721 could be a requirement |
but ERC721 will work only for sending, for showing them there is no standard and every NFT should be implemented separately, but to send them we need to show them first :) so ... |
Gotcha. So we'd also need a stickerpack like specification for image formats |
Well that sounds fun. |
I imagine we have two problems (well at least :)) for i. I imagine we hardcode the list for now, right ? couldn't we have the list stored on ipfs and access it from status to make adding an ERC721 easier ? for ii. a first step could be to support only erc-721 contracts that implement the optional erc721 metadata JSON schema (See spec here which includes name, description and image. Also: am I right saying that integrating with opensea API would solve i and ii, but might not fit with our principles (centralized, paid solution) ? Note: a good article about his issue |
would be great if we could find at least one NFT which has optional erc721 metadata :) |
usually, it looks like that (def graphql-url "https://api.pixura.io/graphql")
(defn graphql-query [address]
(str "{
collectiblesByOwner: allErc721Tokens(condition: {owner: \"" address "\"}) {
collectibles: nodes {
tokenId,
metadata: erc721MetadatumByTokenId {
metadataUri,
description,
name,
imageUri
}}}}"))
(defmethod load-collectibles-fx superrare [_ _ _ address _]
{:http-post {:url graphql-url
:data (types/clj->json {:query (graphql-query (ethereum/naked-address address))})
:opts {:headers {"Content-Type" "application/json"}} |
ok, so is this the right conclusion below ?
|
my suggestion is to use ipfs
"image" should contain this is will be similar to how our stickers work , but in that case, such NTFs will be supported only by Status another option would be to implement component for NFTs in status which will be like the special Dapp will be opened not a full screen and it will show only specific view, for example, one NFT or list of NFTs, in that case, we could use opensea API and support all NFTs |
@flexsurfer which special Dapp do you mean? do you mean showing the collectible in a webview?
why not full screen? so if I get that right, we have a list of collectibles you own in your wallet, here we are limited to only showing which meta, the title ? |
can you help me understand ? thanks |
we already show them in webview :) it will be webview only technically for user it will be looking like native it only about implementation
i mean it will be part of status UI, not in the browser, we won't open browser |
because all NFTs are web2, open sea also web2, so they use uri just as in regular web, not sure if they will add support for ipfs protocol |
I am 100% with @flexsurfer here, with a small correction. We should support any URI that |
@hesterbruikman |
Feature Issue
Different use cases for Keycard and the Core app at Devcon 6 have been proposed to the event organizers; Per invitation of the organizers who are looking to provide applications for dogfooding at the event.
Core to the proposal is the use of NFT's:
Currently, NFT's/ERC721 are hardcoded and will need to be expanded. Either hard coded or dynamically.
User Story
Related use cases to distribute and redeem NFT's will be coordinated by the Keycard team (cc @guylouis). Use case 1 and 2 above are integral to how the Core app handles ERC721 tokens and whether/how the user is able to view, manage, share proof of ownership and send these.
Description
Implementation allows to view all NFT's distributed at Devcon through Keycard:
Acceptance Criteria
Notes
The text was updated successfully, but these errors were encountered: