Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different fee amount of the same precision is shown for same sum after editing the sum [develop] #1501

Closed
annadanchenko opened this issue Jul 26, 2017 · 2 comments · Fixed by #1509

Comments

@annadanchenko
Copy link

Description

Type: Bug

Summary:
Max fee to send 10 ETH is shown as "0.0144883" and later is shown as "0.0144890" if edit the sum. If move slider back to mid position and again to max fee then fee amount is shown as "0.0144883". Actual amounts shown for the fee in your case might be other numbers, but issue is in getting different amounts for the same sum. I would expect getting same fee amount for the same sum whatever edits are performed in the input field.

It's possible that fee will change for the same amount after some time, however here it's changing from X to Y and than again to same X value (if re-open screen or move slider back to mid position and to max), so it's not because network got some fee changes.

We had issue #1489 where precision/amount for the fee was different. Now precision is OK but amount is not OK. It looks like we update fee "on delete" but do not on "on type".
screenshot_20170726-185627 1
screenshot_20170726-185620

Expected behavior

same fee with same precision shown for the same sum.

Actual behavior

Max fee to send 10 ETH is shown as "0.0144883" and later is shown as "0.0144890" if edit the sum

Reproduction

video: https://drive.google.com/open?id=0Bz3t9zSg1wb7bG50MmhNRlVXc28
TestFairy session: https://app.testfairy.com/projects/4803622-status/builds/6191757/sessions/2/?accessToken=FY1zxVVDrNl9-xmLXYCbQSereYs

  • Open Status
  • Open 1-1 chat
  • Enter /send command, choose contact and enter tx value '10'
  • Move tx fee slider to the right (maximal fee)
  • Change the tx value to '1'. Observe/wait till fee will be changed to another amount
  • Change the tx value to '10' again
  • Observe that the fee value for tx value of '10' is always the same

Additional Information

  • Status version: develop 0.9.8-99-g63d9301a+
  • Operating System:
    Real device Samsung Galaxy S6, Android 6.0.1
    Real device iPhone 6s, iOS 10.2.1
@annadanchenko
Copy link
Author

Same issue occurs on today's develop build on both OS. Note that sometimes max fee does not change after editing an amount but in 8 out of 10 attempts there was same issue:
Android: https://app.testfairy.com/projects/4803622-status/builds/6214473/sessions/41/?accessToken=omVRz9wOJUOiMHUdHU91GlogJCw
iOS: https://app.testfairy.com/projects/4803590-status/builds/6214474/sessions/22/?accessToken=k3-tvTbLHSiGJjcrTsWUT9pzt-A

build 0.9.9d108

@annadanchenko annadanchenko reopened this Jul 30, 2017
yalu pushed a commit to yalu/status-react that referenced this issue Jul 31, 2017
@annadanchenko
Copy link
Author

not applicable anymore - fee screen is removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants