fix #1501 wallet: display right fee amount #1509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1501
Summary:
Previously, to be able to format fractional number to fixed amount of decimal places, string returned from
web3.fromWei
call was parsed into native js float type withparseFloat
function. Unfortunately for some amounts (not immediately obvious during developer testing), this is not enough, as native js float has problems with precision, so slightly different sum was displayed between fee/amount edits.This PR solves it by parsing
web3.fromWei
result directly into BigNumber type (this type should be returned fromweb3.fromWei
call anyway, but it depends on call arguments) and callingtoFixed(n)
method in it.Steps to test:
/send
command and select amount 10status: ready