-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display names and profile pictures of some users are not fetched in community channels #17229
Comments
@cammellos, @pavloburykh, @churik is this issue still relevant? It's still tagged for 1.26, are we going to move it to 1.27? @cammellos, are you still working on it or should we leave it open for someone else to pick if we prioritize it? |
@ilmotta let me get it in shape, I will refresh the PR tomorrow, apologies for the delay |
I guess it was fixed in status-go, reopen if it still persist |
Re-opening the issue as it has not been fixed. Here are the screenshots and video from nightly (Jan 5, 2024) build. Pay attention at mention suggest list and empty mentions within existing message history. telegram-cloud-document-2-5334622124940216321.mp4 |
Hi @pavloburykh , i followed your steps and reproduced it but maybe a little different i made was to the 2nd step: I'm unable to reproduce this issue if User B wait User A accepted the join request and then goes offline. |
@qfrank thank you for finding correct steps to reproduce the issue locally. At the same time I think there might be some other unknown steps to reproduce the issue. The reason why I think so is that in case described here #17229 (comment) most of community members have broken data. I doubt that all of them went offline without waiting for request got accepted. Moreover, I am sure that they didn't, cause all those community members are our test users and we usually wait for request to be accepted. I can confirm that most of those test user have joined community, used it for couple of tests and then never come back online. But do we consider such case acceptable? If there is a community member who has been offline for some time - then his data will broken for new members. |
I was wondering if UserB can |
If this is the case, proberly i need write a test to try to fetch the contact code messages to see if UserC can receive the full messages. This issue could also be relate to message reliability issue 🤔 |
I guess it might have the same roots as #20514 (cross-posting) |
|
You can follow the below steps for reproduction but mind that those issues can be easily observed if you restore your main account (which is member of Status comm) on mobile, go to any channel in Status community and check mentions list. You will see bunch of users with pub keys with absent profile icons etc.
Preconditions:
Steps:
Actual result:
User's B data is fetched for User C in one of the following cases:
On the video below you can observe the described behaviour (User C is from the right part of the screen)
User_C_logs.zip
fetching.display.names.mp4
Additional Information
The text was updated successfully, but these errors were encountered: