Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing avatar and name in members of the community channels and group chats #20619

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix missing avatar and name in members of the community channels and group chats #20619

wants to merge 3 commits into from
+137 −52

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Jul 2, 2024 •
edited
Loading

fixes #20520
fixes #20431

status: ready

@Parveshdhull Parveshdhull marked this pull request as draft July 2, 2024 04:56
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jul 2, 2024
@Parveshdhull Parveshdhull self-assigned this Jul 2, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Jul 2, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fe2216a #1 2024-07-02 05:01:28 ~4 min tests 📄log
✔️ fe2216a #1 2024-07-02 05:03:14 ~6 min android 🤖apk 📲
✔️ fe2216a #1 2024-07-02 05:03:44 ~7 min android-e2e 🤖apk 📲
✔️ fe2216a #1 2024-07-02 05:06:00 ~9 min ios 📱ipa 📲
❌ 35d4855 #2 2024-07-04 12:45:10 ~3 min tests 📄log
✔️ 35d4855 #2 2024-07-04 12:48:45 ~6 min android-e2e 🤖apk 📲
✔️ 35d4855 #2 2024-07-04 12:48:52 ~6 min android 🤖apk 📲
✔️ 35d4855 #2 2024-07-04 12:50:48 ~8 min ios 📱ipa 📲
❌ c21cbc1 #3 2024-07-04 13:11:44 ~3 min tests 📄log
✔️ c21cbc1 #3 2024-07-04 13:15:00 ~6 min android-e2e 🤖apk 📲
✔️ c21cbc1 #3 2024-07-04 13:17:11 ~8 min android 🤖apk 📲
✔️ c21cbc1 #3 2024-07-04 13:17:34 ~8 min ios 📱ipa 📲
❌ be054f2 #4 2024-07-04 13:25:38 ~2 min tests 📄log
✔️ be054f2 #4 2024-07-04 13:29:03 ~6 min android-e2e 🤖apk 📲
✔️ be054f2 #4 2024-07-04 13:29:54 ~7 min android 🤖apk 📲
✔️ be054f2 #4 2024-07-04 13:31:18 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1fb9b70 #5 2024-07-04 13:36:41 ~4 min tests 📄log
✔️ 1fb9b70 #5 2024-07-04 13:38:18 ~6 min android-e2e 🤖apk 📲
✔️ 1fb9b70 #5 2024-07-04 13:39:43 ~7 min android 🤖apk 📲
✔️ 1fb9b70 #5 2024-07-04 13:40:58 ~8 min ios 📱ipa 📲
✔️ 5757960 #6 2024-07-04 15:30:18 ~4 min tests 📄log
✔️ 5757960 #6 2024-07-04 15:32:04 ~6 min android-e2e 🤖apk 📲
✔️ 5757960 #6 2024-07-04 15:32:39 ~6 min android 🤖apk 📲
✔️ 5757960 #6 2024-07-04 15:34:49 ~9 min ios 📱ipa 📲

@Parveshdhull Parveshdhull force-pushed the fix/communities-and-group-members-name branch from fe2216a to 35d4855 Compare July 4, 2024 12:41
@Parveshdhull Parveshdhull force-pushed the fix/communities-and-group-members-name branch from 35d4855 to c21cbc1 Compare July 4, 2024 13:08
@Parveshdhull Parveshdhull force-pushed the fix/communities-and-group-members-name branch from be054f2 to 1fb9b70 Compare July 4, 2024 13:31
@Parveshdhull Parveshdhull changed the title [WIP]: Fix missing avatar and name in members of the community channels and group chats Fix missing avatar and name in members of the community channels and group chats Jul 4, 2024
@Parveshdhull Parveshdhull marked this pull request as ready for review July 4, 2024 13:34
ilmotta
ilmotta approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks miles better than what's in develop 🚀

src/native_module/core.cljs Outdated Show resolved Hide resolved
src/status_im/subs/contact/utils.cljs Outdated Show resolved Hide resolved
@Parveshdhull Parveshdhull moved this from REVIEW to E2E Tests in Pipeline for QA Jul 4, 2024
@VolodLytvynenko VolodLytvynenko self-assigned this Jul 5, 2024
@VolodLytvynenko VolodLytvynenko moved this from E2E Tests to IN TESTING in Pipeline for QA Jul 5, 2024
@ilmotta
Copy link
Contributor

ilmotta commented Jul 5, 2024

@Parveshdhull, do you see any connection about the fixes being made here and this other issue? #17229 The video in that PR description is helpful.

@Parveshdhull
Copy link
Member Author

Parveshdhull commented Jul 5, 2024 •
edited
Loading

@Parveshdhull, do you see any connection about the fixes being made here and this other issue? #17229 The video in that PR description is helpful.

Hi @ilmotta I am not sure but some of the issues mentioned in #17229 might have been fixed in the PR.

You will see bunch of users with pub keys with absent profile icons etc

1. As we are modifying subscription which returns :chats/photo-path icons for mentions probably fixed.

image

2. In this case, the empty mention might have been fixed.

But I think it all depends if these components are using these subscriptions or not. I guess once this PR is merged, we can update #17229 or create a new issue with a changed scope. wdyt?

@ilmotta
Copy link
Contributor

ilmotta commented Jul 5, 2024

But I think it all depends if these components are using these subscriptions or not. I guess once this PR is merged, we can update #17229 or create a new issue with a changed scope. wdyt?

Good idea 👍🏼 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilmotta ilmotta ilmotta approved these changes

@cammellos cammellos Awaiting requested review from cammellos

Assignees

@Parveshdhull Parveshdhull

@VolodLytvynenko VolodLytvynenko

Labels
request-manual-qa
Projects
Pipeline for QA
  
IN TESTING
Milestone
No milestone
4 participants
@Parveshdhull @status-im-auto @ilmotta @VolodLytvynenko