-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing avatar and name in members of the community channels and group chats #20619
base: develop
Are you sure you want to change the base?
Conversation
Jenkins BuildsClick to see older builds (16)
|
fe2216a
to
35d4855
Compare
35d4855
to
c21cbc1
Compare
be054f2
to
1fb9b70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks miles better than what's in develop
🚀
@Parveshdhull, do you see any connection about the fixes being made here and this other issue? #17229 The video in that PR description is helpful. |
Hi @ilmotta I am not sure but some of the issues mentioned in #17229 might have been fixed in the PR.
1. As we are modifying subscription which returns 2. In this case, the empty mention might have been fixed. But I think it all depends if these components are using these subscriptions or not. I guess once this PR is merged, we can update #17229 or create a new issue with a changed scope. wdyt? |
Good idea 👍🏼 Thanks! |
fixes #20520
fixes #20431
status: ready