Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Integration tests into two separate make commands. #18112

Closed
J-Son89 opened this issue Dec 7, 2023 · 2 comments · Fixed by #18304
Closed

Separate Integration tests into two separate make commands. #18112

J-Son89 opened this issue Dec 7, 2023 · 2 comments · Fixed by #18304
Assignees
@ilmotta
Labels
developer-xp feature feature requests

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Dec 7, 2023

Currently running make test runs a set of integration tests (covering RPC endpoints in Status Go) and a set of unit tests covering reframe subs and events etc.

We should split these into two separate jobs. This will make it clearer and also allow these tests to be run externally, there is currently some discussion about running these as part of Status Go pr's and this will be needed to make that happen.

This might involve extending the current CI job in our codebase to handle this change.
@J-Son89
Copy link
Contributor Author

J-Son89 commented Jan 2, 2024

@ilmotta - I had this issue. Maybe we can link in pr - #18304

@ilmotta
Copy link
Contributor

ilmotta commented Jan 2, 2024

I missed this issue, thank you @J-Son89

@ilmotta ilmotta mentioned this issue Jan 2, 2024
Merged
ilmotta added a commit that referenced this issue Jan 5, 2024
@ilmotta
Run integration tests separately from unit tests (#18304)
b4640da 
- make test still exists, so if you have been using it, as well as make
  test-watch, they should all work exactly the same.
- [Changed] As part of the check stage, Jenkins will run Lint and Unit Tests
  in parallel. Integration Tests run later because running them at the same
  time as Unit Tests caused errors.
- [Added] "make unit-test" and "make unit-test-watch" run unit tests only.
  Watching all unit tests is faster now because we ignore integration tests and
  we only compile shadow-cljs :mock target once. We are at approximately 10-15s
  to re-run all unit tests after saving a watched file, depending on your
  hardware. If you change mocks.js_dependencies.cljs, you must re-run the make
  target.
- [Added] "make integration-test" and "make integration-test-watch" run
  integration tests only. These are much slower than the unit tests.

Fixes #18112
yevh-berdnyk pushed a commit that referenced this issue Jan 5, 2024
@ilmotta @yevh-berdnyk
Run integration tests separately from unit tests (#18304)
dbb27fc 
- make test still exists, so if you have been using it, as well as make
  test-watch, they should all work exactly the same.
- [Changed] As part of the check stage, Jenkins will run Lint and Unit Tests
  in parallel. Integration Tests run later because running them at the same
  time as Unit Tests caused errors.
- [Added] "make unit-test" and "make unit-test-watch" run unit tests only.
  Watching all unit tests is faster now because we ignore integration tests and
  we only compile shadow-cljs :mock target once. We are at approximately 10-15s
  to re-run all unit tests after saving a watched file, depending on your
  hardware. If you change mocks.js_dependencies.cljs, you must re-run the make
  target.
- [Added] "make integration-test" and "make integration-test-watch" run
  integration tests only. These are much slower than the unit tests.

Fixes #18112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilmotta ilmotta

Labels
developer-xp feature feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run integration tests separately from unit tests status-im/status-mobile
2 participants
@ilmotta @J-Son89