-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Integration tests into two separate make commands. #18112
Labels
Comments
I missed this issue, thank you @J-Son89 |
ilmotta
added a commit
that referenced
this issue
Jan 5, 2024
- make test still exists, so if you have been using it, as well as make test-watch, they should all work exactly the same. - [Changed] As part of the check stage, Jenkins will run Lint and Unit Tests in parallel. Integration Tests run later because running them at the same time as Unit Tests caused errors. - [Added] "make unit-test" and "make unit-test-watch" run unit tests only. Watching all unit tests is faster now because we ignore integration tests and we only compile shadow-cljs :mock target once. We are at approximately 10-15s to re-run all unit tests after saving a watched file, depending on your hardware. If you change mocks.js_dependencies.cljs, you must re-run the make target. - [Added] "make integration-test" and "make integration-test-watch" run integration tests only. These are much slower than the unit tests. Fixes #18112
yevh-berdnyk
pushed a commit
that referenced
this issue
Jan 5, 2024
- make test still exists, so if you have been using it, as well as make test-watch, they should all work exactly the same. - [Changed] As part of the check stage, Jenkins will run Lint and Unit Tests in parallel. Integration Tests run later because running them at the same time as Unit Tests caused errors. - [Added] "make unit-test" and "make unit-test-watch" run unit tests only. Watching all unit tests is faster now because we ignore integration tests and we only compile shadow-cljs :mock target once. We are at approximately 10-15s to re-run all unit tests after saving a watched file, depending on your hardware. If you change mocks.js_dependencies.cljs, you must re-run the make target. - [Added] "make integration-test" and "make integration-test-watch" run integration tests only. These are much slower than the unit tests. Fixes #18112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently running
make test
runs a set of integration tests (covering RPC endpoints in Status Go) and a set of unit tests covering reframe subs and events etc.We should split these into two separate jobs. This will make it clearer and also allow these tests to be run externally, there is currently some discussion about running these as part of Status Go pr's and this will be needed to make that happen.
This might involve extending the current CI job in our codebase to handle this change.
The text was updated successfully, but these errors were encountered: