You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
List of breaking changes for commits. Makes sure we don't accidentally merge breaking changes into status-react. Mini changelog.
Background
Status-react depends on status-go, and sometimes the interface changes, and the person upgrading status-go isn’t aware of this breaking change. Previously we have communicated such changes in an ad hoc way, and now we want to make it slightly less ad hoc. The goal is not to get a perfect automated solution with CI, end to end testing, release versions, etc, but just to get better at communicating.
Clojure devs: when bumping status-go, please (a) check changelog (b) check Upgrade status-go checklist for breaking changes #2787 for other breaking changes (c) verify with Go team that no breaking changes are in changelog
(Go devs: please (a) indicate in commit message if a change is breaking (change in interface, not implementation) (b) leave a comment in Upgrade status-go checklist for breaking changes #2787 or make sure someone from status-react does this)
We’ll figure out how to make this better later but this should be a start :)
Current state (Jan 16)
At develop-gd71c66a2 in develop and release. No breaking changes communicated, but bug fix. See #2954
Current state (Dec 21)
status-react is currently using status-go version develop-gba6c9653. Compared to status-go develop this is what has changed since then:
> git log --pretty=oneline | grep ba6c9653 -B 100
b7fb51d92ac5333afa4bcb340b1f17960cca33c8 Refactor shh_requestMessages method (#513)
3ff44f545bed7388edbe4e61616c5323d0c863dd travis: update go version to 1.9.x (#507)
b5b8219c4155dbfe066046ab24ef1cef3cd62590 Add Code Style section into CONTRIBUTING.md (#512)
ba6c96532bfdfcc1bc95d5535d3d6b04ee7de49e add enode to request messages params (#508)
List of breaking changes for commits. Makes sure we don't accidentally merge breaking changes into status-react. Mini changelog.
Background
Status-react depends on status-go, and sometimes the interface changes, and the person upgrading status-go isn’t aware of this breaking change. Previously we have communicated such changes in an ad hoc way, and now we want to make it slightly less ad hoc. The goal is not to get a perfect automated solution with CI, end to end testing, release versions, etc, but just to get better at communicating.
Current state (Jan 16)
At
develop-gd71c66a2
indevelop
andrelease
. No breaking changes communicated, but bug fix. See #2954Current state (Dec 21)
status-react is currently using status-go version
develop-gba6c9653
. Compared to status-godevelop
this is what has changed since then:b7fb51d92ac5333afa4bcb340b1f17960cca33c8
is a breaking change (Offline inbox: Use new status-go with breaking change in requesMessages #2785)The text was updated successfully, but these errors were encountered: