Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade status-go checklist for breaking changes #2787

Closed
1 task done
oskarth opened this issue Dec 21, 2017 · 3 comments
Closed
1 task done

Upgrade status-go checklist for breaking changes #2787

oskarth opened this issue Dec 21, 2017 · 3 comments

Comments

@oskarth
Copy link
Contributor

oskarth commented Dec 21, 2017

List of breaking changes for commits. Makes sure we don't accidentally merge breaking changes into status-react. Mini changelog.

Background

Status-react depends on status-go, and sometimes the interface changes, and the person upgrading status-go isn’t aware of this breaking change. Previously we have communicated such changes in an ad hoc way, and now we want to make it slightly less ad hoc. The goal is not to get a perfect automated solution with CI, end to end testing, release versions, etc, but just to get better at communicating.

Current state (Jan 16)

At develop-gd71c66a2 in develop and release. No breaking changes communicated, but bug fix. See #2954

Current state (Dec 21)

status-react is currently using status-go version develop-gba6c9653. Compared to status-go develop this is what has changed since then:

> git log --pretty=oneline | grep ba6c9653 -B 100
b7fb51d92ac5333afa4bcb340b1f17960cca33c8 Refactor shh_requestMessages method (#513)
3ff44f545bed7388edbe4e61616c5323d0c863dd travis: update go version to 1.9.x (#507)
b5b8219c4155dbfe066046ab24ef1cef3cd62590 Add Code Style section into CONTRIBUTING.md (#512)
ba6c96532bfdfcc1bc95d5535d3d6b04ee7de49e add enode to request messages params (#508)
@oskarth oskarth added the release label Jan 4, 2018
@oskarth oskarth added this to To Do in Release swarm #64: MVP (0.9.13) via automation Jan 4, 2018
@oskarth
Copy link
Contributor Author

oskarth commented Jan 4, 2018

TODO: Update this based on current status-go version

UPDATE JAN 16: Done.

@oskarth oskarth moved this from To Do to Done in Release swarm #64: MVP (0.9.13) Jan 16, 2018
@oskarth
Copy link
Contributor Author

oskarth commented Feb 12, 2018

See #3236

@oskarth
Copy link
Contributor Author

oskarth commented Apr 27, 2018

Not being kept up to date, as predicted by a bunch of people. Closing.

@oskarth oskarth closed this as completed Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant