Update status-go to develop-g607954bf #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adambabik I'm not sure what exactly needs to be reviewed on status-react side. As far as i see from changelog, no API (interface to status-react) breaking changes were made, except maybe this
But as far as i could tell, it's internal only change. TransactionResult JSON returned to status-react seems to be the same. |
yenda
approved these changes
Feb 7, 2018
|
Branch: PR-3236 |
|
@dmitryn No need to review anything. I just want to keep status-go up-to-date in status-react. Otherwise, if we plan to update after too many changes it will be hard to figure out potential issues. The important thing is geth 1.7.3 update. There is a possibility that we have not enough geth 1.7.3 nodes in our cluster so we would need to update them before this PR is merged. We should thoroughly test all scenarios like sending messages between users etc. |
|
@adambabik so I can merge this ? |
|
@yenda shouldn't it be tested by the Q&A team before merging? I am afraid it may not work in some configuration because of not enough geth 1.7.3 nodes. I will take a look what we have in our cluster first. |
adambabik
force-pushed
the
feature/update-statusgo
branch
from
27d01a1
to
5219171
Compare
goranjovic
approved these changes
Feb 8, 2018
1 task
|
@adambabik @oskarth what do you think about updating it a bit further to |
|
@mandrigin Would rather not expand scope since this will be in release which is already delayed and this PR in testing. Would you mind creating a separate PR for that update? |
|
@oskarth makes sense, I'll do that. |
Automated test results:test_send_eth_from_wallet_sign_now:x:Test Steps & Error message:
test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:test_transaction_send_command_one_to_one_chat:white_check_mark::Test Steps & Error message:test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:test_transaction_send_command_group_chat:x:Test Steps & Error message:
test_send_stt_from_wallet_via_enter_contact_code:white_check_mark::Test Steps & Error message:test_send_eth_to_request_from_wallet:x:Test Steps & Error message:
test_send_eth_to_request_in_one_to_one_chat:x:Test Steps & Error message:
test_send_eth_to_request_in_group_chat:white_check_mark::Test Steps & Error message: |
|
Branch: PR-3236 |
|
So i have checked basic functionality, like transacting, messaging , i was able to faucet some ETH and add / remove contacts, chatting in a group and public chat. i would say its enough to merge it. |
yenda
force-pushed
the
feature/update-statusgo
branch
from
5219171
to
8a05aab
Compare
Signed-off-by: Eric Dvorsak <eric@dvorsak.fr>
yenda
force-pushed
the
feature/update-statusgo
branch
from
8a05aab
to
65fc4ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another update after a bunch of refactoring we did recently.
Changelog (curated):