Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amount field is limited to 21 characters #4404

Closed
asemiankevich opened this issue May 23, 2018 · 6 comments · Fixed by #5351
Closed

Amount field is limited to 21 characters #4404

asemiankevich opened this issue May 23, 2018 · 6 comments · Fixed by #5351

Comments

@asemiankevich
Copy link
Contributor

asemiankevich commented May 23, 2018

Description

Type: Bug

Summary: Can't enter 18 digits after the comma for the 4-digit amount, for example, I want to send or request 1000,111111111111111111 tokens

Expected behavior

I am able to send any valid amount with the 18 digits limit after a comma, no matter how many digits before comma I have, for ex 1000,111111111111111111 . See also other 2 restrictions in comment #4404 (comment)

Actual behavior

The field is limited so entering 1000,111111111111111111 is not possible

Reproduction

  • Open Status
  • Open wallet
  • Having 2000 tokens try to send 1000,111111111111111111
  • Try to request 1000,111111111111111111
@asemiankevich asemiankevich added this to the Beta milestone May 23, 2018
@rachelhamlin rachelhamlin removed this from the Beta milestone May 23, 2018
@status-github-bot status-github-bot bot added this to bounty-awaiting-approval in Status Bounty Tracker May 23, 2018
@mandrigin
Copy link
Contributor

@asemiankevich I'd say that is an xs size bounty :)

@asemiankevich
Copy link
Contributor Author

@mandrigin thanks!

@status-github-bot status-github-bot bot removed this from bounty-awaiting-approval in Status Bounty Tracker May 25, 2018
@status-open-bounty
Copy link

status-open-bounty commented May 25, 2018

Balance: 0 ETH
Tokens: SNT: 500.00
Contract address: 0xc757cdbdf804f9c636cac6ee2005249d0def7fe5
Network: Mainnet
Paid to: goranjovic
Visit https://openbounty.status.im to learn more.

@andytudhope andytudhope added this to Bounty Open in Status Bounty Tracker May 25, 2018
@goranjovic goranjovic added this to Triage in Wallet Maintenance May 28, 2018
@asemiankevich asemiankevich moved this from Triage to Backlog/Bugs in Wallet Maintenance Jun 5, 2018
@annadanchenko annadanchenko added this to the Beta milestone Jun 14, 2018
@oskarth
Copy link
Contributor

oskarth commented Jun 15, 2018

Why is this a beta blocker? Seems like a minor ish bug to me.

@chadyj chadyj removed this from the Beta milestone Jun 15, 2018
@annadanchenko
Copy link

annadanchenko commented Jun 15, 2018

@chadyj @oskarth This issue is only one example of having 21 characters as a limit for Amount field. The other consequences are:

  1. If you copy/paste amount longer than 21 characters then field silently cuts it to first 21 characters. For example:
    12345678.123456789012345678 is transformed to
    12345678.123456789012
    The more characters you will have before the comma the more will be cut at the end of sum.
  2. If you typed or pasted long "tail" before entering main part 0.123456789012345678 and then try to edit sum and modify it's "head" from 0 to 1000 you will not be able to do this because field does not react on your typing. So you need to guess that all sum should be deleted and you need to type most significant amount first.

imo, we need to fix this artificial limit that results in narrowing user choices and in case of pasting long amount into actual loosing its last part without any warning to the user.

@chadyj
Copy link
Contributor

chadyj commented Jun 18, 2018

Followed up with Anna:

  • Low probability of users encountering this
  • Low impact for negative consequences (eg loss of funds, crashes, etc)
  • Therefore not a beta blocker, but we will work on it after beta
  • This is a reminder that the beta isn't perfect, and we should communicate this to users in release notes, etc.

@annadanchenko annadanchenko changed the title Amount field does not allow to enter 18 digits after comma / dot Amount field is limited to 21 characters Jun 27, 2018
@goranjovic goranjovic moved this from Backlog/Bugs to Beta X in Wallet Maintenance Jun 28, 2018
@goranjovic goranjovic moved this from Beta X to In progress in Wallet Maintenance Jul 4, 2018
@goranjovic goranjovic moved this from In progress to Beta X in Wallet Maintenance Jul 4, 2018
@goranjovic goranjovic moved this from Beta X to In progress in Wallet Maintenance Jul 4, 2018
@goranjovic goranjovic moved this from In progress to Beta X in Wallet Maintenance Jul 4, 2018
@goranjovic goranjovic moved this from Beta X to In progress in Wallet Maintenance Jul 5, 2018
@goranjovic goranjovic moved this from In progress to Beta X in Wallet Maintenance Jul 5, 2018
@goranjovic goranjovic moved this from Beta X to Next in Wallet Maintenance Jul 5, 2018
@goranjovic goranjovic moved this from Next to Backlog/Bugs in Wallet Maintenance Jul 6, 2018
@pablanopete pablanopete moved this from Bounty Open to Stale Bounties in Status Bounty Tracker Jul 17, 2018
@rachelhamlin rachelhamlin moved this from Backlog/Bugs to Shortlist in Wallet Maintenance Jul 27, 2018
@goranjovic goranjovic moved this from Shortlist to In progress in Wallet Maintenance Jul 27, 2018
@goranjovic goranjovic self-assigned this Jul 27, 2018
@goranjovic goranjovic moved this from In progress to Review/Testing in Wallet Maintenance Aug 1, 2018
goranjovic added a commit that referenced this issue Aug 2, 2018
…equest

Signed-off-by: Goran Jovic <goranjovic@gmail.com>
Wallet Maintenance automation moved this from Review/Testing to Done Aug 2, 2018
@pablanopete pablanopete moved this from Stale Bounties to PR Submitted in Status Bounty Tracker Aug 6, 2018
@pablanopete pablanopete moved this from PR Submitted to Merged & Confirmed in Status Bounty Tracker Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status Bounty Tracker
  
Merged & Confirmed
Development

Successfully merging a pull request may close this issue.

9 participants