bug #4404 - removed the 21 char limit from amount field in send and r… #5351

goranjovic · 2018-08-01T09:20:56Z

Summary:

Amount field in Wallet Send and Request had a 21 char limit, which made sending or requesting certain amounts impossible (e.g. 100000.123456789012345678). To make things worse, if user A requested the amount like this via chat command, when user B replies by sending the payment, the amount would silently get cut off to comply with the limit.

This PR removes the 21 char limit from both fields.

Steps to test:

Try sending values that exceed 21 characters
Try requesting values that exceed 21 characters

status: ready

goranjovic · 2018-08-01T09:21:21Z

jeluard · 2018-08-01T09:23:59Z

Do we still properly handle decimals limit?

status-comment-bot · 2018-08-01T09:43:44Z

branch PR-5351:
apk uploaded to https://i.diawi.com/SHykTm
ipa uploaded to https://i.diawi.com/AWTU9h

Install - Diawi - Development and In-house Apps Wireless Installation

goranjovic · 2018-08-01T09:58:06Z

@jeluard yes

statustestbot · 2018-08-01T12:04:21Z

86% of end-end tests have passed

Total executed tests: 51
Failed tests: 7
Passed tests: 44

Failed tests (7)

Click to expand

1. test_request_and_receive_tokens_in_1_1_chat
Looking for SignTransactionButton Wait for ProgressBar `E selenium.common.exceptions.TimeoutException: Message: 'ProgressBar' is still present on screen, using: 'xpath://android.widget.ProgressBar', during '60' seconds` Device sessions: Device 1 Device 2
2. test_transaction_message_sending_from_wallet
Wait for ProgressBar Looking for GotItButton `E selenium.common.exceptions.NoSuchElementException: Message: 'GotItButton' is not found on screen, using: 'accessibility id:got-it-button'` Device sessions: Device 1 Device 2
3. test_send_tokens_in_1_1_chat
Type '0x049191be3d0b0258732a4c3bd66d2e68cf7e536a0a975fd501a3265cba9ff5f7c78f51345417e42f56e16926b685f99448ac05b9608b0d42cf65ee58853f104696' to PublicKeyEditBox Tap 'Confirm' on native keyboard `E selenium.common.exceptions.TimeoutException: Message: 'ChatMessageInput' is not found on screen, using: 'accessibility id:chat-message-input', during '60' seconds` Device sessions: Device 1 Device 2
4. test_network_mismatch_for_send_request_commands
Looking for SignTransactionButton Wait for ProgressBar `E selenium.common.exceptions.TimeoutException: Message: 'ProgressBar' is still present on screen, using: 'xpath://android.widget.ProgressBar', during '60' seconds` Device sessions: Device 1 Device 2
5. test_send_eth_in_1_1_chat
Looking for a transaction with unique amount 0.081112058 in list of transactions, address is 616874dc6cc2810cdc930dea26496fcf217d58ca Transaction with unique amount 0.081112058 is found in list of transactions, address is 616874dc6cc2810cdc930dea26496fcf217d58ca `E Failed: Message with the sent amount is not shown for the recipient` Device sessions: Device 1 Device 2
6. test_transaction_confirmed_on_sender_side
Transaction with unique amount 0.081111625 is found in list of transactions, address is 616874dc6cc2810cdc930dea26496fcf217d58ca Looking for a message by text: '0.081111625' `E Failed: Transaction state is not updated on the sender side` Device sessions: Device 1
7. test_transaction_confirmed_on_recipient_side
Looking for SignTransactionButton Wait for ProgressBar `E selenium.common.exceptions.TimeoutException: Message: 'ProgressBar' is still present on screen, using: 'xpath://android.widget.ProgressBar', during '60' seconds` Device sessions: Device 1 Device 2

Passed tests (44)

Click to expand

1. test_create_account
Device sessions: Device 1
2. test_filters_from_daap
Device sessions: Device 1
3. test_copy_and_paste_messages
Device sessions: Device 1
4. test_send_transaction_from_daap
Device sessions: Device 1
5. test_delete_cut_and_paste_messages
Device sessions: Device 1
6. test_deploy_contract_from_daap
Device sessions: Device 1
7. test_public_chat_messaging
Device sessions: Device 1 Device 2
8. test_back_forward_buttons_browsing_website
Device sessions: Device 1
9. test_set_profile_picture
Device sessions: Device 1
10. test_text_message_1_1_chat
Device sessions: Device 1 Device 2
11. test_add_to_contacts
Device sessions: Device 1 Device 2
12. test_home_view
Device sessions: Device 1
13. test_send_and_open_links
Device sessions: Device 1 Device 2
14. test_copy_contact_code_and_wallet_address
Device sessions: Device 1
15. test_message_marked_as_sent_and_seen_1_1_chat
Device sessions: Device 1 Device 2
16. test_send_token_with_7_decimals
Device sessions: Device 1
17. test_offline_messaging_1_1_chat
Device sessions: Device 1 Device 2
18. test_token_with_more_than_allowed_decimals
Device sessions: Device 1
19. test_send_eth_from_wallet_to_address
Device sessions: Device 1
20. test_send_transaction_details_in_1_1_chat
Device sessions: Device 1
21. test_request_eth_in_status_test_dapp
Device sessions: Device 1
22. test_manage_assets
Device sessions: Device 1
23. test_wallet_set_up
Device sessions: Device 1
24. test_request_and_receive_eth_in_1_1_chat
Device sessions: Device 1 Device 2
25. test_swipe_to_delete_public_chat
Device sessions: Device 1
26. test_send_emoji
Device sessions: Device 1
27. test_add_contact_by_pasting_public_key
Device sessions: Device 1
28. test_messaging_in_different_networks
Device sessions: Device 1 Device 2
29. test_resend_message_offline
Device sessions: Device 1 Device 2
30. test_swipe_to_delete_1_1_chat
Device sessions: Device 1
31. test_send_stt_from_wallet
Device sessions: Device 1
32. test_login_with_new_account
Device sessions: Device 1
33. test_send_eth_from_wallet_to_contact
Device sessions: Device 1
34. test_add_contact_from_public_chat
Device sessions: Device 1 Device 2
35. test_send_request_not_enabled_tokens
Device sessions: Device 1
36. test_send_message_to_newly_added_contact
Device sessions: Device 1 Device 2
37. test_backup_recovery_phrase
Device sessions: Device 1
38. test_offline_status
Device sessions: Device 1
39. test_open_google_com_via_open_dapp
Device sessions: Device 1
40. test_sign_message_from_daap
Device sessions: Device 1
41. test_share_contact_code_and_wallet_address
Device sessions: Device 1
42. test_request_eth_in_wallet
Device sessions: Device 1 Device 2
43. test_refresh_button_browsing_app_webview
Device sessions: Device 1
44. test_recover_account
Device sessions: Device 1

asemiankevich · 2018-08-01T15:00:03Z

Got this when refreshing txn history on recovered account (Android):

07:58 I/ReactNativeJS: NAME: "BigNumber Error"
07:58 I/ReactNativeJS: MESSAGE: TaskQueue: Error with task : BigNumber Error: div() not a number: null
07:58 I/ReactNativeJS: 
07:58 I/ReactNativeJS: This error is located at:
07:58 I/ReactNativeJS:     in t
07:58 I/ReactNativeJS:     in RCTView
07:58 I/ReactNativeJS:     in t
07:58 I/ReactNativeJS:     in RCTView
07:58 I/ReactNativeJS:     in RCTScrollView
07:58 I/ReactNativeJS:     in AndroidSwipeRefreshLayout
07:58 I/ReactNativeJS:     in RefreshControl
07:58 I/ReactNativeJS:     in ScrollView
07:58 I/ReactNativeJS:     in t
07:58 I/ReactNativeJS:     in t
07:58 I/ReactNativeJS:     in t
07:58 I/ReactNativeJS:     in reagent56
07:58 I/ReactNativeJS:     in RCTView
07:58 I/ReactNativeJS:     in history-list
07:58 I/ReactNativeJS:     in reagent133
07:58 I/ReactNativeJS:     in RCTView
07:58 I/ReactNativeJS:     in transactions
07:58 I/ReactNativeJS:     in reagent131
07:58 I/ReactNativeJS:     in RCTView
07:58 I/ReactNativeJS:     in main
07:58 I/ReactNativeJS:     in root
07:58 I/ReactNativeJS:     in reagent1
07:58 I/ReactNativeJS:     in RCTView
07:58 I/ReactNativeJS:     in RCTView
07:58 I/ReactNativeJS:     in t
07:58 I/ReactNativeJS: 
07:58 I/ReactNativeJS: Q@index.android.bundle:25:6268
07:58 I/ReactNativeJS: A@index.android.bundle:25:11801
07:58 I/ReactNativeJS: W@index.android.bundle:25:2594
07:58 I/ReactNativeJS: div@index.android.bundle:25:12273
07:58 I/ReactNativeJS: token__GT_unit@index.android.bundle:12:1352214
07:58 I/ReactNativeJS: internal__GT_formatted@index.android.bundle:12:1352925
07:58 I/ReactNativeJS: render_transaction@index.android.bundle:12:6920816
07:58 I/ReactNativeJS: index.android.bundle:12:6928130
07:58 I/ReactNativeJS: index.android.bundle:12:5747670
07:58 I/ReactNativeJS: value@index.android.bundle:349:9998
07:58 I/ReactNativeJS: f@index.android.bundle:136:83728
07:58 I/ReactNativeJS: beginWork@index.android.bundle:136:87321
07:58 I/ReactNativeJS: o@index.android.bundle:136:128242
07:58 I/ReactNativeJS: a@index.android.bundle:136:128621
07:58 I/ReactNativeJS: T@index.android.bundle:136:132129
07:58 I/ReactNativeJS: y@index.android.bundle:136:131565
07:58 I/ReactNativeJS: v@index.android.bundle:136:131402
07:58 I/ReactNativeJS: h@index.android.bundle:136:130681
07:58 I/ReactNativeJS: c@index.android.bundle:136:129935
07:58 I/ReactNativeJS: enqueueSetState@index.android.bundle:136:60044
07:58 I/ReactNativeJS: setState@index.android.bundle:198:1225
07:58 I/ReactNativeJS: _updateCellsToRender@index.android.bundle:327:19792
07:58 I/ReactNativeJS: index.android.bundle:328:597
07:58 I/ReactNativeJS: value@index.android.bundle:283:1025
07:58 I/ReactNativeJS: I@index.android.bundle:282:1181
07:58 I/ReactNativeJS: index.android.bundle:118:1787
07:58 I/ReactNativeJS: x@index.android.bundle:118:643
07:58 I/ReactNativeJS: k@index.android.bundle:118:1007
07:58 I/ReactNativeJS: callImmediates@index.android.bundle:118:3188
07:58 I/ReactNativeJS: value@index.android.bundle:113:3183
07:58 I/ReactNativeJS: index.android.bundle:113:1516
07:58 I/ReactNativeJS: value@index.android.bundle:113:3009
07:58 I/ReactNativeJS: value@index.android.bundle:113:1486
07:58 I/ReactNativeJS: [native code]
07:58 I/ReactNativeJS: value@index.android.bundle:113:1094
07:58 I/ReactNativeJS: [native code]
07:58 I/ReactNativeJS: 
07:58 I/ReactNativeJS: ***
07:58 I/HwPointEventFilter: do not support AFT because of no config

UPD: i talked to test team and i guess it is already in develop however i dont know how to repro it . Logged #5357

goranjovic · 2018-08-01T15:08:11Z

@asemiankevich it sure doesn't look related to the changes

status-comment-bot · 2018-08-02T00:06:26Z

branch PR-5351:
apk uploaded to https://i.diawi.com/oPWhrJ
ipa uploaded to https://i.diawi.com/4yc9DM

Install - Diawi - Development and In-house Apps Wireless Installation

asemiankevich · 2018-08-02T06:17:13Z

send / request huge amounts looks good to me, was able to do so from wallet and 1x1 chat

…equest Signed-off-by: Goran Jovic <goranjovic@gmail.com>

status-github-bot bot added this to REVIEW in Pipeline for QA Aug 1, 2018

goranjovic requested review from jeluard, yenda and flexsurfer August 1, 2018 09:22

goranjovic self-assigned this Aug 1, 2018

flexsurfer approved these changes Aug 1, 2018

View reviewed changes

jeluard approved these changes Aug 1, 2018

View reviewed changes

status-github-bot bot moved this from REVIEW to TO TEST in Pipeline for QA Aug 1, 2018

janherich approved these changes Aug 1, 2018

View reviewed changes

asemiankevich moved this from TO TEST to IN TESTING in Pipeline for QA Aug 1, 2018

asemiankevich self-assigned this Aug 1, 2018

asemiankevich added the Tested - OK label Aug 2, 2018

asemiankevich moved this from IN TESTING to MERGE in Pipeline for QA Aug 2, 2018

bug #4404 - removed the 21 char limit from amount field in send and r…

4be98b1

…equest Signed-off-by: Goran Jovic <goranjovic@gmail.com>

goranjovic force-pushed the bug/amount-field-width-4404 branch from 11aff7f to 4be98b1 Compare August 2, 2018 06:44

goranjovic merged commit 4be98b1 into develop Aug 2, 2018

Pipeline for QA automation moved this from MERGE to DONE Aug 2, 2018

goranjovic deleted the bug/amount-field-width-4404 branch August 2, 2018 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug #4404 - removed the 21 char limit from amount field in send and r… #5351

bug #4404 - removed the 21 char limit from amount field in send and r… #5351

goranjovic commented Aug 1, 2018

goranjovic commented Aug 1, 2018

jeluard commented Aug 1, 2018

status-comment-bot commented Aug 1, 2018 •

edited by status-github-bot bot

goranjovic commented Aug 1, 2018

statustestbot commented Aug 1, 2018

asemiankevich commented Aug 1, 2018 •

edited

goranjovic commented Aug 1, 2018

status-comment-bot commented Aug 2, 2018 •

edited by status-github-bot bot

asemiankevich commented Aug 2, 2018

bug #4404 - removed the 21 char limit from amount field in send and r… #5351

bug #4404 - removed the 21 char limit from amount field in send and r… #5351

Conversation

goranjovic commented Aug 1, 2018

Summary:

Steps to test:

goranjovic commented Aug 1, 2018

jeluard commented Aug 1, 2018

status-comment-bot commented Aug 1, 2018 • edited by status-github-bot bot

goranjovic commented Aug 1, 2018

statustestbot commented Aug 1, 2018

86% of end-end tests have passed

Failed tests (7)

Passed tests (44)

asemiankevich commented Aug 1, 2018 • edited

goranjovic commented Aug 1, 2018

status-comment-bot commented Aug 2, 2018 • edited by status-github-bot bot

asemiankevich commented Aug 2, 2018

status-comment-bot commented Aug 1, 2018 •

edited by status-github-bot bot

asemiankevich commented Aug 1, 2018 •

edited

status-comment-bot commented Aug 2, 2018 •

edited by status-github-bot bot