Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform periodic transaction state updates #5138

Closed
dmitryn opened this issue Jul 11, 2018 · 0 comments
Closed

Perform periodic transaction state updates #5138

dmitryn opened this issue Jul 11, 2018 · 0 comments
Assignees

Comments

@dmitryn
Copy link
Contributor

dmitryn commented Jul 11, 2018

Description

After transaction message has been sent/received (with /send command) we need to periodically fetch transactions data (using etherscan API) to display transaction state to the user.

Now we run transactions state update after certain events like transaction message sent/received, user opens Wallet or user taps on chat message with transaction. If user doesn't perform any of these actions (stays idle for example), he ends up with an outdated state showing that transaction is still pending or missing:
#4851
#4865

Solution

After transaction has been sent or received, run periodic (say every ~15s) updater until transaction reaches certain number of confirmations (say 12 confirmations). After that point, we could stop the updater to minimize mobile data and cpu consumption.

@goranjovic goranjovic added this to Shortlist in Wallet Maintenance Jul 12, 2018
@dmitryn dmitryn self-assigned this Jul 13, 2018
@dmitryn dmitryn moved this from Shortlist to In progress in Wallet Maintenance Jul 13, 2018
dmitryn added a commit that referenced this issue Jul 18, 2018
Fetch transactions state from etherscan every 15 seconds
if there are any unconfirmed transactions
dmitryn added a commit that referenced this issue Jul 20, 2018
Fetch transactions state from etherscan every 15 seconds
if there are any unconfirmed transactions

Signed-off-by: Dmitry Novotochinov <dmitry.novot@gmail.com>
Wallet Maintenance automation moved this from In progress to Done Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant