[#5138 #4851 #4865] periodic transaction state updates #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryn
force-pushed
the
feature/perodic-transactions-updates-#5138
branch
from
4193c9b
to
2a36fa8
Compare
goranjovic
approved these changes
Jul 18, 2018
|
branch PR-5221: |
janherich
approved these changes
Jul 18, 2018
82% of end-end tests have passedFailed tests (9)Click to expand
Passed tests (42)Click to expand
|
dmitryn
force-pushed
the
feature/perodic-transactions-updates-#5138
branch
from
2a36fa8
to
7c5ec4d
Compare
|
@dmitryn overall looks good. At least for a device that sends transactions (sender). But, there was a case when I think we stopped updating the transaction state for receiver. I send ETH from chat, waited for 15 min, then took 2nd the device (receiver) and clicked on the incoming transaction message (it was pending) and saw 8 confirmations. I went to transaction history, refreshed the screen couple of times and but there was still only 8 confirmations. When I opened Etherscan and there were already 30 confirmations. When I go back to the 1st device (the one that sent the transaction) the number of confirmations was also correct. Is there a timeout after which the app stops the polling? Is it the same for both sender and receiver? |
|
@lukaszfryc it should poll the same way for both sender and receiver every 15 seconds, no matter what screen you're on and no matter of doing manual refresh or not. |
|
branch PR-5221: |
|
@dmitryn I could not found that session and I tested it once again. This time, I didn't have a situation when updating transaction stopped at 8 confirmations. Instead, all transactions went from pending -> confirmed and all confirmed transactions have no more than 12 confirmations. When I went to transaction history in wallet, they were updated to the last confirmation number like 38 and matched what's in Etherscan. Is it expected that the app stops fetching after 12 confirmations and if you really want to see all confirmations you need to go to transaction history? If it's useful, here is TF session with part of the testing. |
|
@lukaszfryc yes, it's expected. We stop automatic fetching once we don't have any unconfirmed transactions (we consider minimum 12 confirmations as the safe threshold). |
|
@dmitryn I totally agree with you. OK, let me test it a bit more and maybe compare network consumption between this PR and develop. |
|
@dmitryn I did 6 min tests where I waited for 12 confirmations. On this PR, the battery decreased by 0.11% (TF session), on nightly ( |
|
@lukaszfryc thanks for testing, going to merge it now |
dmitryn
force-pushed
the
feature/perodic-transactions-updates-#5138
branch
from
7c5ec4d
to
2d6fdc0
Compare
This was referenced Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5138
Fixes #4851
Fixes #4865
Summary:
Fetch transactions state from etherscan every 15 seconds if there are any unconfirmed transactions or incoming chat transactions which are not synced to wallet.
status: ready