e2e for settings sync #13053
Merged
e2e for settings sync #13053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (54)
|
67% of end-end tests have passedFailed tests (23)Click to expand
Passed tests (47)Click to expand |
|
@Samyoul |
|
Hey @churik this is a |
|
Hey @Samyoul! One more request, can you rebase PR against the latest develop, please? |
Samyoul
force-pushed
the
feature/sync-settings
branch
3 times, most recently
from
055b440
to
8651d34
Compare
|
Hey @qoqobolo all rebased. |
|
builds failed: |
Samyoul
force-pushed
the
feature/sync-settings
branch
2 times, most recently
from
018b672
to
fd45369
Compare
|
Build issues resolved |
|
Thanks @Samyoul Here are the issues found so far: ISSUE 1: Can't switch to MainnetNothing happens after the confirmation. Also, get the Reproduction:
OS: Android, iOS Logs: IMG_1057.MP4ISSUE 2: Crash when switching the
|
|
Woah, those are some very weird issues. I'll start looking at them now. |
|
@Samyoul Also, can you clarify please what do you mean exactly by these settings:
Thanks 🙏 |
65% of end-end tests have passedFailed tests (57)Click to expand
Passed tests (107)Click to expand
|
ISSUE 5: Error when trying to re-login after 'manual' logoutIf the user is logged out by pressing the Steps:
OS: Android, iOS Logs: log_3.log IMG_1059.MP4 |
|
Hey @qoqobolo would you be able to send me the log cats for the fails? Thank you, sorry. |
100% of end-end tests have passedPassed tests (5)Click to expand
|
|
@Samyoul thanx for PR ISSUE 9It seems that there is no sense to add "preferred-name" setting sync at this moment, as syncing of the list of connected ENS is not implemented yet. So, it results in situation when primary ENS is displayed in user's Profile after sync but lisе of connected ENS is empty. STR:
Actual result: no connected ENS in list on device 1. At the same time, Primary ENS is displayed in Profile Expected result: we need to implement sync of connected ENS first. After that it will make sense to add sync of "preferred-name" setting. Until it is implemented it is better not to sync "preferred-name" setting. telegram-cloud-document-2-5319165310736013108.mp4 |
ISSUE 10"send-status-updates" setting does not need any additional syncing after devices pairing, because this setting is synced automatically by default on all devices for the same account. So, there should not be situation when different status values will be selected on different devices and therefore there is no need for additional syncing after devices pairing. Also, I noticed, that after devices are being paired, changing user's status on one device does not result every time in changing status on paired device. So, I guess recent implementing of "send-status-updates" sync during pairing might somehow be conflicting with existing default status syncing and therefore not working as expected.
|
Samyoul
force-pushed
the
feature/sync-settings
branch
from
f273cc7
to
236d18e
Compare
Parveshdhull
approved these changes
Mar 23, 2022
94% of end-end tests have passedFailed tests (5)Click to expand
Passed tests (74)Click to expand
|
100% of end-end tests have passedPassed tests (5)Click to expand
|
|
@Samyoul thanx for PR. Ready for merge. |
2 tasks
Samyoul
force-pushed
the
feature/sync-settings
branch
5 times, most recently
from
a86bc75
to
25221ca
Compare
status-im/status-go@f0d3e04...9f7fc78 Signed-off-by: Samuel Hawksby-Robinson <samuel@samyoul.com>
Samyoul
force-pushed
the
feature/sync-settings
branch
from
25221ca
to
21b21bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test branch for Synchronised Settings. Origin PR : status-im/status-go#2478
This PR implements sync for the following settings:
messages-from-contacts-onlyprofile-pictures-show-toprofile-pictures-visibilityDropped:
currencygifs/favorite-gifsgifs/recent-gifspreferred-namepreview-privacy?send-status-updates?stickers/packs-installedstickers/packs-pendingstickers/recent-stickersSync for settings works on pairing and on an ad hoc basis.
On pairing, all sync settings are synced over to the newly paired device.
On ad hoc, any sync setting that is updated will be synced over to paired device.
Issues
See profile pictures fromsettingreact sends a float go expects an intSee below◽ ISSUE 6: Error on the synced device when changing currency
--➡️ Pushed to #13190 - Synchronise
currencysetting◽ ISSUE 7: The preview-privacy setting is not applied on the synced Android device
--➡️ Pushed to #13192 - Synchronise
preview-privacy?setting◽ ISSUE 8: Error when adding a sticker pack
--➡️ Pushed to #13193- Synchronise Sticker Pack setting fields
◽ Issue 9: preferred name should be synced at the same time as ENS name list
--➡️ Pushed to #13204- ENS name list
usernamesshould sync withpreferred-namesetting◽ Issue 10: "send-status-updates" setting does not need any additional syncing after devices pairing
--> On hold