Synchronise Sticker Pack setting fields #13358
Conversation
Jenkins BuildsClick to see older builds (36)
|
flexsurfer
changed the title
audriu
force-pushed
the
13193-synchronise-sticker-pack-setting-fields
branch
2 times, most recently
from
8c5e163
to
7eb8d48
Compare
audriu
changed the title
audriu
force-pushed
the
13193-synchronise-sticker-pack-setting-fields
branch
from
7eb8d48
to
dbc581c
Compare
audriu
force-pushed
the
13193-synchronise-sticker-pack-setting-fields
branch
from
dbc581c
to
8375b64
Compare
|
@audriu thanx for the PR. Please, take look at following issue ISSUE 1 App crashes after purchasing of stickerpack when screen with stickerpack is opened during completion of transactionPrerequisites: Steps:
Actual result: app crashes. I failed to reproduce this bug in other PRs so I suppose it might be connected to current PR changes. Expected result: app does not crash. Install button appears after purchase is completed. OS: Android/IOS Crash.mp4 |
audriu
force-pushed
the
13193-synchronise-sticker-pack-setting-fields
branch
from
8375b64
to
eb5b82b
Compare
ISSUE 3 Messages are not delivered in group chatsSteps:
Actual result: no messages received in group chat Expected result: messages are received group_chats_bug.mp4ISSUE 4 Group chat re-appears in chat list on IOS after removing/leaving the chatSteps:
Actual result: deleted chat has re-appeared in chat list. Expected result: deleted chat does not re-appear telegram-cloud-document-2-5276168801157651127.mp4 |
audriu
force-pushed
the
13193-synchronise-sticker-pack-setting-fields
branch
from
4c71252
to
b872ada
Compare
95% of end-end tests have passedFailed tests (4)Click to expand
Passed tests (80)Click to expand
|
75% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (3)Click to expand
|
|
@audriu Thanx. Issue 3 and Issue 4 fixed after rebase of backend. For Issue 2 I will create a separate Issue in order nor to block merging of this PR. |
| (mapv (fn [sticker-synced] (assoc sticker-synced :url (as-> stickers-from-db vvv | ||
| (get vvv (:packID sticker-synced)) | ||
| (:stickers vvv) | ||
| (filter (fn [sticker-db] (= (:hash sticker-db) (:hash sticker-synced))) vvv) | ||
| (first vvv) | ||
| (:url vvv)))) synced-stickers)) |
There was a problem hiding this comment.
its little bit hard to read, here my suggestion, but it should be tested before merge
| (mapv (fn [sticker-synced] (assoc sticker-synced :url (as-> stickers-from-db vvv | |
| (get vvv (:packID sticker-synced)) | |
| (:stickers vvv) | |
| (filter (fn [sticker-db] (= (:hash sticker-db) (:hash sticker-synced))) vvv) | |
| (first vvv) | |
| (:url vvv)))) synced-stickers)) | |
| (mapv #(assoc % :url (-> (get stickers-from-db (:packID %) | |
| (:stickers) | |
| (filter (fn [sticker-db] (= (:hash sticker-db) (:hash %)))) | |
| (first) | |
| (:url)))) | |
| synced-stickers)) |
There was a problem hiding this comment.
Thanks for the review. I applied your recommendation (except used ->> because filter). It really looks more readable this way. Also tested - worked the same.
audriu
force-pushed
the
13193-synchronise-sticker-pack-setting-fields
branch
from
b872ada
to
26f2387
Compare
audriu
force-pushed
the
13193-synchronise-sticker-pack-setting-fields
branch
from
26f2387
to
e602a82
Compare
|
@audriu @cammellos @flexsurfer do we need to re-run e2e and make another round of manual testing due to recent changes? |
status-im/status-go@772b849...efa1480 Signed-off-by: Audrius Molis <masta@dr.com>
audriu
force-pushed
the
13193-synchronise-sticker-pack-setting-fields
branch
from
e602a82
to
2325f6f
Compare
|
@pavloburykh those changes were just code style. Logic did not change. Although I tested the affected part it still works. Thanks. |
|
@pavloburykh @audriu do you know if the following scenarios work? Scenario 1
Scenario 2
|
|
@Samyoul Scenario 1 only works correctly when devices are paired 1-2-1, but if paired 1 way then old sticker packs may get overridden on receiving device. when developed I had only live synchronization in mind. These scenarios have to be investigated. |
Synchronize Sticker Pack setting fields
fixes #13193
Summary
Implement functionality that handles the syncing of the stickers/recent-stickers settings
Platforms
Functional
Steps to test
Enable synchronization as described in this comment:
#13053 (comment)
Open Status
Send stickers and see them added to recent stickers and synchronized in another device with the same account.
status: ready