-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LoginWithConfig method to log in #13414
Conversation
Jenkins Builds
|
@@ -63,7 +63,7 @@ | |||
(re-frame/reg-fx | |||
::login | |||
(fn [[key-uid account-data hashed-password]] | |||
(status/login key-uid account-data hashed-password))) | |||
(status/login-with-config key-uid account-data hashed-password nil))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't use config in this PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didn't find the config we need use, any suggestion ? @flexsurfer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should use same config no ? @cammellos
70% of end-end tests have passed
Failed tests (25)Click to expand
Passed tests (59)Click to expand
|
56% of end-end tests have passed
Failed tests (37)Click to expand
Passed tests (47)Click to expand
|
51% of end-end tests have passed
Failed tests (18)Click to expand
Passed tests (19)Click to expand
|
@qfrank thanx for your contribution Please, take a look at following issue ISSUE 1 Password migration fails on IOS (error: "file does not exist" after login)Steps:
Actual result: error "file does not exist appears" Expected result: successful login to account Sorry for not attaching logs from IOS, as this functionality is currently broken in develop branch. telegram-cloud-document-2-5226439990472349856.mp4 |
hi @pavloburykh , do u know the corresponding source commit id to this PR ? i want to build it on my local machine to reproduce, thanks |
Hi @qfrank! We are not sure that we used a valid upgrade check in this case. So until we figure out a valid mechanism of how to test upgrade to PR builds from external contributors you can just ignore ISSUE 1. I'll keep you updated when we deal with this and verify if bug is valid. Thanx. |
17% of end-end tests have passed
Failed tests (15)Click to expand
Passed tests (3)Click to expand
|
47% of end-end tests have passed
Failed tests (8)Click to expand
Passed tests (7)Click to expand
|
@qfrank thanx for your contribution. Failed e2e are not connected to PR. So, ready for merge. |
fixes #13314