nix: pass OPENSEA_API_KEY via saveAccountAndLogin #13761
Conversation
Jenkins BuildsClick to see older builds (9)
|
jakubgs
force-pushed
the
opeansea-key-runtime
branch
from
a52922e
to
676102b
Compare
|
It looks like - as @flexsurfer pointed out - it's not enough just to use the The correct solution appears to be using the new |
jakubgs
force-pushed
the
opeansea-key-runtime
branch
from
ec859f5
to
d1f79e4
Compare
97% of end-end tests have passedFailed tests (3)Click to expandClass TestSendTxDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Passed tests (84)Click to expandClass TestPairingSyncMultipleDevicesMerged:
Class TestWalletManagementDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestRestoreOneDeviceMerged:
Class TestSendTxDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOneToOneChatMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
|
100% of end-end tests have passedPassed tests (3)Click to expandClass TestSendTxDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
|
|
@status-im/mobile-qa The manual testing should focus on features related to OpenSea NFT marketplace. Thanks! |
|
Tested and ready for merge. Thanx for cooperation @qoqobolo |
Here the injection of OpenSea API key was done at compile time: aa72ac57 But this makes `status-go` builds impure, and also prevents them from being extracted from `status-mobile` into `status-go` repo. Instead we pass the `OPENSEA_API_KEY` env variable to JS bundle at build time, which is then passed to `status-go` via the `Statusgo.saveAccountAndLogin` call in `saveAccountAndLogin`: https://github.com/status-im/status-mobile/blob/51174f84/modules/react-native-status/android/src/main/java/im/status/ethereum/module/StatusModule.java#L323-L327 Which sends `NodeConfig` that also contains `WalletConfig` which can include `OpenseaAPIKey`: ```go type WalletConfig struct { Enabled bool OpenseaAPIKey string `json:"OpenseaAPIKey"` } ``` https://github.com/status-im/status-go/blob/0135cc15/params/config.go#L510-L514 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
opeansea-key-runtime
branch
from
d1f79e4
to
8ec2f23
Compare
Here the injection of OpenSea API key was done at compile time: aa72ac57
But this makes
status-gobuilds impure, and also prevents them from being extracted fromstatus-mobileintostatus-gorepo.Instead we pass the
OPENSEA_API_KEYenv variable to JS bundle at build time, which is then passed tostatus-govia theStatusgo.saveAccountAndLogincall insaveAccountAndLogin:status-mobile/modules/react-native-status/android/src/main/java/im/status/ethereum/module/StatusModule.java
Lines 323 to 327 in 51174f8
Which sends
NodeConfigthat also containsWalletConfigwhich can includeOpenseaAPIKey:https://github.com/status-im/status-go/blob/0135cc15/params/config.go#L510-L514