Remove explicit join from group chats #13428

cammellos · 2022-05-30T14:38:16Z

Testing

e2e will likely need changing, as now chats are not explicitly joined by the users. cc @churik

We should test compatibility between this version and release, as behind the scene a chat is autojoined when accepted from the activity center.

status: ready

status-im-auto · 2022-05-30T14:46:00Z

Jenkins Builds

Click to see older builds (13)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`9a16b3d`	#1	2022-05-30 14:45:59	~7 min	`ios`	📄`log`
✖️	`9a16b3d`	#1	2022-05-30 14:50:14	~11 min	`android-e2e`	📦`apk` 📲

✔️	`951fdcb`	#2	2022-05-30 15:14:32	~9 min	`android-e2e`	📦`apk` 📲
✔️	`951fdcb`	#2	2022-05-30 15:17:31	~12 min	`android`	📦`apk` 📲
✔️	`951fdcb`	#2	2022-05-30 15:19:59	~14 min	`ios`	📦`ipa` 📲

✖️	`da0c4b8`	#3	2022-05-30 16:49:11	~11 min	`android-e2e`	📦`apk` 📲
✖️	`da0c4b8`	#3	2022-05-30 16:53:39	~16 min	`ios`	📦`ipa` 📲

✖️	`ce1cc3e`	#4	2022-05-30 16:54:55	~9 min	`android-e2e`	📦`apk` 📲
✖️	`ce1cc3e`	#4	2022-05-30 16:55:20	~9 min	`android`	📦`apk` 📲
✖️	`ce1cc3e`	#4	2022-05-30 17:01:38	~16 min	`ios`	📦`ipa` 📲

✔️	`555332c`	#5	2022-05-31 12:40:37	~9 min	`android`	📦`apk` 📲
✔️	`555332c`	#5	2022-05-31 12:40:47	~9 min	`android-e2e`	📦`apk` 📲
✔️	`555332c`	#5	2022-05-31 12:46:48	~15 min	`ios`	📦`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`06cd1ba`	#6	2022-06-06 16:41:15	~6 min	`ios`	📄`log`
✔️	`06cd1ba`	#6	2022-06-06 16:46:37	~11 min	`android`	📦`apk` 📲
✔️	`06cd1ba`	#6	2022-06-06 16:46:41	~11 min	`android-e2e`	📦`apk` 📲

❌	`464420e`	#7	2022-06-08 11:03:58	~5 min	`ios`	📄`log`
✔️	`464420e`	#7	2022-06-08 11:09:18	~10 min	`android-e2e`	📦`apk` 📲
✔️	`464420e`	#7	2022-06-08 11:09:28	~11 min	`android`	📦`apk` 📲

Parveshdhull · 2022-05-31T10:09:16Z

src/status_im/ui/screens/chat/group.cljs

-  (letsubs [{:keys [joined?]} [:group-chat/inviter-info chat-id]
-            removed? [:group-chat/removed-from-current-chat?]
-            invitations [:group-chat/invitations-by-chat-id chat-id]]
+  (letsubs [invitations [:group-chat/invitations-by-chat-id chat-id]]
    (if invitation-admin


no else part, can be replaced with when

status-im-auto · 2022-05-31T16:38:02Z

87% of end-end tests have passed

Total executed tests: 84
Failed tests: 11
Passed tests: 73

IDs of failed tests: 5342,700731,700764,5756,700763,702156,700765,700732,702157,3998,700757

Failed tests (11)

Click to expand

Rerun failed tests

1. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
`Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/6a2fd9beda454633a2019fafdde92f91` Class: TestSendTxDeviceMerged
2. test_group_chat_join_send_text_messages_push, id: 700731
# STEP: Join to group chat Device 2: Find `Button` by `accessibility id`: `join-chat-button` Device 2: Button by accessibility id: `join-chat-button` is not found on the screen Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
3. test_send_tx_token_7_decimals, id: 700764
`Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/6a2fd9beda454633a2019fafdde92f91` Class: TestSendTxDeviceMerged
4. test_group_chat_decline_invite_chat_highligted, id: 5756
Device 2: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented Device 2: Find `Button` by `xpath`: `//[@text="Decline invitation"]` Device 2: Button by xpath: `//[@text="Decline invitation"]` is not found on the screen Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
5. test_send_tx_eth_check_logcat, id: 700763
`Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/6a2fd9beda454633a2019fafdde92f91` Class: TestSendTxDeviceMerged
6. test_ens_mention_push_highlighted_public_chat, id: 702156
Device 2: Find `Button` by `xpath`: `//[starts-with(@text,'statuse2e.eth')]` Device 2: Image differs from template to 0.003679327208738973 percents `Mention is not highlighted!` Class: TestEnsStickersMultipleDevicesMerged* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
7. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
`Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/6a2fd9beda454633a2019fafdde92f91` Class: TestSendTxDeviceMerged
8. test_group_chat_add_new_member_activity_centre, id: 700732
Device 3: EditBox element not found Device 3: Find `Button` by `accessibility id`: `join-chat-button` Device 3: Button by accessibility id: `join-chat-button` is not found on the screen Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
9. test_sticker_1_1_public_chat, id: 702157
Device 1: Tap on found: EditBox Device 1: Find `Button` by `accessibility id`: `show-stickers-icon` Device 1: Button by accessibility id: `show-stickers-icon` is not found on the screen Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
10. test_group_chat_offline_pn, id: 3998
Device 2: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented Device 2: Find `Button` by `accessibility id`: `join-chat-button` Device 2: Button by accessibility id: `join-chat-button` is not found on the screen Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
11. test_send_tx_set_recipient_options, id: 700757
`Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/6a2fd9beda454633a2019fafdde92f91` Class: TestSendTxDeviceMerged

Passed tests (73)

Click to expand

1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_public_chat_open_using_deep_link, id: 700739
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_wallet_manage_assets, id: 700758
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_keycard_send_tx_eth, id: 700767
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_public_chat_fetch_more_history, id: 5675
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
7. test_public_chat_unread_messages_counter, id: 5360
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_pairing_sync_initial_contacts_blocked_users, id: 702194
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
12. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
13. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
14. test_browser_delete_close_tabs, id: 702076
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
15. test_group_chat_push_system_messages_when_invited, id: 3994
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
16. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
17. test_pairing_sync_public_chat_add_remove, id: 702199
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
18. test_browser_offline, id: 702075
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
19. test_public_chat_message_edit, id: 700734
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
20. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
21. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
22. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
23. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
24. test_ens_command_send_tx_eth_1_1_chat, id: 702153
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
25. test_restore_seed_phrase_field_validation, id: 700750
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
26. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
27. test_browser_connection_is_secure_not_secure_warning, id: 702073
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
28. test_ens_mention_nickname_1_1_chat, id: 702155
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
29. test_1_1_chat_text_message_with_push, id: 6316
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
30. test_browser_invalid_url, id: 702074
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
31. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
32. test_public_chat_link_send_open, id: 700736
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
33. test_1_1_chat_push_emoji, id: 6283
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
34. test_1_1_chat_message_reaction, id: 6315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
35. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
36. test_public_chat_emoji_send_copy_paste_reply, id: 700719
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
37. test_browser_web3_permissions_testdapp, id: 702078
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
38. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
39. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
40. test_ens_purchased_in_profile, id: 702152
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
41. test_keycard_relogin_after_restore, id: 700768
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
42. test_pairing_sync_initial_public_chats, id: 702195
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
43. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
44. test_pairing_sync_contacts_block_unblock, id: 702196
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
45. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
46. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
47. test_1_1_chat_image_send_save_reply, id: 6305
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
48. test_pairing_sync_1_1_chat_message, id: 702198
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
49. test_keycard_create_account_unlock_same_seed, id: 5689
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
50. test_browser_bookmarks_create_edit_remove, id: 702077
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
51. test_browser_blocked_url, id: 702072
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
52. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
53. test_public_chat_delete_chat_long_press, id: 5319
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
54. test_wallet_add_account_seed_phrase_collectibles_rinkeby_set_as_profile_image, id: 700762
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
55. test_wallet_add_hide_unhide_account_private_key, id: 700761
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
56. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
57. test_onboarding_share_contact_address, id: 700743
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
58. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
59. test_public_chat_message_delete, id: 700735
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
60. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
61. test_onboarding_home_initial_popup, id: 700742
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
62. test_public_chat_mark_all_messages_as_read, id: 6270
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
63. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
64. test_start_new_chat_public_key_validation, id: 702158
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
65. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
66. test_wallet_add_delete_watch_only_account, id: 700760
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
67. test_public_chat_tag_message, id: 700738
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
68. test_contact_block_unblock_public_chat_offline, id: 702176
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
69. test_onboarding_share_wallet_address, id: 700744
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
70. test_restore_set_up_wallet_sign_phrase, id: 700749
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
71. test_group_chat_leave_relogin, id: 3997
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
72. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
73. test_wallet_add_account_generate_new, id: 700759
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

status-im-auto · 2022-06-01T17:29:54Z

93% of end-end tests have passed

Total executed tests: 84
Failed tests: 6
Passed tests: 78

IDs of failed tests: 702156,702157,700731,5756,3998,700732

Failed tests (6)

Click to expand

Rerun failed tests

1. test_ens_mention_push_highlighted_public_chat, id: 702156
Device 2: Find `Button` by `xpath`: `//[starts-with(@text,'statuse2e.eth')]` Device 2: Image differs from template to 0.003679327208738973 percents `Mention is not highlighted!` Class: TestEnsStickersMultipleDevicesMerged* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_sticker_1_1_public_chat, id: 702157
Device 1: Tap on found: EditBox Device 1: Find `Button` by `accessibility id`: `show-stickers-icon` Device 1: Button by accessibility id: `show-stickers-icon` is not found on the screen Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_group_chat_join_send_text_messages_push, id: 700731
# STEP: Join to group chat Device 2: Find `Button` by `accessibility id`: `join-chat-button` Device 2: Button by accessibility id: `join-chat-button` is not found on the screen Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
4. test_group_chat_decline_invite_chat_highligted, id: 5756
Device 2: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented Device 2: Find `Button` by `xpath`: `//[@text="Decline invitation"]` Device 2: Button by xpath: `//[@text="Decline invitation"]` is not found on the screen Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
5. test_group_chat_offline_pn, id: 3998
Device 2: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented Device 2: Find `Button` by `accessibility id`: `join-chat-button` Device 2: Button by accessibility id: `join-chat-button` is not found on the screen Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
6. test_group_chat_add_new_member_activity_centre, id: 700732
Device 3: EditBox element not found Device 3: Find `Button` by `accessibility id`: `join-chat-button` Device 3: Button by accessibility id: `join-chat-button` is not found on the screen Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Passed tests (78)

Click to expand

1. test_wallet_add_account_seed_phrase_collectibles_rinkeby_set_as_profile_image, id: 700762
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_wallet_manage_assets, id: 700758
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_public_chat_message_edit, id: 700734
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_contact_block_unblock_public_chat_offline, id: 702176
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_keycard_relogin_after_restore, id: 700768
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
7. test_group_chat_push_system_messages_when_invited, id: 3994
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
8. test_ens_command_send_tx_eth_1_1_chat, id: 702153
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_send_tx_token_7_decimals, id: 700764
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
10. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_public_chat_open_using_deep_link, id: 700739
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
12. test_public_chat_unread_messages_counter, id: 5360
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
13. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
14. test_pairing_sync_contacts_block_unblock, id: 702196
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
15. test_public_chat_emoji_send_copy_paste_reply, id: 700719
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
16. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
17. test_browser_bookmarks_create_edit_remove, id: 702077
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
18. test_send_tx_eth_check_logcat, id: 700763
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
19. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
20. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
21. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
22. test_public_chat_delete_chat_long_press, id: 5319
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
23. test_onboarding_home_initial_popup, id: 700742
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
24. test_browser_blocked_url, id: 702072
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
25. test_wallet_add_hide_unhide_account_private_key, id: 700761
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
26. test_1_1_chat_message_reaction, id: 6315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
27. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
28. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
29. test_1_1_chat_image_send_save_reply, id: 6305
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
30. test_public_chat_link_send_open, id: 700736
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
31. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
32. test_onboarding_share_contact_address, id: 700743
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
33. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
34. test_restore_set_up_wallet_sign_phrase, id: 700749
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
35. test_ens_mention_nickname_1_1_chat, id: 702155
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
36. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
37. test_browser_delete_close_tabs, id: 702076
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
38. test_public_chat_mark_all_messages_as_read, id: 6270
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
39. test_browser_connection_is_secure_not_secure_warning, id: 702073
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
40. test_send_tx_set_recipient_options, id: 700757
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
41. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
42. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
43. test_browser_web3_permissions_testdapp, id: 702078
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
44. test_1_1_chat_text_message_with_push, id: 6316
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
45. test_wallet_add_delete_watch_only_account, id: 700760
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
46. test_public_chat_tag_message, id: 700738
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
47. test_onboarding_share_wallet_address, id: 700744
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
48. test_keycard_create_account_unlock_same_seed, id: 5689
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
49. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
50. test_pairing_sync_initial_contacts_blocked_users, id: 702194
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
51. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
52. test_pairing_sync_1_1_chat_message, id: 702198
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
53. test_pairing_sync_public_chat_add_remove, id: 702199
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
54. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
55. test_public_chat_fetch_more_history, id: 5675
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
56. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
57. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
58. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
59. test_ens_purchased_in_profile, id: 702152
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
60. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
61. test_keycard_send_tx_eth, id: 700767
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
62. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
63. test_browser_offline, id: 702075
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
64. test_browser_invalid_url, id: 702074
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
65. test_restore_seed_phrase_field_validation, id: 700750
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
66. test_wallet_add_account_generate_new, id: 700759
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
67. test_start_new_chat_public_key_validation, id: 702158
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
68. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
69. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
70. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
71. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
72. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
73. test_group_chat_leave_relogin, id: 3997
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
74. test_public_chat_message_delete, id: 700735
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
75. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
76. test_1_1_chat_push_emoji, id: 6283
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
77. test_pairing_sync_initial_public_chats, id: 702195
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
78. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

pavloburykh · 2022-06-03T15:28:05Z

@cammellos thanx for PR. Please take a look at following issue

ISSUE 1 User does not receive invitation to group chat if he has left this group chat before

User 1 adds User 2 to the group chat
User 2 joins the chat
User 2 leaves the chat
User 1 adds User 2 to the group chat again

Actual result: for a second indicator appears upon AC icon and then disappears. Group chat does not appear in AC. User 2 has not possibility to re-join group chat.

Expected result: new group chat appears in AC and user can re-join it

telegram-cloud-document-2-5246837619089742813.mp4

geth.log

status-im/status-go@ed67cc2...09ba88c Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>

cammellos self-assigned this May 30, 2022

cammellos requested a review from jakubgs as a code owner May 30, 2022 14:38

status-github-bot bot added this to REVIEW in Pipeline for QA May 30, 2022

cammellos force-pushed the feature/#13398-remove-explicit-join branch 2 times, most recently from 951fdcb to da0c4b8 Compare May 30, 2022 16:37

cammellos requested review from flexsurfer and Parveshdhull May 30, 2022 16:44

cammellos force-pushed the feature/#13398-remove-explicit-join branch from da0c4b8 to ce1cc3e Compare May 30, 2022 16:45

status-github-bot bot moved this from REVIEW to CONTRIBUTOR in Pipeline for QA May 31, 2022

Parveshdhull reviewed May 31, 2022

View reviewed changes

Parveshdhull approved these changes May 31, 2022

View reviewed changes

cammellos force-pushed the feature/#13398-remove-explicit-join branch from ce1cc3e to 555332c Compare May 31, 2022 12:30

cammellos added the request-manual-qa label May 31, 2022

cammellos moved this from CONTRIBUTOR to E2E Tests in Pipeline for QA May 31, 2022

churik moved this from E2E Tests to IN TESTING in Pipeline for QA Jun 1, 2022

churik moved this from IN TESTING to E2E Tests in Pipeline for QA Jun 1, 2022

pavloburykh self-assigned this Jun 2, 2022

pavloburykh moved this from E2E Tests to IN TESTING in Pipeline for QA Jun 2, 2022

pavloburykh mentioned this pull request Jun 3, 2022

Remove explicit join from group chats tests #13449

Closed

pavloburykh added the Tested - Issues label Jun 3, 2022

cammellos force-pushed the feature/#13398-remove-explicit-join branch from 555332c to 06cd1ba Compare June 6, 2022 16:34

pavloburykh added Tested - OK and removed Tested - Issues labels Jun 7, 2022

pavloburykh moved this from IN TESTING to MERGE in Pipeline for QA Jun 7, 2022

cammellos force-pushed the feature/#13398-remove-explicit-join branch from 06cd1ba to 464420e Compare June 8, 2022 10:58

[Fixes: #13398] Remove explic join group chat

aa71b83

status-im/status-go@ed67cc2...09ba88c Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>

cammellos force-pushed the feature/#13398-remove-explicit-join branch from 464420e to aa71b83 Compare June 8, 2022 10:58

cammellos merged commit aa71b83 into develop Jun 8, 2022

Pipeline for QA automation moved this from MERGE to DONE Jun 8, 2022

cammellos deleted the feature/#13398-remove-explicit-join branch June 8, 2022 10:58

qoqobolo mentioned this pull request Jun 9, 2022

leave group chat fix #13463

Merged

Parveshdhull mentioned this pull request Jul 4, 2022

[13587] Change text of group invitation push notification #13624

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove explicit join from group chats #13428

Remove explicit join from group chats #13428

cammellos commented May 30, 2022 •

edited

status-im-auto commented May 30, 2022 •

edited

Parveshdhull May 31, 2022

status-im-auto commented May 31, 2022

status-im-auto commented Jun 1, 2022

pavloburykh commented Jun 3, 2022 •

edited

Remove explicit join from group chats #13428

Remove explicit join from group chats #13428

Conversation

cammellos commented May 30, 2022 • edited

Testing

status-im-auto commented May 30, 2022 • edited

Jenkins Builds

Parveshdhull May 31, 2022

Choose a reason for hiding this comment

status-im-auto commented May 31, 2022

87% of end-end tests have passed

Failed tests (11)

Passed tests (73)

status-im-auto commented Jun 1, 2022

93% of end-end tests have passed

Failed tests (6)

Passed tests (78)

pavloburykh commented Jun 3, 2022 • edited

ISSUE 1 User does not receive invitation to group chat if he has left this group chat before

cammellos commented May 30, 2022 •

edited

status-im-auto commented May 30, 2022 •

edited

pavloburykh commented Jun 3, 2022 •

edited