leave group chat fix

[flexsurfer]

1. A adds B to group chat
2. B accepts group chat and enters group chat
3. B leaves group chat (now B is home)
4. A re-adds B
   B sees the notification flashing, but it's accepted immediately,

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	ffa67e7	#1	2022-06-08 10:06:43	~12 min	android-e2e	📦apk 📲
✔️	ffa67e7	#1	2022-06-08 10:07:14	~13 min	android	📦apk 📲
✔️	ffa67e7	#1	2022-06-08 10:09:42	~15 min	ios	📦ipa 📲

[status-im-auto]

96% of end-end tests have passed

Total executed tests: 84
Failed tests: 3
Passed tests: 81

IDs of failed tests: 700762,702157,3998 

Failed tests (3)

Click to expand

Rerun failed tests

1. test_wallet_add_account_seed_phrase_collectibles_rinkeby_set_as_profile_image, id: 700762

Device 1: Find `Text` by `xpath`: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView` Device 1: Find `Text` by `xpath`: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView` Device 1: Text by xpath: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView` is not found on the screen Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot

2. test_sticker_1_1_public_chat, id: 702157

Device 1: Tap on found: EditBox Device 1: Find `Button` by `accessibility id`: `show-stickers-icon` Device 1: Button by accessibility id: `show-stickers-icon` is not found on the screen Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

3. test_group_chat_offline_pn, id: 3998

Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member message from old member PN was not fetched from offline message from new member PN was not fetched from offline Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Passed tests (81)

Click to expand

1. test_wallet_manage_assets, id: 700758

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

2. test_public_chat_message_edit, id: 700734

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_contact_block_unblock_public_chat_offline, id: 702176

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_keycard_relogin_after_restore, id: 700768

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

6. test_group_chat_push_system_messages_when_invited, id: 3994

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

7. test_ens_command_send_tx_eth_1_1_chat, id: 702153

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_send_tx_token_7_decimals, id: 700764

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

9. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

10. test_public_chat_open_using_deep_link, id: 700739

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

11. test_public_chat_unread_messages_counter, id: 5360

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

12. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

13. test_pairing_sync_contacts_block_unblock, id: 702196

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

14. test_public_chat_emoji_send_copy_paste_reply, id: 700719

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

15. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

16. test_browser_bookmarks_create_edit_remove, id: 702077

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

17. test_send_tx_eth_check_logcat, id: 700763

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

18. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

19. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

20. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

21. test_public_chat_delete_chat_long_press, id: 5319

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

22. test_onboarding_home_initial_popup, id: 700742

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

23. test_browser_blocked_url, id: 702072

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

24. test_wallet_add_hide_unhide_account_private_key, id: 700761

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

25. test_1_1_chat_message_reaction, id: 6315

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

26. test_ens_mention_push_highlighted_public_chat, id: 702156

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

27. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

28. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

29. test_1_1_chat_image_send_save_reply, id: 6305

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

30. test_public_chat_link_send_open, id: 700736

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

31. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

32. test_onboarding_share_contact_address, id: 700743

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

33. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

34. test_restore_set_up_wallet_sign_phrase, id: 700749

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

35. test_ens_mention_nickname_1_1_chat, id: 702155

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

36. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

37. test_browser_delete_close_tabs, id: 702076

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

38. test_public_chat_mark_all_messages_as_read, id: 6270

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

39. test_browser_connection_is_secure_not_secure_warning, id: 702073

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

40. test_send_tx_set_recipient_options, id: 700757

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

41. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

42. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

43. test_group_chat_join_send_text_messages_push, id: 700731

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

44. test_browser_web3_permissions_testdapp, id: 702078

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

45. test_1_1_chat_text_message_with_push, id: 6316

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

46. test_wallet_add_delete_watch_only_account, id: 700760

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

47. test_group_chat_decline_invite_chat_highligted, id: 5756

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

48. test_public_chat_tag_message, id: 700738

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

49. test_onboarding_share_wallet_address, id: 700744

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

50. test_keycard_create_account_unlock_same_seed, id: 5689

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

51. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

52. test_pairing_sync_initial_contacts_blocked_users, id: 702194

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

53. test_public_chat_navigate_to_chat_when_relaunch, id: 5396

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

54. test_pairing_sync_1_1_chat_message, id: 702198

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

55. test_pairing_sync_public_chat_add_remove, id: 702199

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

56. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

57. test_public_chat_fetch_more_history, id: 5675

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

58. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

59. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

60. test_group_chat_add_new_member_activity_centre, id: 700732

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

61. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

62. test_ens_purchased_in_profile, id: 702152

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

63. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

64. test_keycard_send_tx_eth, id: 700767

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

65. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

66. test_browser_offline, id: 702075

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

67. test_browser_invalid_url, id: 702074

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

68. test_restore_seed_phrase_field_validation, id: 700750

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

69. test_wallet_add_account_generate_new, id: 700759

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

70. test_start_new_chat_public_key_validation, id: 702158

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

71. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

72. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

73. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

74. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

75. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

76. test_group_chat_leave_relogin, id: 3997

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

77. test_public_chat_message_delete, id: 700735

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

78. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

79. test_1_1_chat_push_emoji, id: 6283

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

80. test_pairing_sync_initial_public_chats, id: 702195

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

81. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

[qoqobolo]

@flexsurfer thanks for the fix!
Found a weird behavior with a pretty tricky reproduction, but I was unable to replicate in the develop, so might be worth a look.

ISSUE 1: User receives a notification in the activity center for the declined group, if they removed an admin of the group from contacts, been removed from the group members by the admin, and reopens the app

Steps:

1. Create UserA and UserB
2. Users add to contacts each other
3. UserA creates a group with UserB
4. UserB declines the invitation
5. UserB removes UserA from contacts
6. UserB closes the app
7. UserA: group chat info > remove UserB from the group
8. UserB reopens the app and logs in

video_2022-06-08_17-07-21.mp4

[qoqobolo]

@flexsurfer, I still managed to reproduce Issue 1 in yesterday's develop.
Also, since #13428 has already been merged, the bug has probably gone (the user can no longer decline an invitation to the group chat).
So please ignore my comment above.

PR can be merged.