Fix crash on x86_64 emulators #17773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (144)
|
siddarthkay
force-pushed
the
fix-crash-on-x86-64
branch
from
284a1e8
to
abd83de
Compare
siddarthkay
force-pushed
the
fix-crash-on-x86-64
branch
from
abd83de
to
13f172a
Compare
siddarthkay
force-pushed
the
fix-crash-on-x86-64
branch
from
5a9d228
to
f59ef63
Compare
|
@siddarthkay tested on my local x86_64 emulator, i'm able to create account now, but It seems that this Android APK version has lost its network communication capability. e.g. make contact request not work anymore |
|
Thanks for testing locally @qfrank! |
|
Doesn't also hurt to run E2E :) |
40% of end-end tests have passedFailed tests (23)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (18)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
|
29% of end-end tests have passedFailed tests (28)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (13)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
Issues from failed e2e tests:
|
siddarthkay
commented
Nov 1, 2023
test/appium/tests/base_test_case.py
Outdated
| @@ -67,7 +67,7 @@ def get_capabilities_sauce_lab(): | |||
| caps['appium:app'] = 'sauce-storage:' + test_suite_data.apk_name | |||
| caps['appium:deviceName'] = 'Android GoogleAPI Emulator' | |||
| caps['appium:deviceOrientation'] = 'portrait' | |||
| caps['appium:platformVersion'] = '10.0' | |||
| caps['appium:platformVersion'] = '12.0' | |||
There was a problem hiding this comment.
@yevh-berdnyk : just curious, do we have platformVersion 14 available at appium/saucelabs ?
There was a problem hiding this comment.
Yes, I've just ran one of the tests on Android14 and it passed
siddarthkay
force-pushed
the
fix-crash-on-x86-64
branch
from
841b226
to
158d697
Compare
4 tasks
29% of end-end tests have passedFailed tests (28)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (13)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
|
|
@yevh-berdnyk : both the issues seem to be fixed with my last commit I believe. I also followed steps of inviting 2 users as shown by @VolodLytvynenko in the issue description here : #17678 |
Cool, thank you! |
siddarthkay
force-pushed
the
fix-crash-on-x86-64
branch
from
60f122b
to
3f38ccb
Compare
67% of end-end tests have passedFailed tests (8)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (8)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Passed tests (33)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
siddarthkay
force-pushed
the
fix-crash-on-x86-64
branch
2 times, most recently
from
5e63c58
to
c0f7300
Compare
14% of end-end tests have passedFailed tests (38)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (7)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
|
39% of end-end tests have passedFailed tests (24)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Expected to fail tests (6)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (19)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
|
Closed
siddarthkay
force-pushed
the
fix-crash-on-x86-64
branch
2 times, most recently
from
9845a0e
to
6725c44
Compare
79% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (6)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Passed tests (38)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
|
yevh-berdnyk
force-pushed
the
fix-crash-on-x86-64
branch
from
c50d634
to
c0abb54
Compare
siddarthkay
added a commit
to status-im/status-go
that referenced
this pull request
Dec 14, 2023
Due to presence of syscall to `epoll_wait` android emulators after Android 10 would crash. This commit has added `amd64` fallback implementations in 2 spots - `tcp-shaker` ref : status-im/tcp-shaker@571aa46 - `notify` ref : status-im/notify@0eb36e6 The build flags are updated for fallback implementation to only be used in case of `x86_64` simulators. status-mobile PR : status-im/status-mobile#17773
|
Hi @siddarthkay, |
siddarthkay
commented
Dec 14, 2023
ci/Jenkinsfile.android
Outdated
| @@ -1,5 +1,5 @@ | |||
| #!/usr/bin/env groovy | |||
| library 'status-jenkins-lib@v1.7.15' | |||
| library 'status-jenkins-lib@switch_e2e_to_x86_64' | |||
There was a problem hiding this comment.
@yakimant : should we get this merged in jenkins repo first?
There was a problem hiding this comment.
First, congrats with PR!
Regarding the jenkins lib - it switches the build from 32 to 64 bit.
Which is required to run on Android 12+ emulators.
As I understand you PR fixes issues on 64 bit emulators.
But is it compatible wit 32 bit still?
Another question is switching e2e emulators to Android 12+ 64bit.
Does it happen on SauceLab UI or in our repo?
@yevh-berdnyk, can you help?
There was a problem hiding this comment.
Hi,
No, it's not compatible with 32 anymore.
Regarding SayceLabs emulators - we're just changing Android version if we need it and that's it. But SauceLabs emulators are x86_64. E2e tests will still run after merging this PR
There was a problem hiding this comment.
hmm @yevh-berdnyk : thats because the CI for this PR points to this branch of status-jenkins-lib
I'm not sure that will be the case if we revert this change.
Also we can't or shouldn't merge this PR without this change first being merged in status-jenkins-lib
probably @jakubgs or @yakimant , @apentori can confirm...
siddarthkay
force-pushed
the
fix-crash-on-x86-64
branch
from
115db6c
to
323beed
Compare
siddarthkay
force-pushed
the
fix-crash-on-x86-64
branch
from
323beed
to
d4ee7a0
Compare
siddarthkay
force-pushed
the
fix-crash-on-x86-64
branch
from
d4ee7a0
to
7cbcd80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
fixes #17265
Platforms
Functional
Non-functional
Todos
status: ready