Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#19048] feat: show contact QR code #19139

Merged
merged 4 commits into from Mar 8, 2024
Merged

[#19048] feat: show contact QR code #19139

merged 4 commits into from Mar 8, 2024

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Mar 8, 2024 •
edited

fixes #19048

Summary

Show contact QR code

Result

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Mar 8, 2024
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Mar 8, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 8, 2024 •
edited

Jenkins Builds

Click to see older builds (20)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 01cb867 #1 2024-03-08 09:35:50 ~6 min tests 📄log
✔️ 01cb867 #1 2024-03-08 09:37:29 ~7 min android-e2e 🤖apk 📲
✔️ 01cb867 #1 2024-03-08 09:37:39 ~7 min android 🤖apk 📲
✔️ 01cb867 #1 2024-03-08 09:42:21 ~12 min ios 📱ipa 📲
✔️ 806c8a0 #2 2024-03-08 10:10:07 ~8 min android-e2e 🤖apk 📲
✔️ 806c8a0 #2 2024-03-08 10:10:14 ~8 min android 🤖apk 📲
✔️ 806c8a0 #2 2024-03-08 10:13:12 ~11 min ios 📱ipa 📲
✔️ 2b7e539 #3 2024-03-08 11:41:48 ~6 min tests 📄log
✔️ 3a9a028 #4 2024-03-08 11:49:18 ~7 min android 🤖apk 📲
✔️ 3a9a028 #4 2024-03-08 11:49:42 ~7 min android-e2e 🤖apk 📲
✔️ 3a9a028 #4 2024-03-08 11:54:21 ~12 min ios 📱ipa 📲
✔️ c70d42c #7 2024-03-08 13:44:43 ~7 min android-e2e 🤖apk 📲
✔️ c70d42c #7 2024-03-08 13:45:24 ~8 min android 🤖apk 📲
✔️ aaa4a93 #8 2024-03-08 13:53:15 ~7 min android-e2e 🤖apk 📲
✔️ aaa4a93 #8 2024-03-08 13:53:17 ~7 min android 🤖apk 📲
✔️ aaa4a93 #8 2024-03-08 13:58:18 ~12 min ios 📱ipa 📲
✔️ 8b890d5 #9 2024-03-08 14:54:34 ~6 min tests 📄log
✔️ 8b890d5 #9 2024-03-08 14:56:38 ~8 min android-e2e 🤖apk 📲
✔️ 8b890d5 #9 2024-03-08 14:56:46 ~8 min android 🤖apk 📲
✔️ 8b890d5 #9 2024-03-08 14:59:14 ~11 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 637717b #10 2024-03-08 16:37:43 ~12 min ios 📱ipa 📲
✔️ 637717b #10 2024-03-08 16:38:13 ~12 min tests 📄log
✔️ 637717b #10 2024-03-08 16:39:00 ~13 min android 🤖apk 📲
✔️ 637717b #10 2024-03-08 16:39:16 ~13 min android-e2e 🤖apk 📲
✔️ 1ae219b #11 2024-03-08 21:11:57 ~6 min tests 📄log
✔️ 1ae219b #11 2024-03-08 21:14:02 ~8 min android-e2e 🤖apk 📲
✔️ 1ae219b #11 2024-03-08 21:14:09 ~8 min android 🤖apk 📲
✔️ 1ae219b #11 2024-03-08 21:17:33 ~11 min ios 📱ipa 📲

@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/contact-share-qr branch 3 times, most recently from 2b7e539 to 3a9a028 Compare March 8, 2024 11:41
@mohsen-ghafouri mohsen-ghafouri marked this pull request as ready for review March 8, 2024 11:43
@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/contact-share-qr branch 2 times, most recently from 37826a4 to c70d42c Compare March 8, 2024 13:36
@mohsen-ghafouri
Copy link
Contributor Author

thanks @cammellos @J-Son89 @seanstrom, I resolved the comments, please have a look again.

seanstrom
seanstrom approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅
I left one comment related to the anonymous function / use-callback / static defn stuff.

src/status_im/contexts/profile/contact/share/view.cljs Outdated Show resolved Hide resolved
@mohsen-ghafouri mohsen-ghafouri moved this from REVIEW to E2E Tests in Pipeline for QA Mar 8, 2024
@mohsen-ghafouri mohsen-ghafouri moved this from E2E Tests to REVIEW in Pipeline for QA Mar 8, 2024
@mohsen-ghafouri mohsen-ghafouri moved this from REVIEW to E2E Tests in Pipeline for QA Mar 8, 2024
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 48
Failed tests: 5
Expected to fail tests: 1
Passed tests: 42

IDs of failed tests: 702809,703086,702850,702786,702731 

IDs of expected to fail tests: 703503

Failed tests (5)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Tap on found: Button
    Device 1: Click until `Text` by `accessibility id`: `community-description-text` will be presented 

    critical/chats/test_public_chat_browsing.py:767: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Community element
E    New messages counter is not shown in community channel element



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 1: Tap on found: Button
    Device 1: Find Text by xpath: //*[@content-desc="pending-contact-requests-count"]/android.widget.TextView 

    activity_center/test_activity_center.py:70: in test_activity_center_contact_request_decline
    if self.home_1.pending_contact_request_text.text != '1':
../views/base_element.py:415: in text
    text = self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Text by xpath: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731

    Device 1: Find Text by xpath: //*[starts-with(@text,'Message 3')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 1: Text is Sent 

    critical/chats/test_1_1_public_chats.py:222: in test_1_1_chat_pin_messages
    self.chat_1.chat_element_by_text(message).wait_for_status_to_be("Delivered")
../views/chat_view.py:243: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/chats/test_public_chat_browsing.py:980: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 bold text in asterics is not displayed with markdown in community channel for the recipient (device 1) 
E   
E    bold text in underscores is not displayed with markdown in community channel for the recipient (device 1)



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:928: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Edited message is not shown correctly for the (receiver) admin



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (42)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    3. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    @mohsen-ghafouri mohsen-ghafouri merged commit e283a72 into develop Mar 8, 2024
    6 checks passed
    Pipeline for QA automation moved this from E2E Tests to DONE Mar 8, 2024
    @mohsen-ghafouri mohsen-ghafouri deleted the feat/contact-share-qr branch March 8, 2024 21:36
    @mohsen-ghafouri mohsen-ghafouri mentioned this pull request Mar 14, 2024
    Merged
    @mohsen-ghafouri mohsen-ghafouri mentioned this pull request Apr 1, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @seanstrom seanstrom seanstrom approved these changes

    @yqrashawn yqrashawn Awaiting requested review from yqrashawn

    @cammellos cammellos Awaiting requested review from cammellos

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @mohsen-ghafouri mohsen-ghafouri

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
      
    DONE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Feature: Show Contact QR Code
    5 participants
    @mohsen-ghafouri @status-im-auto @cammellos @seanstrom @J-Son89