Root keys named :wallet/... moved as nested under :wallet root key #19152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (11)
|
vkjr
force-pushed
the
single-wallet-root-key
branch
2 times, most recently
from
97d1a3d
to
584370d
Compare
J-Son89
reviewed
Mar 8, 2024
| :wallet/local-suggestions nil | ||
| :wallet/valid-ens-or-address? false)})) | ||
| {:db (-> db | ||
| (assoc-in [:wallet :search-address :local-suggestions] nil) |
There was a problem hiding this comment.
maybe put it in :ui, i,e (assoc-in [:wallet :ui :search-address :local-suggestions] nil)
cc @ulisesmac
J-Son89
reviewed
Mar 8, 2024
| @@ -267,3 +267,18 @@ | |||
| :wallet/transactions | |||
| :<- [:wallet] | |||
| :-> :transactions) | |||
|
|
|||
| (rf/reg-sub | |||
There was a problem hiding this comment.
some tests would be great too! 🙏
J-Son89
approved these changes
Mar 8, 2024
vkjr
force-pushed
the
single-wallet-root-key
branch
from
e0bc793
to
db55660
Compare
75% of end-end tests have passedFailed tests (11)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (36)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
|
92% of end-end tests have passedFailed tests (3)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (44)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
@vkjr thanks for the pr. E2E results are okay. In case manual qa is not required PR is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18724
Summary
Root keys in app-db named
:wallet/...moved as nested under:walletroot key.status: ready