-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reaction drawer issue #19754
fix: reaction drawer issue #19754
Conversation
Jenkins BuildsClick to see older builds (25)
|
0635184
to
1e637d8
Compare
1e637d8
to
6d09b69
Compare
83% of end-end tests have passed
Failed tests (7)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (43)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
fde689f
to
0d2375a
Compare
29% of end-end tests have passed
Failed tests (2)Click to expandClass TestDeepLinksOneDevice:
Expected to fail tests (3)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
Passed tests (2)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
0d2375a
to
63f03de
Compare
Hi @codemaster115 thank you for PR. No issues from my side. @Francesca-G could you check the current PR, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the review
main issues are fixed, we're just missing the add reaction button and I added a comment related to the avatar that we couldn't address during the main review since it wasn't visible 🙏
63f03de
to
e284fe2
Compare
@codemaster115 as confirmed by Mario the add reaction button isn't needed because this bottom sheet is opened by clicking the same button in chat. Thanks for spotting it |
Thanks for your confirmation. @Francesca-G |
1217ac2
to
f76836c
Compare
fixes #19280
Summary
Platforms
Functional
Steps to test
Before and after screenshots comparison
status: ready