Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide empty categories and categories that include only hidden channels #20006

Merged
merged 2 commits into from
May 16, 2024
Merged

Hide empty categories and categories that include only hidden channels #20006

merged 2 commits into from
May 16, 2024

Conversation

Parveshdhull
Copy link
Member

fixes #19885

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 14, 2024
@Parveshdhull Parveshdhull self-assigned this May 14, 2024
@Parveshdhull Parveshdhull moved this from REVIEW to E2E Tests in Pipeline for QA May 14, 2024
@status-im-auto
Copy link
Member

status-im-auto commented May 14, 2024 •
edited

Jenkins Builds

Click to see older builds (24)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6217e6b #1 2024-05-14 05:48:35 ~4 min tests 📄log
✔️ 6217e6b #1 2024-05-14 05:49:55 ~5 min android-e2e 🤖apk 📲
✔️ 6217e6b #1 2024-05-14 05:51:07 ~7 min android 🤖apk 📲
✔️ 6217e6b #1 2024-05-14 05:52:53 ~8 min ios 📱ipa 📲
✔️ c0217d1 #2 2024-05-14 08:33:17 ~5 min tests 📄log
✔️ c0217d1 #2 2024-05-14 08:35:40 ~8 min android 🤖apk 📲
✔️ c0217d1 #2 2024-05-14 08:35:49 ~8 min android-e2e 🤖apk 📲
✔️ c0217d1 #2 2024-05-14 08:35:49 ~8 min ios 📱ipa 📲
❌ 97032f2 #3 2024-05-16 09:27:17 ~2 min tests 📄log
✔️ 97032f2 #3 2024-05-16 09:30:43 ~6 min android-e2e 🤖apk 📲
❌ 76672bc #4 2024-05-16 09:34:37 ~2 min tests 📄log
✔️ 76672bc #4 2024-05-16 09:39:17 ~7 min android-e2e 🤖apk 📲
✔️ 76672bc #4 2024-05-16 09:39:28 ~7 min android 🤖apk 📲
✔️ 76672bc #4 2024-05-16 09:41:10 ~9 min ios 📱ipa 📲
❌ 76672bc #5 2024-05-16 09:47:15 ~1 min tests 📄log
❌ 720b1fe #6 2024-05-16 09:50:07 ~1 min tests 📄log
❌ e1c8443 #7 2024-05-16 09:53:41 ~1 min tests 📄log
✔️ e1c8443 #6 2024-05-16 09:58:17 ~6 min android-e2e 🤖apk 📲
✔️ e1c8443 #6 2024-05-16 09:58:25 ~6 min android 🤖apk 📲
✔️ e1c8443 #6 2024-05-16 10:02:10 ~10 min ios 📱ipa 📲
❌ 052813e #8 2024-05-16 10:20:08 ~1 min tests 📄log
✔️ 052813e #7 2024-05-16 10:25:24 ~7 min android-e2e 🤖apk 📲
✔️ 052813e #7 2024-05-16 10:25:29 ~7 min android 🤖apk 📲
✔️ 052813e #7 2024-05-16 10:27:08 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b5d0169 #9 2024-05-16 10:51:58 ~3 min tests 📄log
✔️ b5d0169 #8 2024-05-16 10:55:20 ~7 min android 🤖apk 📲
✔️ b5d0169 #8 2024-05-16 10:55:24 ~7 min android-e2e 🤖apk 📲
✔️ b5d0169 #8 2024-05-16 10:56:37 ~8 min ios 📱ipa 📲
✔️ 1817a86 #10 2024-05-16 11:12:48 ~4 min tests 📄log
✔️ 1817a86 #9 2024-05-16 11:14:30 ~5 min android-e2e 🤖apk 📲
✔️ 1817a86 #9 2024-05-16 11:15:46 ~6 min android 🤖apk 📲
✔️ 1817a86 #9 2024-05-16 11:17:11 ~8 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 52
Failed tests: 5
Expected to fail tests: 1
Passed tests: 46

IDs of failed tests: 727230,704613,727229,702807,702775 

IDs of expected to fail tests: 703503

Failed tests (5)

Click to expand
  • Rerun failed tests

    • Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find `Button` by `xpath`: `//*[@text="open community"]`
    Device 1: Tap on found: Button 

    critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Open community for e2e' was not requested to join by the url https://status.app/c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab 

    critical/test_deep_and_universal_links.py:114: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Open community for e2e' was not requested to join by the deep link status.app://c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:39: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:109: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:99: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:86: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:80: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (46)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Parveshdhull
    Parveshdhull commented May 14, 2024
    View reviewed changes
    src/status_im/contexts/communities/overview/view.cljs
    :type :title
    :text-align :left
    :icon-name :i/close
    :on-press #(rf/dispatch [:navigate-back])}]
    [quo/empty-state
    {:image (resources/get-themed-image :cat-in-box theme)
    :description (when-not fetching? (i18n/label :t/here-is-a-cat-in-a-box-instead))
    :title (if fetching? "Fetching community..." "Failed to fetch community")
    :title (if fetching?
    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Small additional change, leftover from #19968 (comment)

    (should not affect review or e2e, just moved string to translation files)

    cc @ajayesivan @seanstrom

    @qoqobolo qoqobolo self-assigned this May 15, 2024
    @qoqobolo qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA May 15, 2024
    @qoqobolo
    Copy link
    Contributor

    Thanks for your work @Parveshdhull!
    LGTM, PR can be merged.

    @qoqobolo qoqobolo moved this from IN TESTING to MERGE in Pipeline for QA May 16, 2024
    @Parveshdhull Parveshdhull force-pushed the fix/hide-categories branch 2 times, most recently from 97032f2 to 76672bc Compare May 16, 2024 09:31
    @status-im-auto
    Copy link
    Member

    ✔️ status-mobile/prs/android/PR-20006#3 🔹 ~7 min 22 sec 🔹 97032f2 🔹 📦 android package

    @Parveshdhull
    Copy link
    Member Author

    Not sure why unit-tests are failing after rebase. @siddarthkay Please can you check.

    @Parveshdhull
    Copy link
    Member Author

    Not sure why unit-tests are failing after rebase. @siddarthkay Please can you check.

    Maybe because I pressed restart tests button, but now it seems all tests are failing

    @siddarthkay
    Copy link
    Contributor

    Hey @Parveshdhull : will take a look ASAP

    @Parveshdhull
    Copy link
    Member Author

    Hey @Parveshdhull : will take a look ASAP

    awsm, thank you very much

    @Parveshdhull
    Copy link
    Member Author

    Parveshdhull commented May 16, 2024 •
    edited

    #19994 PR merged now, without any issues 🤔

    @siddarthkay
    Copy link
    Contributor

    #20061 also does not have the same issue. so probably this issue is host related. linux-03

    @Parveshdhull
    Copy link
    Member Author

    Parveshdhull commented May 16, 2024 •
    edited

    #20061 also does not have the same issue. so probably this issue is host related. linux-03

    hi, reverting #20044, did fix tests for my PR
    (related conversation)

    @siddarthkay
    Copy link
    Contributor

    Hi @Parveshdhull
    feel free to merge this PR I'll make a follow up PR and investigate.
    Thank you

    @Parveshdhull
    Copy link
    Member Author

    Hi @Parveshdhull feel free to merge this PR I'll make a follow up PR and investigate. Thank you

    cool, thank you

    @Parveshdhull
    revert "attach target to test-watch-for-repl command (#20044)"
    1817a86 
    This reverts commit 05f3810.

Signed-off-by: Parvesh Monu <parvesh.dhullmonu@gmail.com>
    @Parveshdhull Parveshdhull merged commit 1817a86 into develop May 16, 2024
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE May 16, 2024
    @Parveshdhull Parveshdhull deleted the fix/hide-categories branch May 16, 2024 11:17
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @ajayesivan ajayesivan ajayesivan approved these changes

    @BalogunofAfrica BalogunofAfrica BalogunofAfrica approved these changes

    @seanstrom seanstrom Awaiting requested review from seanstrom

    Assignees

    @Parveshdhull Parveshdhull

    @qoqobolo qoqobolo

    Labels
    request-manual-qa test cases required Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Hide private channel if created with the "hidden option"
    7 participants
    @Parveshdhull @status-im-auto @qoqobolo @siddarthkay @flexsurfer @ajayesivan @BalogunofAfrica